Writeup of JupyterLab style issues/milestones: application to jupyter/notebook

88 views
Skip to first unread message

Brian Granger

unread,
Jan 7, 2017, 12:42:06 PM1/7/17
to Project Jupyter
Hi all,

I have opened this PR describing how we are using labels/milestones in
JupyterLab:

https://github.com/jupyter/governance/pull/29

I recently restructured the notebook labels/milestones to use this
approach. In the coming weeks, I would like to work with Grant - and
anyone else wanting to help - to do a pass on the jupyter/notebook
issues to:

* Implement this approach
* Close ones that are stale or outdated
* Target many/most new feature requests towards the JupyterLab
milestone (eventually to be migrated to the jlab repo)
* Try to narrow down the work that needs to be done for the 5.0 and
4.4. milestones.
* Start to perform regular visualizations of the notebook issues
similar to this:

https://github.com/jupyterlab/jupyterlab/issues/1439

Hopefully this will enable us to get a better handle on where things
are at with the notebook repo and aid in the smooth migration to
JupyterLab.

Cheers,

Brian


--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgra...@calpoly.edu and elli...@gmail.com

Matthias Bussonnier

unread,
Jan 7, 2017, 1:38:46 PM1/7/17
to jup...@googlegroups.com
Short from my phone :

Please don't change the label now the bot I'm writing requires current label to work correctly, same as current migration script. 

I believe some links in our docs (as well as Stack Overflow) also requires some of the current labels.
-- 
M


--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CAH4pYpTQh9fWcHVsUPG%3DEBgPkpmn2-KJbEMJ1BCp-T%3DA%3Dt2uRg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Brian Granger

unread,
Jan 7, 2017, 2:03:01 PM1/7/17
to Project Jupyter
I have been talking to Grant about making the label changes for months
now and I was under the impression that the notebook+JupyterLab team
talked about this at the team meeting and were on board with this
change. If that wasn't the case I apologize for moving forward with
this. In case it wasn't clear, I am only touching labels on the
jupyter/notebook repo.

The label changes were made a couple of week ago, but we can back off
parts of it that are needed for backporting and migration.
Realistically though, to migrate issues between notebook and
JupyterLab in a meaningful way, we will need to have a uniform label
taxonomy anyways.

Not being able to change labels at all isn't viable. All of the old
labels that existed have a corresponding label in the new schema. For
example, we now have `status: Needs Backport`. If we need labels that
are more "programmatic" for backporting (`backport-4.3.1`) we can
absolutely add those back (I don't think jupyter/notebook had any of
those). Can you clarify exactly what labels the migration tools are
using and how? More than willing to accommodate all of that. I tried
to look for details of the migration stuff but couldn't find any.
Could you provide links?

Keep in mind, we have almost 500 issues on the notebook repo, with
relatively few developers. On JupyterLab, we have 4-6ish full time
devs are have to work really hard to keep up with our 200ish issues
there. In order to make notebook development sustainable and enable a
smooth transition to JupyterLab, we need to reduce the number of
issues to something that is manageable for the developers we have. The
work you are doing on GH automation is going to be *super helpful* but
there is no substitute for old-fashion human time spent going through
issues (yes, I plan on figuring out how we can go through all ~500
issues on the notebook repo).

Cheers,

Brian
> email to jupyter+u...@googlegroups.com.
> To post to this group, send email to jup...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jupyter/CAH4pYpTQh9fWcHVsUPG%3DEBgPkpmn2-KJbEMJ1BCp-T%3DA%3Dt2uRg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Project Jupyter" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jupyter+u...@googlegroups.com.
> To post to this group, send email to jup...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jupyter/CANJQusVaFDrmqw3uGV-GJdEAKsZOV85Afg-bksGR1ZjJaMrHFA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



Matthias Bussonnier

unread,
Jan 8, 2017, 5:33:06 AM1/8/17
to jup...@googlegroups.com
On Sat, Jan 7, 2017 at 8:02 PM, Brian Granger <elli...@gmail.com> wrote:
> I have been talking to Grant about making the label changes for months
> now and I was under the impression that the notebook+JupyterLab team
> talked about this at the team meeting and were on board with this
> change. If that wasn't the case I apologize for moving forward with
> this. In case it wasn't clear, I am only touching labels on the
> jupyter/notebook repo.

It's ok, I am happy on changing the labels in general, especially
uniformisation.
I was hopping to keep the same label for some time for IPython/IPython
and Jupyter/Notebook
to do some of these issues migrations first.


> The label changes were made a couple of week ago, but we can back off
> parts of it that are needed for backporting and migration.
> Realistically though, to migrate issues between notebook and
> JupyterLab in a meaningful way, we will need to have a uniform label
> taxonomy anyways.

I think mostly the "sprint friendly" and "quickfix" had a lot of external link.
There are a number of place where user are pointed to GitHub search
that use these labels if their gone then the searches and links are broken.


> Not being able to change labels at all isn't viable. All of the old
> labels that existed have a corresponding label in the new schema. For
> example, we now have `status: Needs Backport`. If we need labels that
> are more "programmatic" for backporting (`backport-4.3.1`) we can
> absolutely add those back (I don't think jupyter/notebook had any of
> those). Can you clarify exactly what labels the migration tools are
> using and how? More than willing to accommodate all of that. I tried
> to look for details of the migration stuff but couldn't find any.
> Could you provide links?

The migration bot transfer labels based on names.
Building a map is painful, but doable.


>
> Keep in mind, we have almost 500 issues on the notebook repo, with
> relatively few developers. On JupyterLab, we have 4-6ish full time
> devs are have to work really hard to keep up with our 200ish issues
> there. In order to make notebook development sustainable and enable a
> smooth transition to JupyterLab, we need to reduce the number of
> issues to something that is manageable for the developers we have. The
> work you are doing on GH automation is going to be *super helpful* but
> there is no substitute for old-fashion human time spent going through
> issues (yes, I plan on figuring out how we can go through all ~500
> issues on the notebook repo).
>

Yes, and when it was decided that "issues should be triaged" on
Jupyter notebook.
I did 10-15 per days for a week and half before stopping because I was
the only one doing it,
so there is no need to remind me.

I have concerns on the naming/coloring scheme you use for tags but
that ship has sailed now.

Cheers,
--
M
> To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CAH4pYpT4b9jE4LtYH%2BuFXvq8uqrCdackx7zoLm99sUsQTmASDQ%40mail.gmail.com.

Brian Granger

unread,
Jan 8, 2017, 11:49:49 PM1/8/17
to Project Jupyter
> I have concerns on the naming/coloring scheme you use for tags but
> that ship has sailed now.

Please provide feedback on the PR. We would like this scheme to be
useful to the rest of the project, and while we have been using it for
a while now, it is surely not perfect at this point. If there are ways
we can make it more general and useful that would be really nice. I
recognize that the JupyterLab repo may have aspects that are
representative of other repo.

Cheers,

Brian
> To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CANJQusXR1m4oGHB%3DuFqOwUGRyshZyLdAFxZkgdK0Q40SOXvigA%40mail.gmail.com.

JamieW

unread,
Jan 10, 2017, 3:36:08 PM1/10/17
to Project Jupyter, elli...@gmail.com
Definitely interested in this thread! I'll chime in on the repos, also interested in being pulled into the ideation phases of issue management discussions.

-Jamie
--
Jamie Whitacre
Jupyter Technical Project Manager
Berkeley Institute for Data Science (BIDS)
Reply all
Reply to author
Forward
0 new messages