Request to be maintainer of EnvInject Plugin

[Manuel Jesús Recena Soto]

Hello,

For the last week, I was working on this ticket [1]. Here its related PR [2].

I sent an email to Grégory (the official maintainer) before to start
working on it in order to know if he was participating actively the
plugin. He replied this "I tried to maintain it but I've got not
enough time at the moment."

I think that this plugin is very used in a lot of Jenkins
installations. This plugin is related to other plugins, p.e,
Subversion Plugin. In fact, I started to work on it because I was
trying to solve a problem in Subversion Plugin.

I saw that the latest release was done by Oleg but (AFAIK) he is not
an official maintainer.

I'd like to be maintainer of the plugin if you agree.

Regards,

[1] https://issues.jenkins-ci.org/browse/JENKINS-29817
[2] https://github.com/jenkinsci/envinject-plugin/pull/56

--
Manuel Recena Soto
* manuelrecena.com [/blog]
* linkedin.com/in/recena

[oliver gondža]

You are a committer and JIRA component lead.

--
oliver

[Kanstantsin Shautsou]

Oleg is identifying very well recena errors in PRs. Recena has only 1 commit in master so granting permissions ahead is bad idea. Does he already resolved all subversion issues?

-1 for recena as main maintainer

+1 for oleg that already did releases and reviewing PRs

[Manuel Jesús Recena Soto]

Hello Oliver,

Thanks for your time.

I hope to reach some result in EnvInject Plugin soon.

Regards,

> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/op.x3ck2i1lsbfict%40arch.
> For more options, visit https://groups.google.com/d/optout.

[Oleg Nenashev]

Yes, I can take the ownership if Manuel agrees.

I have no capacity to deal with old issues, but at least I can review PRs and handle regressions if they happen after the release.

пятница, 14 августа 2015 г., 11:38:17 UTC+3 пользователь Manuel Recena Soto написал:

[Manuel Jesús Recena Soto]

Better two than one ;)

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c95ba6f3-22d0-43e2-940e-f908d04ba2f4%40googlegroups.com.

[Oleg Nenashev]

Unfortunately, we have only one "default assignee" (component lead) in JIRA, whom we consider as an owner. BTW, from the github permissions scope, several maintainers are OK. I'll update the POM files later.

In any case, I hope to release 1.92 later today

воскресенье, 16 августа 2015 г., 14:02:50 UTC+3 пользователь Manuel Recena Soto написал:

[Manuel Jesús Recena Soto]

Hello Oliver,

It seems Kanstantsin disagree [1] with your decission about my request
to be maintainer.

Could you revert these permissions?

Regards,

[1] https://github.com/jenkinsci/envinject-plugin/pull/67#issuecomment-133896730

2015-08-14 9:43 GMT+02:00 oliver gondža <ogo...@gmail.com>:

> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/op.x3ck2i1lsbfict%40arch.
> For more options, visit https://groups.google.com/d/optout.

[Oleg Nenashev]

Hi Manuel,

There is no need to revoke permissions. I've changed the default assignee according to our previous discussion, so now I'm a person who is supposed to be a "maintainer".

Regarding the push permissions, I don't see a need to revoke them. You are an active Jenkins contributor, who makes useful fixes and changes in many plugins including EnvInject. Even if we sometimes disagree on PR approaches, as a plugin developer you should be able to deliver a hot-fix if there is such need.

Best regards,

Oleg

воскресенье, 23 августа 2015 г., 22:08:57 UTC+3 пользователь Manuel Recena Soto написал: