Wrapping Gitlab API into a separate plugin

[parichay...@gmail.com]

Hi all,

I am working on improving the Gitlab Plugins. The first plan is to move to a gitlab-api-plugin which provides Gitlab Java Apis rather than using the ones implemented inside the plugins codebase. This will be similar to github-api-plugin. 

What is the advantage of wrapping an API inside a plugin over using Apis directly as a dependency?

If someone experienced with development of Github Api Plugin or similar, please take a look at our gitlab-api-plugin:

https://github.com/jenkins-gitlab/gitlab-api-plugin

Your review will be higly appreciated.

Regards,

Parichay (baymac)

[Matt Sicker]

The main advantage to using an API plugin is to allow the library to
be reused by other plugins without each plugin needing to maintain
updates to the dependencies manually. Instead, the API plugin is used
for those libraries which reduces maintenance burden, especially
whenever CVEs are discovered.

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c162286c-924e-4ea8-9f10-358d0c9000c6%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Matt Sicker
Senior Software Engineer, CloudBees

[Parichay Barpanda]

Thanks Matt that was helpful. :)

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4ow4Sr1hXZ%3D9mT82%3DVYe6sS3N70d1HJ2G10RwP3NXLp1kA%40mail.gmail.com.

[Jesse Glick]

On Mon, Apr 29, 2019 at 12:38 PM Matt Sicker <msi...@cloudbees.com> wrote:
> The main advantage to using an API plugin is to allow the library to
> be reused by other plugins

Technical details if you are interested:

https://jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#using-library-wrapper-plugins