Changelog is now YAML and lives in the site repository

閲覧: 17 回
最初の未読メッセージにスキップ

Daniel Beck

未読、
2017/02/20 4:41:312017/02/20
To: Jenkins Developers
Hi everyone,

I moved the changelog to the site:
https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml

All that's left in jenkinsci/jenkins is a tombstone file directing people to the file above:
https://github.com/jenkinsci/jenkins/blob/master/changelog.html

Daniel

Arnaud Héritier

未読、
2017/02/20 5:38:172017/02/20
To: jenkin...@googlegroups.com
Even if I understand the technical need, I don't like to have the changelog leaving outside of the project repository. 
Am I the only one? Aren't we taking a risk to have it outdated?

Wasn't it possible to copy it from the project repo to the website build ?


Daniel

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9FA10634-1DE9-4E4E-BA7F-D8EC62F00CE5%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.



--
-----
Arnaud Héritier
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

Daniel Beck

未読、
2017/02/20 6:42:032017/02/20
To: jenkin...@googlegroups.com

> On 20.02.2017, at 11:37, Arnaud Héritier <aher...@gmail.com> wrote:
>
> I don't like to have the changelog leaving outside of the project repository.

It already was in the case of LTS (which AFAIK is the line more successful with users since we made it more discoverable on the site), and nobody cared. (And don't get me started on the uselessness of old LTS changelogs…)

The technical 'changelog' is the (history in the) GitHub repository. What we're discussing here is user documentation, similar to the LTS upgrade guide. So it's not wrong for it to be in the site repository, where the rest of the documentation delivered via the site lives.

> Am I the only one? Aren't we taking a risk to have it outdated?

No less than before. At least for the past year, Oleg and I were the only ones filling in the changelog for releases (often on the Monday following the weekly release, so there were plenty of opportunities for others to contribute).

In fact, we started actively discouraging changelog additions in PRs due to additional merge effort when they aren't merged the same week, and conflicts even when they are.

Oleg and I wrote ~95% of the weekly changelog for the last year. Oliver and I wrote all of the LTS changelog. We were all in favor of this change as you can see in the PR referenced below.

> Wasn't it possible to copy it from the project repo to the website build ?

As I explained in https://github.com/jenkins-infra/jenkins.io/pull/661#issuecomment-280625408 that would not be a great idea unless we add significant infra support around the changelog (generate its HTML independently from the site build). Doesn't seem worth the effort.

Arnaud Héritier

未読、
2017/02/20 7:37:102017/02/20
To: jenkin...@googlegroups.com
Ok. If main contributors are happy with it, I have nothing to say. 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/257C76FC-E970-43FE-8096-72A44F9E68EA%40beckweb.net.

For more options, visit https://groups.google.com/d/optout.

Oleg Nenashev

未読、
2017/02/21 7:00:282017/02/21
To: Jenkins Developers
I would not say I am 100% happy since the current state requires long PR builds, etc. I would also prefer keeping changelogs in the main repo. But now it is definitely a step forward compared to what we had before. If we experience significant issues with the current state, likely we will consider moving to the separate repo.

BR, Oleg

понедельник, 20 февраля 2017 г., 13:37:10 UTC+1 пользователь Arnaud Héritier написал:
全員に返信
投稿者に返信
転送
新着メール 0 件