Rename of JGiven-Plugin artifactId

[Stefan Wolf]

Hi,

I created a new plugin (see https://wiki.jenkins-ci.org/display/JENKINS/JGiven+Plugin and https://github.com/jenkinsci/jgiven-plugin).

It seems to me that I got the artifactId wrong - it should probably be jgiven and not jgiven-plugin.

Now I would like to rename that since not many users will have installed the plugin yet...

I opened a pull request to backend-update-center2 (https://github.com/jenkinsci/backend-update-center2/pull/10) to ignore the jgiven-plugin and would then release a new version of the plugin with the correct artifactId.

Could someone please merge the pull request? Who has commit access to this repository - I am in the core group and don't have...

Regards,

Stefan

[Daniel Beck]

The repo is owned by the infra team, so I could merge it.

Do you know why some entries are 'foo=1' while others are just 'foo'? Does this not matter?

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ff29a7e4-f40a-40b8-9f4f-99a4d203f133%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Baptiste Mathus]

Reading the code, doesn't seem it does.

That properties file is indeed loaded as a Properties instance [1], and then only the key is ever used if I read correctly [2].

Just read the java.util.Properties and loading a key-only properties file actually seems totally supported (though nothing states it clearly in the doc).

So I guess the =1 should just be removed from every lines to prevent people to lose time to understand it although it's useless.

[1] https://github.com/jenkinsci/backend-update-center2/blob/8b7b031ae2b9b222a17ef85ad02c3c509fb8dc1b/src/main/java/org/jvnet/hudson/update_center/MavenRepositoryImpl.java#L296

[2] https://github.com/jenkinsci/backend-update-center2/blob/8b7b031ae2b9b222a17ef85ad02c3c509fb8dc1b/src/main/java/org/jvnet/hudson/update_center/MavenRepositoryImpl.java#L240

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/372ECC6F-4C6F-4B23-821D-6689F8BA8365%40beckweb.net.

For more options, visit https://groups.google.com/d/optout.

--

Baptiste <Batmat> MATHUS - http://batmat.net
Sauvez un arbre,
Mangez un castor !

[Stefan Wolf]

Hi Daniel,

Am Freitag, 20. Februar 2015 15:25:44 UTC+1 schrieb Daniel Beck:

The repo is owned by the infra team, so I could merge it.

Yes, please!

 

Do you know why some entries are 'foo=1' while others are just 'foo'? Does this not matter?

I can second Baptiste's comment that it doesn't matter, so you could remove all the "=1"s.

Thanks,

Stefan 

[Daniel Beck]

Merged.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/962aa736-bcdb-412f-b781-c15221730b84%40googlegroups.com.