Patch for JENKINS-20998

234 views
Skip to first unread message

bram.s...@gmail.com

unread,
Dec 12, 2014, 7:14:27 AM12/12/14
to jenkin...@googlegroups.com
I have created a patch for issue https://issues.jenkins-ci.org/browse/JENKINS-20998. See attached screenshot for the resulting Workspace View.

Disclaimers: This is my first attempt at a Jenkins contribution. I have read the relevant pages on contributing to Jenkins turned up by Google search. I do not have an account on the Jira issue tracker, nor do I have a Github account. Hence, this submission via the mailing list.
jenkins-20998-ws-timestamp.png
JENKINS-20998.patch

Bruno P. Kinoshita

unread,
Dec 12, 2014, 7:58:10 AM12/12/14
to jenkin...@googlegroups.com
Hi Bram!

Would you be willing to create a GitHub account and submit a pull request? I think that'd be easier for others to review and/or comment your code.

I've linked your message in the JIRA issue, so maybe watchers of that issue will take a look at your patch and provide some feedback on it.
All the best,
Bruno


From: "bram.s...@gmail.com" <bram.s...@gmail.com>
To: jenkin...@googlegroups.com
Sent: Friday, December 12, 2014 10:14 AM
Subject: Patch for JENKINS-20998

I have created a patch for issue https://issues.jenkins-ci.org/browse/JENKINS-20998. See attached screenshot for the resulting Workspace View.

Disclaimers: This is my first attempt at a Jenkins contribution. I have read the relevant pages on contributing to Jenkins turned up by Google search. I do not have an account on the Jira issue tracker, nor do I have a Github account. Hence, this submission via the mailing list.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1e9baa27-5169-48ad-8de2-b01b1ffe7ee5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Daniel Beck

unread,
Dec 13, 2014, 5:59:26 PM12/13/14
to jenkin...@googlegroups.com
DirectoryBrowserSupport.Path is part of the public Jenkins API and this changes it in a backwards-incompatible way (removing the previous constructor).

FWIW it'd be great if core allowed plugins to contribute file browser columns. Then this could easily be solved in a plugin.

On 12.12.2014, at 13:14, bram.s...@gmail.com wrote:

> I have created a patch for issue https://issues.jenkins-ci.org/browse/JENKINS-20998. See attached screenshot for the resulting Workspace View.
>
> Disclaimers: This is my first attempt at a Jenkins contribution. I have read the relevant pages on contributing to Jenkins turned up by Google search. I do not have an account on the Jira issue tracker, nor do I have a Github account. Hence, this submission via the mailing list.
>
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1e9baa27-5169-48ad-8de2-b01b1ffe7ee5%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> <jenkins-20998-ws-timestamp.png><JENKINS-20998.patch>

aravind sankar

unread,
Sep 19, 2017, 8:47:42 AM9/19/17
to Jenkins Developers
Hello Bram,

I have a similar requirement in Jenkins for displaying the timestamp of the files in a job(as in image : jenkins-20998-ws-timestamp.png) . I tried to use your patch file as it is by passing your file as a Build Parameter, but it was throwing me errors ( "Can't find file to patch" error ) . Kindly let me know if you have contributed further by developing any Jenkins Plugins for the same purpose. Or if you have come across some useful links/plugins for the same. Thanks in advance :)

Best Regards,
Aravind

Jesse Glick

unread,
Sep 19, 2017, 9:13:29 AM9/19/17
to Jenkins Dev
On Sat, Dec 13, 2014 at 5:52 PM, Daniel Beck <m...@beckweb.net> wrote:
> it'd be great if core allowed plugins to contribute file browser columns. Then this could easily be solved in a plugin.

Yes, that could be useful.
Reply all
Reply to author
Forward
0 new messages