Milestones for further development

[Uwe Plonus]

Hi all,

I would like to create some milestones in our project:

* 1.8.0
o Change build system
o Refactoring to new packages (according to domain name)
o Refactoring to Java 1.8
* 1.8.1
o Fixing current open bugs
* 2.0.0
o New project structure (e.g. Refactor out Adjudicator to external
package/project)
o New UI

Are you OK with this structure?

The main reason for the milestones is to keep us focused at the moment
to push the development forward.

Greets

Uwe

[Jiri Peinlich]

The roadmap looks ok for me.

I started introducing generics into the project. I have created a new branch depending on the testing branch where I go throw the -Xlint deprecated/unchecked warnings and trying to get rid of them. There is ton of them. I will first focus on introducing the generics. There are some gotchas that I found already, For instance sometimes there would be two different types of objects used as a key in hashmap:

https://gitlab.com/jdip/jdip/blob/master/jdip_168r1/src/main/java/dip/gui/ClientMenu.java#L164  (defined map)

https://gitlab.com/jdip/jdip/blob/master/jdip_168r1/src/main/java/dip/gui/ClientMenu.java#L413  (key is of type Item)

https://gitlab.com/jdip/jdip/blob/master/jdip_168r1/src/main/java/dip/gui/ClientMenu.java#L1026 (key is of type Power)

Neither Power nor Item inherit from each other ¯\_(ツ)_/¯.

Jiri

--
You received this message because you are subscribed to the Google Groups "jDip Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jdip-develope...@googlegroups.com.
To post to this group, send email to jdip-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jdip-developers/363bf794-76be-e262-0da9-84068f8f84ab%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Uwe Plonus]

I created 2 milestones: 1.8.0 and 1.8.1

It's primary to track our progress on our way down the road.

Greets

Uwe

> <mailto:jdip-developers%2Bunsu...@googlegroups.com>.

> To post to this group, send email to
> jdip-de...@googlegroups.com

> <mailto:jdip-de...@googlegroups.com>.

[Jiri Peinlich]

I noticed that on lots of places the GNU GPL v2 is still used, maybe it would be worth to update those for 1.8.0

[Jiri Peinlich]

I was able to reduce the amount of warnings -Xlint:deprication and -Xlint:unchecked produces down to 10 when build with jdk8 and 11 when build with jdk 11. Apart from the last few collections I introduced Generic type into all the collections used around the project and I removed the autoboxing and creating new instances for numbers. The aditionall warning in jdk 11 is comming from deprecated method that got a replacement only in jdk10 and so I cannot use it under jdk8 build.

To deal with the last 10 warnings:

• some of them are creating of arrays of collections. I think we should replace the arrays with collections to remove the warnings.
• There are few warnings around the SVGUtils.java lists and maps. It was not trivial to add the generic types to those collections because they are used differently up and down the chain of calls.
  

On some places I had to generify the collection with Object class. I did not find a better way, and tried to put a todo around those places for future improvements.

It would be nice if you could go throw the changes and review them, thanks.

[Uwe Plonus]

Hi Jiri,

the changes look good.

If you open a file in your editor you can also reformat the code to
adhere to current coding guidelines (brackets come into my mind).

For the remaining warning: We will also change the libraries (at least
to newer versions) so perhaps some warnings will perhaps vanish...

Great work

Uwe

On 07.11.18 02:33, Jiri Peinlich wrote:
> I was able to reduce the amount of warnings -Xlint:deprication and
> -Xlint:unchecked produces down to 10 when build with jdk8 and 11 when
> build with jdk 11. Apart from the last few collections I introduced
> Generic type into all the collections used around the project and I
> removed the autoboxing and creating new instances for numbers. The
> aditionall warning in jdk 11 is comming from deprecated method that
> got a replacement only in jdk10 and so I cannot use it under jdk8 build.
>
> To deal with the last 10 warnings:
>

> * some of them are creating of arrays of collections. I think we

> should replace the arrays with collections to remove the warnings.

> * There are few warnings around the SVGUtils.java lists and maps. It

> was not trivial to add the generic types to those collections
> because they are used differently up and down the chain of calls.
>
> On some places I had to generify the collection with Object class. I
> did not find a better way, and tried to put a todo around those places
> for future improvements.
>
> It would be nice if you could go throw the changes and review them,
> thanks.
>
>

> --
> You received this message because you are subscribed to the Google
> Groups "jDip Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jdip-develope...@googlegroups.com

> <mailto:jdip-develope...@googlegroups.com>.

> To post to this group, send email to jdip-de...@googlegroups.com
> <mailto:jdip-de...@googlegroups.com>.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/jdip-developers/576e274c-660b-4ae9-9661-d599bec22ca2%40googlegroups.com
> <https://groups.google.com/d/msgid/jdip-developers/576e274c-660b-4ae9-9661-d599bec22ca2%40googlegroups.com?utm_medium=email&utm_source=footer>.

[Jiri Peinlich]

I have created a new branch (more-adventurous-inspection-fixes) with some of the inspections warning from my IDE automatically fixed, I created a commit for each set of inspection fixes separately for it to be easier to review and possibly object.

Jiri

[Kevin Lawrence]

Hi,

I'm following along with interest as I recently started on a web diplomacy client as an excuse  to learn React. I'm currently using Godip (writtten in Go) as an adjudicator but I'd rather use a judge that I could contribute to and have fond memories of using jDip back in the day. 

When the time comes to start work on the adjudicator, I'd love to lend a hand with coding or testing or whatever you need. I'm especially interested in building a standalone adjudicator that I can deploy as a REST server to resolve orders from either an active game or a sandbox (much like jDip does). I'd deploy this as an open API that anyone building a diplomacy client could use.

I look forward to jDip being restored to its former glory and hope I am able to contribute at some point. 

Keep up the great work!

Kevin

[Uwe Plonus]

Hi Kevin,

currently we are working on making jDip fir for Java 8 and later.

After that we will fix the open bugs and then we will see. My vision would be to separate the modules in jDip and then we have the possibility to add an interface for online games also.

But it is still a way to go.

Uwe