On most up-to-date way to add Maven Wrapper, help wanted (wrt core#732)

[Tatu Saloranta]

Ok, so we have a potentially useful contribution from Andrey, here:

https://github.com/FasterXML/jackson-core/pull/732

but what I have been hoping to clarify is whether this would be along
the lines of "best practices" for adding Maven wrapper. Since most
examples show Takari plug-in (once I have found searching), I would
want to see references to improvements, and I am hoping others more
familiar with Maven, CI/CD could chime in.

So specifically I am just looking for supporting evidence before
merging changes in.
I hope to keep the build system up-to-date, and I understand there is
plenty of inertia in usage (people keep on using things they've read
about even if there are new and improved ways).

Any suggestions, comments?

-+ Tatu +-

[Jochen Schalanda]

Hi,

the Takari Maven Wrapper plugin has been donated to the Apache Maven project and is being developed under the Maven umbrella now as an official plugin.

From that perspective it makes sense to eventually use the "new" and still maintained version (the Takari Maven Wrapper is unmaintained now).

This being said, it doesn't provide any immediate advantages to upgrade right now. No critical bugs were fixed, no additional functionality is provided.

My 2 cents: Since Andrey already invested the effort to provide a PR for this, there's no loss in merging it.

FWIW, we're using the Takari Maven Wrapper in all Dropwizard projects.

Best regards,
Jochen

> --
> You received this message because you are subscribed to the Google Groups "jackson-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jackson-dev...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jackson-dev/CAL4a10inHAoUH7Oxacq5CPaS-coqLDju0ybaB75BnSZ0PkbVTw%40mail.gmail.com.

[Tatu Saloranta]

On Tue, Dec 28, 2021 at 3:40 AM Jochen Schalanda <joc...@schalanda.name> wrote:

Hi,

the Takari Maven Wrapper plugin has been donated to the Apache Maven project and is being developed under the Maven umbrella now as an official plugin.

From that perspective it makes sense to eventually use the "new" and still maintained version (the Takari Maven Wrapper is unmaintained now).

This being said, it doesn't provide any immediate advantages to upgrade right now. No critical bugs were fixed, no additional functionality is provided.

My 2 cents: Since Andrey already invested the effort to provide a PR for this, there's no loss in merging it.

Otherwise I would agree except for the Big Question for me: how do we REPEAT this process for other repos?

With (outdated?) Takari, we'll follow a recipe to do the update. In this case there's a set of (possibly) unrelated changes

-- presumably improvements, to be sure -- and we'.... copy-paste? (or in theory cherry-pick).

So my problem is not the change at all, but that of applying changes in a repeatable/maintainable manner.

There are about 2 dozen Jackson repos that should ideally be upgraded as well.

So I would really want to have a Maven plugin based way of adding/updating Maven Wrapper set up, that's all :)

-+ Tatu +-

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jackson-dev/27A3859A-49F0-4913-ACA5-83267EAD1ABD%40schalanda.name.

[Tatu Saloranta]

On Tue, Dec 28, 2021 at 10:09 AM Tatu Saloranta <tsalo...@gmail.com> wrote:

On Tue, Dec 28, 2021 at 3:40 AM Jochen Schalanda <joc...@schalanda.name> wrote:

Hi,

the Takari Maven Wrapper plugin has been donated to the Apache Maven project and is being developed under the Maven umbrella now as an official plugin.

From that perspective it makes sense to eventually use the "new" and still maintained version (the Takari Maven Wrapper is unmaintained now).

This being said, it doesn't provide any immediate advantages to upgrade right now. No critical bugs were fixed, no additional functionality is provided.

My 2 cents: Since Andrey already invested the effort to provide a PR for this, there's no loss in merging it.

Otherwise I would agree except for the Big Question for me: how do we REPEAT this process for other repos?

With (outdated?) Takari, we'll follow a recipe to do the update. In this case there's a set of (possibly) unrelated changes

-- presumably improvements, to be sure -- and we'.... copy-paste? (or in theory cherry-pick).

So my problem is not the change at all, but that of applying changes in a repeatable/maintainable manner.

There are about 2 dozen Jackson repos that should ideally be upgraded as well.

So I would really want to have a Maven plugin based way of adding/updating Maven Wrapper set up, that's all :)

-+ Tatu +-

For what it is worth, this ended up being trivial to reproduce with the new plug-in,

so PR was merged successfully.