[PATCH] kas: correct TTY services variable for target-bootstrapper

22 views
Skip to first unread message

Badrikesh Prusty

unread,
Dec 13, 2025, 9:07:21 AM (4 days ago) Dec 13
to isar-...@googlegroups.com, Badrikesh Prusty
Replace incorrect INSTALLER_TTY_SERVICES with
TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
for the target bootstrapper.
Fix isar-installer not launching on the user-configured TTY from the
kas menu system.

Signed-off-by: Badrikesh Prusty <badrikes...@siemens.com>
---
kas/installer/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kas/installer/Kconfig b/kas/installer/Kconfig
index ccac6471..5e733f9e 100644
--- a/kas/installer/Kconfig
+++ b/kas/installer/Kconfig
@@ -92,7 +92,7 @@ config KAS_INCLUDE_INSTALLER_ADD_DEVICE_INFO_COLLECTOR
default "kas/installer/add-device-info-collector.yaml"
depends on INSTALLER_ADD_DEVICE_INFO_COLLECTOR

-config INSTALLER_TTY_SERVICES
+config TARGET_BOOTSTRAPPER_TTY_SERVICES
string "TTY Service to use"
default "getty@tty1 serial-getty@ttyS0" if !INSTALL_UNATTENDED
default "serial-getty@ttyS0" if INSTALL_UNATTENDED
--
2.47.3

MOESSBAUER, Felix

unread,
Dec 15, 2025, 2:23:29 AM (3 days ago) Dec 15
to Prusty, Badrikesh, isar-...@googlegroups.com, Heinisch, Alexander
On Sat, 2025-12-13 at 09:06 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Replace incorrect INSTALLER_TTY_SERVICES with
> TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
> for the target bootstrapper.
> Fix isar-installer not launching on the user-configured TTY from the
> kas menu system.

Hi,

please add a fixes tag and include the original patch author (+CC
Alexander) in the review process.

Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in
unattended mode.")

Felix

>
> Signed-off-by: Badrikesh Prusty <badrikes...@siemens.com>
> ---
> kas/installer/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kas/installer/Kconfig b/kas/installer/Kconfig
> index ccac6471..5e733f9e 100644
> --- a/kas/installer/Kconfig
> +++ b/kas/installer/Kconfig
> @@ -92,7 +92,7 @@ config KAS_INCLUDE_INSTALLER_ADD_DEVICE_INFO_COLLECTOR
> default "kas/installer/add-device-info-collector.yaml"
> depends on INSTALLER_ADD_DEVICE_INFO_COLLECTOR
>
> -config INSTALLER_TTY_SERVICES
> +config TARGET_BOOTSTRAPPER_TTY_SERVICES
> string "TTY Service to use"
> default "getty@tty1 serial-getty@ttyS0" if !INSTALL_UNATTENDED
> default "serial-getty@ttyS0" if INSTALL_UNATTENDED
> --
> 2.47.3
>
> --
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251213140654.1142110-1-badrikesh.prusty%40siemens.com.

--
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

Badrikesh Prusty

unread,
Dec 15, 2025, 4:03:46 AM (3 days ago) Dec 15
to isar-...@googlegroups.com, felix.mo...@siemens.com, alexander...@siemens.com, Badrikesh Prusty
Replace incorrect INSTALLER_TTY_SERVICES with
TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
for the target bootstrapper.
Fix isar-installer not launching on the user-configured TTY from the
kas menu system.

Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in unattended mode.")

Heinisch, Alexander

unread,
Dec 15, 2025, 5:28:18 AM (2 days ago) Dec 15
to Prusty, Badrikesh, isar-...@googlegroups.com, MOESSBAUER, Felix
On Mon, 2025-12-15 at 07:23 +0000, Moessbauer, Felix (FT RPD CED OES-
DE) wrote:
> On Sat, 2025-12-13 at 09:06 -0500, 'Badrikesh Prusty' via isar-users
> wrote:
> > Replace incorrect INSTALLER_TTY_SERVICES with
> > TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY
> > services
> > for the target bootstrapper.
> > Fix isar-installer not launching on the user-configured TTY from
> > the
> > kas menu system.

Good catch!
Seems I renamed last minute and failed to rename all assignments.

>
> Hi,
>
> please add a fixes tag and include the original patch author (+CC
> Alexander) in the review process.
>
> Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in
> unattended mode.")
>
Second that!
Alexander Heinisch
Siemens AG
http://www.siemens.com/

Anton Mikanovich

unread,
Dec 15, 2025, 7:18:08 AM (2 days ago) Dec 15
to Badrikesh Prusty, isar-...@googlegroups.com, felix.mo...@siemens.com, alexander...@siemens.com
15/12/2025 11:03, 'Badrikesh Prusty' via isar-users wrote:
> Replace incorrect INSTALLER_TTY_SERVICES with
> TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
> for the target bootstrapper.
> Fix isar-installer not launching on the user-configured TTY from the
> kas menu system.
>
> Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in unattended mode.")
> Signed-off-by: Badrikesh Prusty <badrikes...@siemens.com>
>
Hello Badrikesh,

Thanks for adding 'Fixes' tag in v2, because it really helps to
prioritize incoming patches.

Anton Mikanovich

unread,
Dec 16, 2025, 9:31:29 AM (yesterday) Dec 16
to isar-...@googlegroups.com
15/12/2025 11:03, 'Badrikesh Prusty' via isar-users wrote:
> Replace incorrect INSTALLER_TTY_SERVICES with
> TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
> for the target bootstrapper.
> Fix isar-installer not launching on the user-configured TTY from the
> kas menu system.
>
> Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in unattended mode.")
> Signed-off-by: Badrikesh Prusty <badrikes...@siemens.com>
Applied to next, thanks.
Reply all
Reply to author
Forward
0 new messages