Process for submitting code for a scan feature

99 views
Skip to first unread message

David Annett

unread,
Jun 11, 2016, 5:54:36 AM6/11/16
to Gqrx SDR
Hi, first an apology if this is a duplicate post.  This is my first time posting on Google Groups and from where I am sitting it appears Google Groups ate my first attempt.

I have been experimenting with Gqrx and a BladeRF by adding a scan feature.  It basically changes the demod frequency to the strongest or newest signal in the current chunk of spectrum being captured.  It does not change the hardware frequency.  It also learns and ignores blockers such as beacons, and the like, that would interfere with the strongest mode.  The nice thing about this scan operation is, unlike a conventional radio scanning, there is no perceivable delay so you don't miss the start of transmissions.

The bulk of the code has been added to the MainWindow::iqFftTimeout routine in the loop where it "Normalize, calculate power and shift the FFT".  I have added a mode drop down box to the receiver options but I still need to add an options dialogue to replace some hard coded parameters.  I normally do embedded C code, some someone should probably check the coding style is inline with the rest of the project.

If there is any interest in this code what would be the next step?

Robin Gape

unread,
Jun 13, 2016, 5:07:56 PM6/13/16
to gq...@googlegroups.com
David,

my recollection from earlier emails is that Alex operates the usual GitHub protocol, that is to say the author of changes, who wishes those changes to be taken in to the master branch, issues a pull request. The basic procedure is explained here, which assumes that everything has been processed according to a git workflow:
https://help.github.com/articles/using-pull-requests/

If you are simply at the looking for testers stage, then you could announce alpha or beta testing, though few users currently compile their own code since the project repositories for Ubuntu were established.

HTH,

Robin, G8DQX
--
You received this message because you are subscribed to the Google Groups "Gqrx SDR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gqrx+uns...@googlegroups.com.
To post to this group, send email to gq...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/gqrx/7adbba33-b29a-40e2-a088-396e541ae2ab%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Alexandru Csete

unread,
Jun 15, 2016, 3:32:48 PM6/15/16
to gq...@googlegroups.com
Hi David,

Thanks for your interest in gqrx and sorry for the late reply.

Unfortunately, I don't have time to work on gqrx at the moment and
that includes doing proper review of patches adding new functionality.
So my best recommendation for now is to put the code somewhere where
others can find and test it.

The natural way to do this would be to fork gqrx on github and adding
your changes to your fork. Others will then be able to see your fork
on the "Network" page on github. But you are also welcome to open an
issue on github describing and linking to your copy with the changes.

Alex

David Annett

unread,
Jun 17, 2016, 4:57:40 AM6/17/16
to gq...@googlegroups.com
Hi Alex,
I will do a fork and put my current version there as it is quite
handy already. Once i have finished the current feature set I will post
a message here. After that if at some future date you have time to
check it I will generate a pull request for you.

Cheers
David

On 16/06/16 07:32, Alexandru Csete wrote:
> Hi David,
>
> Thanks for your interest in gqrx and sorry for the late reply.
>
> Unfortunately, I don't have time to work on gqrx at the moment and
> that includes doing proper review of patches adding new functionality.
> So my best recommendation for now is to put the code somewhere where
> others can find and test it.
>
> The natural way to do this would be to fork gqrx on github and adding
> your changes to your fork. Others will then be able to see your fork
> on the "Network" page on github. But you are also welcome to open an
> issue on github describing and linking to your copy with the changes.
>
> Alex
>
>
Thread trimmed below here
> On Sat, Jun 11, 2016 at 11:54 AM, David Annett <da...@annett.co.nz> wrote:
>> I have been experimenting with Gqrx and a BladeRF by adding a scan feature.
>> It basically changes the demod frequency to the strongest or newest signal
>> in the current chunk of spectrum being captured.


--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Reply all
Reply to author
Forward
0 new messages