gsp1101 support & general maintenance questions

[gws]

Hi all,

I got tired of not being able to control my GSP1101 from a PC (I have access to a Windows VM, but it's less than ideal in a studio environment). So, over the last two days I added support for most of the functionality in the GSP1101. I'm not yet done, but I'm at the point where I need to figure out where to draw the line on my time investment.

1) Does anyone want to help me test my changes? The changes can be grouped into GSP1101-specific changes and non-specific changes.

2) Is this project still maintained? I was happy to see a lonely bug fix commit this past June, but not much other activity since 2016 - and I'm not sure what other forks exist of it or patches may be sitting around collecting dust. I don't even know how much usage the project actually sees anymore as most of the supported devices are pretty old.

I've also fixed some bugs. Of course, I'm really tempted to make additional changes (like breaking up the files a bit more to make it easier to work on, or touching the GUI in ways that I don't necessarily want to regression test), but if anyone else is working on the code, I'd want to coordinate or rethink how much I touch.

cheers,

Greg

[Tomasz Moń]

On Sun, Sep 6, 2020 at 8:40 AM gws <gee.dou...@gmail.com> wrote:
> I got tired of not being able to control my GSP1101 from a PC (I have access to a Windows VM, but it's less than ideal in a studio environment). So, over the last two days I added support for most of the functionality in the GSP1101. I'm not yet done, but I'm at the point where I need to figure out where to draw the line on my time investment.
>
> 1) Does anyone want to help me test my changes? The changes can be grouped into GSP1101-specific changes and non-specific changes.

I can check the non-GSP1101-specific changes.

> 2) Is this project still maintained? I was happy to see a lonely bug fix commit this past June, but not much other activity since 2016 - and I'm not sure what other forks exist of it or patches may be sitting around collecting dust. I don't even know how much usage the project actually sees anymore as most of the supported devices are pretty old.

I don't know about the usage either.

> I've also fixed some bugs. Of course, I'm really tempted to make additional changes (like breaking up the files a bit more to make it easier to work on, or touching the GUI in ways that I don't necessarily want to regression test), but if anyone else is working on the code, I'd want to coordinate or rethink how much I touch.

A nice to have change would be to replace all deprecated GTK+
functions with new counterparts. I don't think anyone else is working
on the code.

[Mauro Carvalho Chehab]

Em Sun, 6 Sep 2020 09:53:58 +0200
Tomasz Moń <des...@gmail.com> escreveu:

> On Sun, Sep 6, 2020 at 8:40 AM gws <gee.dou...@gmail.com> wrote:
> > I got tired of not being able to control my GSP1101 from a PC (I have access to a Windows VM, but it's less than ideal in a studio environment). So, over the last two days I added support for most of the functionality in the GSP1101. I'm not yet done, but I'm at the point where I need to figure out where to draw the line on my time investment.
> >
> > 1) Does anyone want to help me test my changes? The changes can be grouped into GSP1101-specific changes and non-specific changes.
>
> I can check the non-GSP1101-specific changes.

I can also help checking if this won't cause any regressions
on RP255. I don't have a GSP1101, though, so can't help
testing the changes specific to it.

> > 2) Is this project still maintained? I was happy to see a lonely bug fix commit this past June, but not much other activity since 2016 - and I'm not sure what other forks exist of it or patches may be sitting around collecting dust. I don't even know how much usage the project actually sees anymore as most of the supported devices are pretty old.
>
> I don't know about the usage either.

I'm still using it, with my RP255. I also keep maintaining the Fedora
package.

Btw, I have one patch over there fixing a compilation issue with
newer gcc:

https://src.fedoraproject.org/rpms/gdigi/c/a94f087be45762e011caffc2601c2be12faf5c49?branch=master

(not sure if I tried to merge this one back upstream)

> > I've also fixed some bugs. Of course, I'm really tempted to make additional changes (like breaking up the files a bit more to make it easier to work on, or touching the GUI in ways that I don't necessarily want to regression test), but if anyone else is working on the code, I'd want to coordinate or rethink how much I touch.
>
> A nice to have change would be to replace all deprecated GTK+
> functions with new counterparts. I don't think anyone else is working
> on the code.

I suspect that this won't be too hard. I did some Gtk+ deprecated
changes on some other projects.

Regards,
Mauro

[Greg]

Has the xml import/export previously been tested against X-Edit in this manner?

1) save preset from X-Edit (or download from the web, as I did) - 'input.xml'
2) import preset into gdigi
3) export preset from gdigi to xml - 'output.xml'
4) xmlsort -k ID -r Param input.xml > input.sorted; xmlsort -k ID -r
Param output.xml > output.sorted
5) diff input.sorted output.sorted

This leads me to a followup question: are the <Name> and <Text> fields
important to X-Edit, or are they just there for convenience?

Using a GSP1101 xml preset that someone else on the internet created
and following the above steps resulted in a number of fields changing.
I'm not sure how critical it is that these <Name> and <Text> fields
match (for all I know, it could just be Position:ID:Value that is used
by X-Edit), but I figured my goal was to output xml that would match
the input file exactly. If they *do* matter and *do* differ between
versions of X-Edit/product, then I would have to create a separate set
of XML labels for the GSP1101 - that would be good to know!

eg,
- {EQ_BASS, EQ_A_POSITION, "EQ A Bass", &values_eq_db,},
- {EQ_MID, EQ_A_POSITION, "EQ A Mid", &values_eq_db,},
- {EQ_TREB, EQ_A_POSITION, "EQ A Treb", &values_eq_db,},
+ {EQ_BASS, EQ_A_POSITION, "EQ Low Level", &values_eq_db,},
+ {EQ_MID, EQ_A_POSITION, "EQ Mid Level", &values_eq_db,},
+ {EQ_TREB, EQ_A_POSITION, "EQ High Level", &values_eq_db,},

For those curious, I seem to be able to read/write import/export all
of the GSP1101 C63 preset registers (full functionality, minus access
to the global registers not in xml). I'm now tracking down the last
weird little issues, like an XML Text value disagreeing with the
hardware when they share the same Value (presumed X-Edit bug). I'm
pretty pleased with the progress in one week. :D

currently (without cleanup/refactoring, just fixes and GSP1101):
effects.c | 1333
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
effects.h | 3 +-
gdigi.c | 157 +++++++---
gdigi.h | 170 ++++++++++-
gui.c | 143 ++++++---
gui.h | 3 +-
preset.c | 2 +
preset_xml.c | 21 +-
8 files changed, 1578 insertions(+), 254 deletions(-)

cheers,
Greg

> --
> You received this message because you are subscribed to the Google Groups "gdigi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to gdigi+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/gdigi/20200907103557.2d8f748c%40coco.lan.