fix remove! and insert! usage

11 views
Skip to first unread message

Ralf Hemmecke

unread,
Jan 18, 2019, 5:22:25 PM1/18/19
to fricas-devel

Waldek Hebisch

unread,
Jan 20, 2019, 8:56:11 AM1/20/19
to fricas...@googlegroups.com
Yes, please commit.

--
Waldek Hebisch

oldk1331

unread,
Jan 24, 2019, 7:43:14 AM1/24/19
to fricas...@googlegroups.com
There is an error in:

intersect(s, t) ==
i := set()
- for x in parts s | member?(x, t) repeat insert!(x, i)
+ for x in parts s | member?(x, t) repeat t := insert!(x, i)
i

It should be "i := insert!(x, i)".
> --
> You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to fricas-devel...@googlegroups.com.
> To post to this group, send email to fricas...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/fricas-devel/cc15d9f3-2219-c977-ba36-a2a14682ecb0%40hemmecke.org.
> For more options, visit https://groups.google.com/d/optout.

Ralf Hemmecke

unread,
Jan 24, 2019, 7:52:00 AM1/24/19
to fricas...@googlegroups.com
On 1/24/19 1:43 PM, oldk1331 wrote:
> There is an error in:
>
> intersect(s, t) ==
> i := set()
> - for x in parts s | member?(x, t) repeat insert!(x, i)
> + for x in parts s | member?(x, t) repeat t := insert!(x, i)
> i
>
> It should be "i := insert!(x, i)".

Yes, of course. Thank you for catching such a stupid mistake.

Ralf
Reply all
Reply to author
Forward
0 new messages