[PATCH] use name instead of abbreviation in ")set message time long"

6 views
Skip to first unread message

Qian Yun

unread,
Nov 4, 2023, 9:52:21 AM11/4/23
to fricas-devel
If we try to print time in long format, currently we use abbreviation
for different parts:

Time: 0.83(E) + 0.21(G) + 0.27(L) + 0.02(M) + 0.06(Q) + 0.01(K) +
0.01(O) = 1.43 sec

I think it's too difficult to understand. Since we are already
requesting "long" format, I think it is acceptable that the result
string is over 80 characters, such as:

Time: 0.04(coercion) + 0.91(evaluation) + 0.25(gc) + 0.06(instantiation)
+ 0.51(load) + 0.03(modemaps) + 0.08(querycoerce) + 0.02(diskread) +
0.01(O) = 1.92 sec

- Qian

diff --git a/src/interp/g-timer.boot b/src/interp/g-timer.boot
index 81e47586..3fc95b1d 100644
--- a/src/interp/g-timer.boot
+++ b/src/interp/g-timer.boot
@@ -52,7 +52,7 @@ makeLongStatStringByProperty _
else
timestr := '""
otherStatTotal := otherStatTotal + n
- str := makeStatString(str,timestr,ab,flag)
+ str := makeStatString(str,timestr,name,flag)
otherStatTotal := otherStatTotal
PUT('other, property, otherStatTotal)
if otherStatTotal > 0 then

Waldek Hebisch

unread,
Nov 4, 2023, 10:02:03 AM11/4/23
to fricas...@googlegroups.com
On Sat, Nov 04, 2023 at 09:52:16PM +0800, Qian Yun wrote:
> If we try to print time in long format, currently we use abbreviation
> for different parts:
>
> Time: 0.83(E) + 0.21(G) + 0.27(L) + 0.02(M) + 0.06(Q) + 0.01(K) + 0.01(O) =
> 1.43 sec
>
> I think it's too difficult to understand. Since we are already
> requesting "long" format, I think it is acceptable that the result
> string is over 80 characters, such as:
>
> Time: 0.04(coercion) + 0.91(evaluation) + 0.25(gc) + 0.06(instantiation) +
> 0.51(load) + 0.03(modemaps) + 0.08(querycoerce) + 0.02(diskread) + 0.01(O) =
> 1.92 sec

For consistency also 'O' should be 'other'. I think it should
be commited together with 'print' addition from the other mail.

>
> - Qian
>
> diff --git a/src/interp/g-timer.boot b/src/interp/g-timer.boot
> index 81e47586..3fc95b1d 100644
> --- a/src/interp/g-timer.boot
> +++ b/src/interp/g-timer.boot
> @@ -52,7 +52,7 @@ makeLongStatStringByProperty _
> else
> timestr := '""
> otherStatTotal := otherStatTotal + n
> - str := makeStatString(str,timestr,ab,flag)
> + str := makeStatString(str,timestr,name,flag)
> otherStatTotal := otherStatTotal
> PUT('other, property, otherStatTotal)
> if otherStatTotal > 0 then
>
> --
> You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to fricas-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/fricas-devel/a327adc2-6db8-4bfb-bb82-95238bb94708%40gmail.com.

--
Waldek Hebisch
Reply all
Reply to author
Forward
0 new messages