[Django] #17726: Admin's Recent Actions broken for multiple admin site instances with unique registered models

9 views
Skip to first unread message

Django

unread,
Feb 19, 2012, 1:52:51 PM2/19/12
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------+-------------------------------------------------
Reporter: | Owner: nobody
smacleod | Status: new
Type: | Version: 1.3
Uncategorized | Keywords: admin, multiple admin sites, recent
Component: | actions
contrib.admin | Has patch: 0
Severity: Normal | UI/UX: 0
Triage Stage: |
Unreviewed |
Easy pickings: 0 |
-------------------------+-------------------------------------------------
The Recent Actions list contains actions carried out from all admin site
instances a user has access to. This causes problems when there exists a
model which is not registered in all instances, and a User with access to
multiple instances. If an action is carried out on this model it will
appear in the recent list of all admin sites. If the model is not
registered to an instance, the link generated will be invalid.

Ex:
* AdminSite1 has model Model1 registered
* AdminSite2 does not have Model1 registered
* User has access to both admin sites
* User adds a Model1 in AdminSite1 (Action1)
* User visits AdminSite2, and clicks the Action1 link
* User is directed to an invalid URL (url for Model1 in AdminSite2)

--
Ticket URL: <https://code.djangoproject.com/ticket/17726>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 20, 2012, 5:07:48 PM2/20/12
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: smacleod | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage:
admin sites, recent actions | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by chipx86):

* cc: chipx86@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:1>

Django

unread,
Mar 4, 2012, 4:16:07 AM3/4/12
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: smacleod | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage:
admin sites, recent actions | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* type: Uncategorized => Bug


--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:2>

Django

unread,
Mar 4, 2012, 10:39:54 AM3/4/12
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: smacleod | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution: duplicate
Keywords: admin, multiple | Triage Stage:
admin sites, recent actions | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by julien):

* status: new => closed
* resolution: => duplicate


Comment:

Thanks for the report, however this is a duplicate of #9151, which was
wontfixed. If you disagree with this resolution, please take this question
to [http://groups.google.com/group/django-developers/topics django-
developers].

--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:3>

Django

unread,
Mar 4, 2012, 9:12:11 PM3/4/12
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: smacleod | Owner: nobody
Type: Bug | Status: reopened
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage: Accepted
admin sites, recent actions | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by carljm):

* status: closed => reopened
* resolution: duplicate =>
* stage: Unreviewed => Accepted


Comment:

I don't believe this is actually a duplicate of #9151, though it is
similar. #9151 is about `django.contrib.sites`; this ticket is about
creating multiple instances of `django.contrib.admin.Site`. Despite the
confusing naming, those are two completely separate things. And I don't
think the wontfix reasoning applied in #9151 applies here; while there may
be nothing about `django.contrib.sites.models.Site` that warrants special
treatment in the admin, I think it's reasonable to expect that the admin's
*own* multiple-admin-site feature won't break the admin's own recent-
actions feature.

Reopening.

--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:4>

Django

unread,
Nov 16, 2022, 7:26:02 AM11/16/22
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: Steven MacLeod | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage: Accepted
admin sites, recent actions |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

#34162 was a duplicate for resolving URLs for a custom admin site.

--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:6>

Django

unread,
Feb 1, 2023, 3:22:20 AM2/1/23
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: Steven MacLeod | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage: Accepted
admin sites, recent actions |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Al Mahdi):

Still not fixed in 4.1

https://github.com/django/django/blob/d3edac6c071c544c7d2208baf13d6d0fdc5e58fe/django/contrib/admin/models.py#L182

{{{LogEntry.get_admin_url}}} method reverse(s) entries with default
{{{admin:}}} prefix

--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:7>

Django

unread,
Feb 1, 2023, 3:25:08 AM2/1/23
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: Steven MacLeod | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage: Accepted
admin sites, recent actions |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Al Mahdi):

* cc: Al Mahdi (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:8>

Django

unread,
Feb 1, 2023, 6:51:03 AM2/1/23
to django-...@googlegroups.com
#17726: Admin's Recent Actions broken for multiple admin site instances with unique
registered models
-------------------------------------+-------------------------------------
Reporter: Steven MacLeod | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1

Severity: Normal | Resolution:
Keywords: admin, multiple | Triage Stage: Accepted
admin sites, recent actions |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Al Mahdi):

* version: 1.3 => 4.1


--
Ticket URL: <https://code.djangoproject.com/ticket/17726#comment:9>

Reply all
Reply to author
Forward
0 new messages