Re-open ticket 25192

123 views
Skip to first unread message

Shai Berger

unread,
Jan 28, 2017, 6:02:21 PM1/28/17
to django-d...@googlegroups.com
Hello,

Ticket #25192[1] is about a problem that only affects Python 2 users: If you
write a migration with a `RunPython` operation, and you use the documented
`RunPython.noop` as the reverse action (or forward action, but that is much
less likely...), then all looks well, until you try to squash that migration;
then, things blow up. Since master no longer supports Python 2, the ticket was
closed "wontfix" by core.

However, I think that if we can easily fix the problem in 1.11, then we should;
that version is still supporting Python 2 and will do so for several years.
1.11 is now feature frozen, but this is a bugfix, not a new feature; and the fix
is 6 lines[2] (in production code) that won't make you cringe too much.

I suggest that we re-open this ticket and solve it in the 1.11.x branch.

Thanks,
Shai.


[1] https://code.djangoproject.com/ticket/25192
[2] https://github.com/django/django/compare/stable/1.11.x...shaib:ticket_25192?expand=1

Florian Apolloner

unread,
Jan 29, 2017, 5:12:49 AM1/29/17
to Django developers (Contributions to Django itself)


On Sunday, January 29, 2017 at 12:02:21 AM UTC+1, Shai Berger wrote:
I suggest that we re-open this ticket and solve it in the 1.11.x branch.

Seems sensible, go ahead

Markus Holtermann

unread,
Jan 29, 2017, 11:06:50 AM1/29/17
to django-d...@googlegroups.com
Yeah, reopening and fixing in 1.11 sounds worth the effort. Thanks Shai!

/Markus
>--
>You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
>To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
>To post to this group, send email to django-d...@googlegroups.com.
>Visit this group at https://groups.google.com/group/django-developers.
>To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e984d61f-45bc-4620-a10f-91bf1113979c%40googlegroups.com.
>For more options, visit https://groups.google.com/d/optout.

signature.asc
Reply all
Reply to author
Forward
0 new messages