Quick question re typo-fixing etiquette

84 views
Skip to first unread message

James Turley

unread,
Jan 24, 2014, 7:17:53 AM1/24/14
to django-d...@googlegroups.com
Hi all,

I'm a relatively novice Pythonist, but a hardened and incorrigible spelling/grammar pedant, so I feel I could contribute in some small way by fixing language errors in the docs as required.

In the submitting patches guide, it says: "If you are fixing a really trivial issue, for example changing a word in the documentation, the preferred way to provide the patch is using GitHub pull requests without a Trac ticket. Trac tickets are still acceptable." That's fine. My question is: how 'trivial' should each pull request be? Should I make one for each file I go through, or one for every last stray apostrophe, or something else? I don't want to flood the committers with hundreds of meaningless typo fixes and grammar corrections, at least if that's not the done thing.

Thanks
James 

gilberto dos santos alves

unread,
Jan 24, 2014, 9:21:10 AM1/24/14
to django-d...@googlegroups.com


2014/1/24 James Turley <jamestu...@googlemail.com>

--
You received this message because you are subscribed to the Google Groups "Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/b394cfd0-09ff-4409-972f-a688171580ef%40googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



--
gilberto dos santos alves
+55.11.98646-5049
sao paulo - sp - brasil




Tim Graham

unread,
Jan 24, 2014, 10:35:14 AM1/24/14
to django-d...@googlegroups.com
Any logical grouping like "Fixed bad apostrophes" or "Fixed grammar errors in docs/index.txt" would be acceptable. We definitely don't want a PR for every individual correction as that'll just clutter the commit history. Thanks!

James Turley

unread,
Jan 24, 2014, 10:55:54 AM1/24/14
to django-d...@googlegroups.com
Great, thanks.
Reply all
Reply to author
Forward
0 new messages