Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Carlton Gibson]

Hi all.

https://code.djangoproject.com/ticket/31369

Proposes to deprecate NullBooleanField.

https://code.djangoproject.com/ticket/29227

Allowed BooleanField to be null=True.

Introduced in Django 2.1.

I'm inclined to Accept.

Wonder if folks consider it a little too fast?

(We could defer for 5.0.)

Kind Regards,

Carlton

[Aymeric Augustin]

Hello,

I'm inclined to Accept as well.

-- 

Aymeric.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com.

[Mariusz Felisiak]

Agreed, it's time to deprecate NullBooleanField.

Best,
Mariusz

[Adam Johnson]

+1 from me.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org.

--

Adam

[Shrawan Poudel]

+1 from me

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com.

[Carlton Gibson]

Ok, that’s pretty quick and conclusive, so let’s progress. Thanks all. 

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com.

[Markus Holtermann]

Makes sense. We'd have the deprecation shims around for a while anyway.

/Markus

> >>>> To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com <https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com?utm_medium=email&utm_source=footer>.

> >>>
>
> >>> --
> >>> You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
> >>> To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

> >>> To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org <https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org?utm_medium=email&utm_source=footer>.

> >>
> >>
> >> --
> >> Adam
>
> >> --
> >> You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

> >> To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com <https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> > --
> > You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

> > To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com <https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> --
> You received this message because you are subscribed to the Google
> Groups "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to django-develop...@googlegroups.com.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/django-developers/CAJwKpyRU95YkyRYbyZi388GB-wx9EMjGOMRQ6-3-exS1s46%3Dyg%40mail.gmail.com <https://groups.google.com/d/msgid/django-developers/CAJwKpyRU95YkyRYbyZi388GB-wx9EMjGOMRQ6-3-exS1s46%3Dyg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[Mariusz Felisiak]

`models.NullBooleanField` is now deprecated [1].

I would like to ask again about opinions on deprecating `forms.NullBooleanField` because I'm not convinced that it's necessary and expected. `forms.NullBooleanField` and `forms.BooleanField` use different widgets and their behavior is slightly different. Personally, I agree with Tim [2] that removing `forms.NullBooleanField` will needlessly increase complexity.

Best,
Mariusz

[1] https://github.com/django/django/commit/a92cc84b4a206d18a5f1a0eaa47f19add40ff99b

[2] https://github.com/django/django/pull/12636#pullrequestreview-383329786

[Adam Johnson]

I'm -1 on deprecating the form field. The different widgets make sense. Forms are decoupled from models for reasons like this.

--

You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/9a3fba1b-79e0-4ff1-8105-6ad5dd9e5458%40googlegroups.com.

--

Adam

[charettes]

I'm also -1 on removing the form field for the same reasons as Adam.