Thomas Hellström (VMware)
unread,Oct 18, 2019, 9:41:09 AM10/18/19Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to linux-...@vger.kernel.org, Thomas Hellstrom, Sami Tolvanen, clang-bu...@googlegroups.com, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, x86-ml, Borislav Petkov
From: Thomas Hellstrom <
thell...@vmware.com>
LLVM's assembler doesn't accept the short form INL instruction:
inl (%%dx)
but instead insists on the output register to be explicitly specified.
This was previously fixed for the VMWARE_PORT macro. Fix it also for
the VMWARE_HYPERCALL macro.
Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")
Suggested-by: Sami Tolvanen <
samito...@google.com>
Signed-off-by: Thomas Hellstrom <
thell...@vmware.com>
Cc:
clang-bu...@googlegroups.com
Cc: "H. Peter Anvin" <
h...@zytor.com>
Cc: Ingo Molnar <
mi...@redhat.com>
Cc: Thomas Gleixner <
tg...@linutronix.de>
Cc: x86-ml <
x...@kernel.org>
Cc: Borislav Petkov <
b...@suse.de>
---
arch/x86/include/asm/vmware.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h
index e00c9e875933..f5fbe3778aef 100644
--- a/arch/x86/include/asm/vmware.h
+++ b/arch/x86/include/asm/vmware.h
@@ -29,7 +29,8 @@
/* The low bandwidth call. The low word of edx is presumed clear. */
#define VMWARE_HYPERCALL \
- ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT ", %%dx; inl (%%dx)", \
+ ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT \
+ ", %%dx; inl (%%dx), %%eax", \
"vmcall", X86_FEATURE_VMCALL, \
"vmmcall", X86_FEATURE_VMW_VMMCALL)
--
2.21.0