[PATCH] hexagon: work around compiler crash

3 views
Skip to first unread message

Nick Desaulniers

unread,
Oct 28, 2019, 11:57:31 AM10/28/19
to bc...@codeaurora.org, Nick Desaulniers, Sid Manning, Allison Randal, Greg Kroah-Hartman, Richard Fontana, Thomas Gleixner, linux-...@vger.kernel.org, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
Clang cannot translate the string "r30" into a valid register yet.

Link: https://github.com/ClangBuiltLinux/linux/issues/755
Suggested-by: Sid Manning <sid...@quicinc.com>
Signed-off-by: Nick Desaulniers <ndesau...@google.com>
---
arch/hexagon/kernel/stacktrace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/hexagon/kernel/stacktrace.c b/arch/hexagon/kernel/stacktrace.c
index 35f29423fda8..5ed02f699479 100644
--- a/arch/hexagon/kernel/stacktrace.c
+++ b/arch/hexagon/kernel/stacktrace.c
@@ -11,8 +11,6 @@
#include <linux/thread_info.h>
#include <linux/module.h>

-register unsigned long current_frame_pointer asm("r30");
-
struct stackframe {
unsigned long fp;
unsigned long rets;
@@ -30,7 +28,7 @@ void save_stack_trace(struct stack_trace *trace)

low = (unsigned long)task_stack_page(current);
high = low + THREAD_SIZE;
- fp = current_frame_pointer;
+ fp = (unsigned long)__builtin_frame_address(0);

while (fp >= low && fp <= (high - sizeof(*frame))) {
frame = (struct stackframe *)fp;
--
2.24.0.rc0.303.g954a862665-goog

Brian Cain

unread,
Oct 28, 2019, 4:09:56 PM10/28/19
to Nick Desaulniers, Sid Manning, Allison Randal, Greg Kroah-Hartman, Richard Fontana, Thomas Gleixner, linux-...@vger.kernel.org, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
> -----Original Message-----
> From: linux-hex...@vger.kernel.org <linux-hexagon-
> ow...@vger.kernel.org> On Behalf Of Nick Desaulniers
...
> Subject: [PATCH] hexagon: work around compiler crash
>
> Clang cannot translate the string "r30" into a valid register yet.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/755
> Suggested-by: Sid Manning <sid...@quicinc.com>
> Signed-off-by: Nick Desaulniers <ndesau...@google.com>

LGTM. Thanks, Nick.

Reviewed-by: Brian Cain <bc...@codeaurora.org>

Nick Desaulniers

unread,
Dec 9, 2019, 8:36:29 PM12/9/19
to Andrew Morton, Sid Manning, Allison Randal, Greg Kroah-Hartman, Richard Fontana, Thomas Gleixner, linux-...@vger.kernel.org, LKML, clang-built-linux, bc...@codeaurora.org
+ akpm, looks like you're picking up hexagon patches? Would you mind
please grabbing this one, too?
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-li...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/002301d58dcb%24a9ffaa80%24fdfeff80%24%40codeaurora.org.



--
Thanks,
~Nick Desaulniers
Reply all
Reply to author
Forward
0 new messages