[google/carfac] d6f6cb: Fixed IHC just half wave rectify bug in C++

[GitHub]

Branch: refs/heads/master
Home: https://github.com/google/carfac
Commit: d6f6cba199beccae42666436e871f7fa86f3cbd7
https://github.com/google/carfac/commit/d6f6cba199beccae42666436e871f7fa86f3cbd7
Author: Alex Brandmeyer <alex.br...@gmail.com>
Date: 2013-09-11 (Wed, 11 Sep 2013)

Changed paths:
M cpp/ear.cc
A test_data/ihc_just_hwr_test-cpp-nap1.txt
A test_data/ihc_just_hwr_test-cpp-nap2.txt

Log Message:
-----------
Fixed IHC just half wave rectify bug in C++

Swapped ordering of arguments to ArrayX::Constant and moved
initialization of ac_coupler variable outside conditional statement to
get just half wave rectify option to work in C++.

[Alex Brandmeyer]

Hi all,

I just wanted to point out that I've removed the 'binaural_sai_test' from the test list in the SConstruct file on my last commit, as I was getting a complaint about an undefined symbol related to the BinaualSAI::RunSegment method called in one of the tests. The rest of the tests run fine with it removed. I'm not sure if it's something in my build environment or a genuine bug.

Alex

> --
> You received this message because you are subscribed to the Google Groups "carfac-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to carfac-dev+...@googlegroups.com.
> Visit this group at http://groups.google.com/group/carfac-dev.
> To view this discussion on the web visit https://groups.google.com/d/msgid/carfac-dev/5230c22283f66_6200a93d5012764d%40hookshot-fe3-pe1-prd.aws.github.net.mail.
> For more options, visit https://groups.google.com/groups/opt_out.

[Kevin Wilson]

Hmmm.  I'll look into that.  binaural_sai_test worked for me locally, but maybe I failed to commit all of my changes.

-Kevin

To view this discussion on the web visit https://groups.google.com/d/msgid/carfac-dev/E0FE0268-7EE8-46F8-9EB2-4480148EF642%40gmail.com.

[Kevin Wilson]

Alex, can you give me more info (error message, especially)?  binaural_sai_test works for me.

How can you trigger the problem?  Just by adding 'binaural_sai_test' back to your latest commit?

-Kevin

[Alex Brandmeyer]

Here's the error message I get if I have 'binaural_sai_test' in the test list:

Undefined symbols for architecture x86_64:

  "BinauralSAI::RunSegment(std::vector<Eigen::Array<float, -1, -1, 0, -1, -1>, std::allocator<Eigen::Array<float, -1, -1, 0, -1, -1> > > const&, std::vector<Eigen::Array<float, -1, -1, 0, -1, -1>, std::allocator<Eigen::Array<float, -1, -1, 0, -1, -1> > >*)", referenced from:

      BinauralSAIPeriodicInputTest_MultiChannelPulseTrain_Test::TestBody()      in binaural_sai_test.o

      SAITestBase_DiesIfNotTwoEars_Test::TestBody()      in binaural_sai_test.o

ld: symbol(s) not found for architecture x86_64

collect2: error: ld returned 1 exit status

scons: *** [binaural_sai_test] Error 1

scons: building terminated because of errors.

carfac_test and sai_test both run with 'scons test' otherwise. I have some different flags set for my gcc version (4.7), so I don't know if that might have something to do with it. I've added it back to SConstruct now and will try to track it down on my system.

Alex

To view this discussion on the web visit https://groups.google.com/d/msgid/carfac-dev/CAE52wGjswEgB%2By75C4nDJsDa-ZkswHHq6pe3RCsBpdQo%2BVvZdg%40mail.gmail.com.