Problem with getDistanceBetweenAnyTwoNodes

23 views
Skip to first unread message

Mathieu Groussin

unread,
Aug 28, 2014, 3:50:53 PM8/28/14
to biopp-de...@googlegroups.com
Hi all,
there is a bug with the function getDistanceBetweenAnyTwoNodes...
When I compute the distance between two leaves that are sister-leaves
(they share the same father), the distance is 0, whatever the real
distance between them in the tree.
I know there used to be problems with the getDistanceBetweenAnyTwoNodes
and getPathBetweenAnyTwoNodes a while ago... is it related to this?

Thanks a lot,
Mathieu

Mathieu Groussin

unread,
Aug 28, 2014, 3:59:16 PM8/28/14
to biopp-de...@googlegroups.com
Hi again,
Actually, the problem is even worth... all pairwise distances between
leaves are wrong.

Mathieu

Julien Yann Dutheil

unread,
Aug 29, 2014, 2:51:32 AM8/29/14
to Bio++ Development Forum
Hi Matthieu,

Can you fill a report on the bug tracker?

I'll give it a look...

J.


--
You received this message because you are subscribed to the Google Groups "Bio++ Development Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to biopp-devel-forum+unsubscribe@googlegroups.com.
To post to this group, send email to biopp-devel-forum@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/biopp-devel-forum/53FF8A06.5050502%40gmail.com.

For more options, visit https://groups.google.com/d/optout.



--
Julien Y. Dutheil, Ph-D
0 (+49) 4522 763 298

§ Max Planck Institute for Evolutionary Biology
Department of Evolutionary Genetics
Molecular Evolution Group
Plön -- GERMANY

§ Intitute of Evolutionary Sciences - Montpellier
University of Montpellier 2 -- FRANCE

Mathieu Groussin

unread,
Aug 29, 2014, 2:50:30 PM8/29/14
to biopp-de...@googlegroups.com
Hi Julien,
yep, I've just done it!
Cheers,
Mathieu

On 8/29/14, 2:51 AM, Julien Yann Dutheil wrote:
Hi Matthieu,

Can you fill a report on the bug tracker?

I'll give it a look...

J.
On Thu, Aug 28, 2014 at 9:59 PM, Mathieu Groussin <mgro...@gmail.com> wrote:
Hi again,
Actually, the problem is even worth... all pairwise distances between leaves are wrong.

Mathieu


On 8/28/14, 3:50 PM, Mathieu Groussin wrote:
Hi all,
there is a bug with the function getDistanceBetweenAnyTwoNodes...
When I compute the distance between two leaves that are sister-leaves (they share the same father), the distance is 0, whatever the real distance between them in the tree.
I know there used to be problems with the getDistanceBetweenAnyTwoNodes and getPathBetweenAnyTwoNodes a while ago... is it related to this?

Thanks a lot,
Mathieu

--
You received this message because you are subscribed to the Google Groups "Bio++ Development Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to biopp-devel-fo...@googlegroups.com.
To post to this group, send email to biopp-de...@googlegroups.com.



--
Julien Y. Dutheil, Ph-D
0 (+49) 4522 763 298

§ Max Planck Institute for Evolutionary Biology
Department of Evolutionary Genetics
Molecular Evolution Group
Plön -- GERMANY

§ Intitute of Evolutionary Sciences - Montpellier
University of Montpellier 2 -- FRANCE
--
You received this message because you are subscribed to the Google Groups "Bio++ Development Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to biopp-devel-fo...@googlegroups.com.
To post to this group, send email to biopp-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/biopp-devel-forum/CAFr7pNWQWorxVh6s2N9_TKYLgdPbc4NYUbUb%2BKjh%3DofRqOuxiw%40mail.gmail.com.

Julien Yann Dutheil

unread,
Sep 17, 2014, 3:32:23 AM9/17/14
to Bio++ Development Forum
Hi there,

I have committed a fix to this issue. The bug was actually in getPathBetweenAnyTwoNodes (bug 55). Matthieu, can you check if that indeed solved the problem in your code?

J.


For more options, visit https://groups.google.com/d/optout.



--
Julien Y. Dutheil, Ph-D
0 (+49) 4522 763 298

§ Max Planck Institute for Evolutionary Biology
Molecular Systems Evolution
Department of Evolutionary Genetics
Reply all
Reply to author
Forward
0 new messages