Re: [PATCH] ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

172 views
Skip to first unread message

Nishanth Menon

unread,
Sep 1, 2016, 10:09:39 AM9/1/16
to Tomi Valkeinen, Tony Lindgren, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
> LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
> and the current .dts file has the old GPIO.
>
> Rev B1 is the earliest board supported, so we can just change the .dts.
>
> This fixes "omapdss error: HDMI I2C Master Error" which causes failure
> to read EDID from the monitor.
>
> Signed-off-by: Tomi Valkeinen <tomi.va...@ti.com>
> ---
> arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index c4d04c5293b9..07603d9e2da7 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -120,7 +120,7 @@
> pinctrl-0 = <&tpd12s015_pins>;
>
> gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>, /* gpio7_10, CT CP HPD */
> - <&gpio6 28 GPIO_ACTIVE_HIGH>, /* gpio6_28, LS OE */
> + <&gpio2 30 GPIO_ACTIVE_HIGH>, /* gpio2_30, LS OE */
> <&gpio7 12 GPIO_ACTIVE_HIGH>; /* gpio7_12/sp1_cs2, HPD */
>
> ports {
>

I believe we have A2s being shipped as well. we dont want to break A2s
either -> I propose we refactor the dts to introduce revb1 X15.

--
Regards,
Nishanth Menon

Robert Nelson

unread,
Sep 1, 2016, 10:12:58 AM9/1/16
to Nishanth Menon, Tomi Valkeinen, Tony Lindgren, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Regards,

--
Robert Nelson
https://rcn-ee.com/

Nishanth Menon

unread,
Sep 1, 2016, 10:14:44 AM9/1/16
to Robert Nelson, Tomi Valkeinen, Tony Lindgren, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
Thanks. Tomi: if you are ok - I already do have a refactoring code
from older kernel. I will rebase to latest and repost.

Tony: is there a branch youd' like me to base the changes on?


--
Regards,
Nishanth Menon

Tomi Valkeinen

unread,
Sep 1, 2016, 10:57:21 AM9/1/16
to Nishanth Menon, Robert Nelson, Tony Lindgren, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
On 01/09/16 17:14, Nishanth Menon wrote:

>>> I believe we have A2s being shipped as well. we dont want to break A2s
>>> either -> I propose we refactor the dts to introduce revb1 X15.
>>
>> There are at-least 200 A2's that have been shipped to end users.
>>
>> http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
>>
>
>
> Thanks. Tomi: if you are ok - I already do have a refactoring code from
> older kernel. I will rebase to latest and repost.

Sounds good to me.

Tomi

signature.asc

Tony Lindgren

unread,
Sep 1, 2016, 10:58:02 AM9/1/16
to Nishanth Menon, Robert Nelson, Tomi Valkeinen, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
* Nishanth Menon <n...@ti.com> [160901 07:15]:
> On 09/01/2016 09:12 AM, Robert Nelson wrote:
> > On Thu, Sep 1, 2016 at 9:09 AM, Nishanth Menon <n...@ti.com> wrote:
> > > On 09/01/2016 08:51 AM, Tomi Valkeinen wrote:
> > > >
> > > > LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board,
> > > > and the current .dts file has the old GPIO.
> > > >
> > > > Rev B1 is the earliest board supported, so we can just change the .dts.
> > > >
> > > > This fixes "omapdss error: HDMI I2C Master Error" which causes failure
> > > > to read EDID from the monitor.
...
> > > I believe we have A2s being shipped as well. we dont want to break A2s
> > > either -> I propose we refactor the dts to introduce revb1 X15.
> >
> > There are at-least 200 A2's that have been shipped to end users.
> >
> > http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/
>
>
> Thanks. Tomi: if you are ok - I already do have a refactoring code from
> older kernel. I will rebase to latest and repost.
>
> Tony: is there a branch youd' like me to base the changes on?

Probably best to do it against current omapf-for-v4.9/dt as it has all
the skeleton.dtsi removal now applied.

Regards,

Tony

Nishanth Menon

unread,
Sep 1, 2016, 11:00:33 AM9/1/16
to Tony Lindgren, Robert Nelson, Tomi Valkeinen, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
Ok will do, will try to post this later today or early tomorrow.


--
Regards,
Nishanth Menon

Bill Traynor

unread,
Nov 13, 2017, 7:27:47 PM11/13/17
to Nishanth Menon, Tony Lindgren, Robert Nelson, Tomi Valkeinen, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
I'm getting this error again with the latest X15 image on my A2
version board. I don't see this patch in the mainline kernel. Did it
never get applied?

Thanks
Bill

>
>
> --
> Regards,
> Nishanth Menon
>
> --
> You received this message because you are subscribed to the Google Groups
> "beagleboard-x15" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to beagleboard-x...@googlegroups.com.
> To post to this group, send email to beagleb...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/beagleboard-x15/de3bf6ab-a07a-b82d-1e45-5f96a6e1039e%40ti.com.
>
> For more options, visit https://groups.google.com/d/optout.

Tomi Valkeinen

unread,
Nov 14, 2017, 2:33:36 AM11/14/17
to Bill Traynor, Nishanth Menon, Tony Lindgren, Robert Nelson, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
On 14/11/17 02:27, Bill Traynor wrote:

> I'm getting this error again with the latest X15 image on my A2
> version board. I don't see this patch in the mainline kernel. Did it
> never get applied?

With am57xx-beagle-x15.dts? That seems be the A2 version.

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Bill Traynor

unread,
Nov 14, 2017, 9:15:19 AM11/14/17
to Tomi Valkeinen, Nishanth Menon, Tony Lindgren, Robert Nelson, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
On Tue, Nov 14, 2017 at 2:33 AM, Tomi Valkeinen <tomi.va...@ti.com> wrote:
> On 14/11/17 02:27, Bill Traynor wrote:
>
>> I'm getting this error again with the latest X15 image on my A2
>> version board. I don't see this patch in the mainline kernel. Did it
>> never get applied?
>
> With am57xx-beagle-x15.dts? That seems be the A2 version.

Yes.
I see the following in the boot message

loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...

I can get around this by inserting/uninserting an sdcard once the
kernel starts booting.

This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Thanks
Bill

Robert Nelson

unread,
Nov 14, 2017, 11:08:03 AM11/14/17
to Bill Traynor, Tomi Valkeinen, Nishanth Menon, Tony Lindgren, linux...@vger.kernel.org, linux-ar...@lists.infradead.org, beagleb...@googlegroups.com
On Tue, Nov 14, 2017 at 8:14 AM, Bill Traynor <btra...@gmail.com> wrote:
> On Tue, Nov 14, 2017 at 2:33 AM, Tomi Valkeinen <tomi.va...@ti.com> wrote:
>> On 14/11/17 02:27, Bill Traynor wrote:
>>
>>> I'm getting this error again with the latest X15 image on my A2
>>> version board. I don't see this patch in the mainline kernel. Did it
>>> never get applied?
>>
>> With am57xx-beagle-x15.dts? That seems be the A2 version.
>
> Yes.
> I see the following in the boot message
>
> loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...
>
> I can get around this by inserting/uninserting an sdcard once the
> kernel starts booting.
>
> This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Weird, ldo1 is set to always on:

https://github.com/RobertCNelson/linux-stable-rcn-ee/blob/4.9.35-ti-r44/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi#L276-L283

Something else is going on..
Reply all
Reply to author
Forward
0 new messages