Lack of response to pull requests

[Paul Sokolovsky]

Hello,

I have 2 pending pull requests:

https://github.com/ansible/ansible/pull/7105
submitted 1.5 months ago

https://github.com/ansible/ansible/pull/7369
submitted 3 weeks ago

One submitted 1.5 ago at least got initial comment (like it was
before), but otherwise, stuck in the queue for longer than it was
before.

And more recent one didn't even get comments, the only activity I see
is that labels were assigned.


I understand that volume of patches to the project is likely increased
as project grows, and it calls for some prioritization and thus delays.
But I hope there're some guidelines re: what assigned priorities mean,
and what turnaround times can be expected. I'd appreciate a reference.


Thanks,
Paul mailto:pmi...@gmail.com

[Matt Martz]

Do keep in mind that those pull requests are tagged as 'P3'.  Currently, due to the backlog of P1/P2 issues/pull requests, the Ansible team is currently focused on higher priority bugs and issues.

Once the P1/P2 queue has been tackled, you will likely see P3 issues being taken care of and so on.

In general just be patient, turn around time is based on priority, so I don't think it is necessarily a good idea to provide timeframes.

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/20140605181713.4e1a296d%40x34f.
For more options, visit https://groups.google.com/d/optout.

--
Matt Martz
ma...@sivel.net
http://sivel.net/

[Abhijit Menon-Sen]

At 2014-06-05 11:05:44 -0500, ma...@sivel.net wrote:
>
> Once the P1/P2 queue has been tackled, you will likely see P3 issues
> being taken care of and so on.

I also have a pending pull request, and so far I've been taking it for
granted that its being tagged meant that someone will come back to it
at some point, even if it takes a long time. But I confess to being a
bit concerned about it, so it's good to have confirmation. Thanks.

-- ams

[Adam Morris]

Given that there are 314 pull requests and 587 issues open you have to assume that there is a lot of work going on.  I do remember that my own PR for a minor change (adding AIX support to the cron module) took several months, and had to be rewritten due to changes between 1.4  when I first drew it up and 1.6 when it was included...   They will get to it.  You might want to make sure that you keep tracking devel so that it still applies cleanly or that you can provide a working alternative when it does happen.

I hope that this helps,

Adam

[Michael DeHaan]

Hi everyone,

Yes, we're busy!  

Ansible was one of the top projects last year for number of Open Source Contributors on GitHub - #5 behind such projects as Rails, Angular.js, and Homebrew.

There are a LOT of pull requests incoming.

We are going to prioritize based on fixing the bugs and issues that affect the most people first, and we do test every pull request.   Not that we don't trust all of you, but we don't :)

As such, there is an ordering and a queue, and it may take some times to get things in.

While I love Django, some work in Django space takes 5 years to get in, so don't be too perturbed about something taking a few months.

Also, I'd ask that everyone not ask about a particular PR, as well, while we are all unique special snowflakes, we're kind of following a "Spock from Star Trek 2" theme here.

i.e. "The Good of the Many Outweighs the Needs of the Few, or the One" -- which I probably horribly misquoted :)

FWIW, GitHub is somewhat lame and includes pull requests in the total issue count, so 2/3 of the issue count are pull requests :)

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/d9b9ac9a-6d48-4f11-b260-deab9895aeba%40googlegroups.com.