include_tasks vs include

[Ben Joyce]

Hi.  Has include_tasks been deprecated?  I have a playbook that used include_tasks fine up until recently.

ansible-playbook --version reports 2.7.0

Unfortunately I can't be sure of what the previous version was, if it was indeed different.

Either way, include_tasks no longer works for me.  I get this error:

ERROR! Invalid options for include_tasks: item

The error appears to have been in '/vagrant/workspace/pcf-automation-infrastructure/ansible/bosh/prep.yml': line 53, column 7, but may

be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - include_tasks: ../roles/common/tasks/download.yml item={{item}}

      ^ here

We could be wrong, but this one looks like it might be an issue with

missing quotes.  Always quote template expression brackets when they

start a value. For instance:

    with_items:

      - {{ foo }}

Should be written as:

    with_items:

      - "{{ foo }}"

If I use include instead it works.

Any ideas?

Cheers,

Ben

[Kai Stian Olstad]

On 17.10.2018 11:23, Ben Joyce wrote:
> Hi. Has include_tasks been deprecated? I have a playbook that used
> include_tasks fine up until recently.
>
> ansible-playbook --version reports 2.7.0
>
> Unfortunately I can't be sure of what the previous version was, if it
> was
> indeed different.
>
> Either way, include_tasks no longer works for me. I get this error:
>
> ERROR! Invalid options for include_tasks: item
>

<snip />

> Any ideas?

The documentation say that include_tasks is preview so it's subjected to
change
https://docs.ansible.com/ansible/2.7/modules/include_tasks_module.html#status


So when you upgrade you need to check the documentation again for those
module and read the porting guide.
https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html#include-tasks-import-tasks-inline-variables

--
Kai Stian Olstad

[Ben Joyce]

Thanks Kia.  Really appreciate your quick and detailed response.

Regards,

Ben

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/1f3088c53d2685545bb50a4cb1f46f14%40olstad.com.
For more options, visit https://groups.google.com/d/optout.

[Eugene Wong]

Hi Ben,

From the error message it could seem like double quotes are required:

item=“{{item}}”

Eugene

--

You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAGWQ2KCH4BzQzpUvcNE7E4qg06m4Hesfu1TD6eMAgisgqx-jHQ%40mail.gmail.com.

[Ben Joyce]

Hi Eugene.  I did try that suggestion but unfortunately it did not make any difference.

Regards,

Ben

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAHYqtxk1hsA4k8M9O_y3DPFDOVrObSE586DuURqSU0ytu0LCxg%40mail.gmail.com.

[Oriol Tauleria]

Hello Ben,

could you update the entire playbook?

The problem could be in the items list, have you tried to add quotes to each item?

El dv., 19 oct. 2018 11.43, Ben Joyce <ben....@gmail.com> va escriure:

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAGWQ2KDWejdvoBEV3b4Fbk7XPxnxLR_U46iGPv61Q%3D9w%3DwEzhQ%40mail.gmail.com.

[Brian Coca]

FYI item="{{item}}" is really a noop


--
----------
Brian Coca

[Ben Joyce]

Just googled "noop" - not quite sure what you mean, Brian... can you elaborate? :)

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CACVha7cQaMoVrvcGXb4Q%2BNVVviOgGvD_osMGKA5gvdZm-0XzGQ%40mail.gmail.com.

[Matt Martz]

noop == no-op == No Operation

You are setting a variable named `item` to the variable named `item`.  That is unnecessary, and does nothing for you.  Simply omitting `item={{item}}` will do the same thing.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAGWQ2KC6S3ZeJY%3De%2BUgPxkv_pWjiwpAf2yfTp4KZJnpyT%3DeoPg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Matt Martz
@sivel
sivel.net

[Ben Joyce]

Thanks Matt, appreciated.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAD8N0v8rnuQruhx__keW7EBm_2NkLktEQSU6Q8DGbqBFU6%2B%2B6Q%40mail.gmail.com.