Some freeform window patches for android-x86 pie-x86

[utzcoz]

Hi android-x86 community,

I have some freeform window patches for android-x86 pie-x86, and I have ported them to android-x86 pie-x86.

The modified frameworks/base github page is:

https://github.com/boringdroid/platform_frameworks_base/tree/boringdroid-x86-9.0.0

    
I also provide a manifest to download modified android-x86 pie-x86 with repo:
https://github.com/boringdroid/boringdroid#android-x86-porting

I have tested it with repo to download it. And also I have tested the building and running with vbox.

I only port some patches I think maybe useful for android-x86, and there are patch set list:

a. Fix drag-resizing jump of freeform.

This patch will fix freeform window jumps when resizing window.

b. Trigger resize when window from freeform to fullscreen .

This patch will fix black screen after clicking maximize button of freeform window to enter fullscreen mode.

c.Add back button for freeform window .

This patch add back button to the left position of freeform window titlebar(decor caption view). This button

will trigger Activity's onBack to simulate back button.

d.Support persist window bounds.

This patch will persist window bounds, so if we restart the freeform window after resizing, it will use the

resized bounds as launch bounds. There is a changing part maybe confused is to disable the launch
bounds from ActivityOptions. Taskbar will always set the launch bounds of ActivityOptions to the center

of screen, and it has the highest priority to assign the real launch bounds. So I just disable launch bounds

of ActivityOptions before Taskbar has a good solution to manage window bounds.

e. Reset pointer icon type after leaving resizing region.

This patch will fix pointer icon type keeps to double arrow after moving pointer from freeform resizing region

to outer region.

f. Ignore system ui visibility for decor caption view visibility

This patch will fix titlebar(decor caption view) of freeform window disappears when resizing some apps, such

as AOSP Clock.

All above patches can be found in https://github.com/boringdroid/platform_frameworks_base/tree/boringdroid-x86-9.0.0.

I don't know whether there are some of those patches can meet android-x86 need, so I send them to mail list

for community reviewing.

Thanks.

[Jon West]

I can give these a test in my Bliss builds. I will let you know how it all goes.

[Jon West]

The patches for your Android-x86 branch are what I cherry-picked into Bliss, and things all checkout so far. I appreciate how you commented you code to help explain things. Better than I do at least ;)
These are ready for Android-x86, but for Bliss we may need to change the back button drawable to follow accent-color for theming. Other than that, things look good!

Keep up the good work man!

[utzcoz]

Hi @Jon, thanks your help to test those patches.

Hi @Chih-Wei, is there any possibility to integrate those patches to android-x86 pie-x86 branch? Thanks.

--
You received this message because you are subscribed to the Google Groups "Android-x86" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-x86...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/android-x86/b7364069-8539-457a-be35-cf41c898775do%40googlegroups.com.

[Jon West]

If it's not done by the weekend, I will see what I can do to get your commits pushed through ;)

[Chih-Wei Huang]

utzcoz <utz...@gmail.com> 於 2020年6月24日 週三 下午10:18寫道：

>
> Hi @Jon, thanks your help to test those patches.
> Hi @Chih-Wei, is there any possibility to integrate those patches to android-x86 pie-x86 branch? Thanks.

Sorry for replying so late. I'm quite busy recently.

Anyway, it looks good to me!
I have just merged your branch.
Thank you for the contribution!


--
Chih-Wei
Android-x86 project
http://www.android-x86.org

[utzcoz]

Thanks. The next few days I will try to port patches about recents and split screen for reviewing.

--
You received this message because you are subscribed to the Google Groups "Android-x86" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-x86...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/android-x86/CAKc24n1aA0mgKAteq1kETUfR8D%3DwpeC5nv2ZPPQY-xXVhgfrAQ%40mail.gmail.com.

[Jon West]

Awesome work on those so far man. Looking forward to testing what else you have ;)

[utzcoz]

Hi @Jon West , @Chil-Wei Huang,

There are two new patches , one for recents, and one for split screen.

a. Use systemui recents as default pc recents

1. Enable grid layout of systemui recents.
2. Disable OverviewProxyService to use systemui recents, instead of
   recents that implements OverviewProxyService such as Launcher3.
3. Show freeform task in systemui recents.
4. Fix IndexOutArrayException of systemui recents grid layout when
   starting many freeform tasks.

The systemui grid layout recents is better suited for pc style os, than current Launcher3 implements

OverviewProxyService.

The following picture is the system ui grid layout:

b. Keep stack order when starting activity from recents

When starting activity from recents, the AMS will move home stack to
front and then move selected activity stack to front. So when we start
many freeform windows, the operation will move unselected freeform
windows to back. It's not good for usage. So this patch will remove the
logic to move home stack to front when starting activity from recents,
and move recents stack to background to dismiss the recents page.

For split screen secondary windowing, we keep the origin logic to move
home stack to front. If we find rigid problems when starting split
screen window or pip window, we should review this patch again to check
whether this patch causes the problem.

The following picture is the result after starting multi freeform tasks from systemui recents:

Those patches are stored in personal repository:

https://github.com/boringdroid/platform_frameworks_base/commits/boringdroid-x86-9.0.0

Hope your reply.

Thanks.

To view this discussion on the web visit https://groups.google.com/d/msgid/android-x86/c2dcbc23-811c-41a4-ba11-4d05dcea3958n%40googlegroups.com.

[utzcoz]

The second patch is for recents to keep stack order when starting normal task from recents, but it splits move home stack

to front logic form split screen logic, so I say it is about split screen. The following picture is the result after starting primary

split screen:

The following picture is the result that start recents after starting primary split screen and freeform task:

The following picture is the result after clicking the freeform window of above picture:

The second picture is weird, because of the z order.

[Chih-Wei Huang]

utzcoz <utz...@gmail.com> 於 2020年7月11日 週六 下午4:09寫道：

> Hi @Jon West , @Chil-Wei Huang,
> There are two new patches , one for recents, and one for split screen.

I've merged them.
Thanks a lot!


Best regards,

[utzcoz]

Hi jon, chih-wei,

There is a patch to implement basic round corner for freeform window:

https://github.com/boringdroid/platform_frameworks_base/commit/298304e0b42263e540bcf02951b24574843a3064

It uses added dimen resource to control the window round corner size, so device can use overlay resource to

change it based on device need.

I don't know whether android-x86 needs it, so I just send it to mail for review.

Thanks.

BR.

--
You received this message because you are subscribed to the Google Groups "Android-x86" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-x86...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/android-x86/CAKc24n16eFTppPE2X%3Dx_zundnVjVbg3zgku3ovR2qNCFMSDLFA%40mail.gmail.com.

[Chih-Wei Huang]

utzcoz <utz...@gmail.com> 於 2020年7月23日 週四 下午10:04寫道：

>
> Hi jon, chih-wei,
>
> There is a patch to implement basic round corner for freeform window:

Nice!
I've merged it. Thanks a lot!

Best regards,
Chih-Wei