Re: Fix Solaris build (issue5968004)

[erik....@gmail.com]

http://codereview.chromium.org/5968004/diff/5/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/5968004/diff/5/src/utils.h#newcode757
src/utils.h:757: inline Dest BitCast(Source*& source) {
Why is this needed?

http://codereview.chromium.org/5968004/

[coldre...@gmail.com]

http://codereview.chromium.org/5968004/diff/5/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/5968004/diff/5/src/utils.h#newcode757
src/utils.h:757: inline Dest BitCast(Source*& source) {

On 2011/01/05 12:23:13, Erik Corry wrote:
> Why is this needed?

I get many errors like this from GCC 3.4.3.

src/factory.h: In static member function `static
v8::internal::Handle<v8::internal::Map>
v8::internal::Factory::byte_array_map()':
src/factory.h:344: error: call of overloaded
`BitCast(v8::internal::Object**)' is ambiguous
src/utils.h:746: note: candidates are: Dest v8::internal::BitCast(const
Source&) [with Dest = v8::internal::Map**, Source =
v8::internal::Object**]
src/utils.h:757: note: Dest
v8::internal::BitCast(Source*) [with Dest = v8::internal::Map**, Source
= v8::internal::Object*]

There was a patch for this change before:
http://codereview.chromium.org/3130033/show

http://codereview.chromium.org/5968004/

[coldre...@gmail.com]

Eric, this could be merged without the BitCast change - it's not really
related
to Solaris but rather old GCC. I can try to get that in in a separate patch.

http://codereview.chromium.org/5968004/

[Vyacheslav Egorov]

I have a patch that presumably should fix BitCast compilation related
issues once and for all. I thought we've applied it long ago.

Can you try it Ryan?
--
Vyacheslav Egorov

> --
> v8-dev mailing list
> v8-...@googlegroups.com
> http://groups.google.com/group/v8-dev
>

[Ryan Dahl]

On Thu, Jan 6, 2011 at 11:26 AM, Vyacheslav Egorov <veg...@chromium.org> wrote:
> I have a patch that presumably should fix BitCast compilation related
> issues once and for all. I thought we've applied it long ago.
>
> Can you try it Ryan?

Yes, this fixes my problem.