my patch for issue 305

2 views
Skip to first unread message

ali.fatolahi

unread,
Jun 15, 2012, 12:01:45 PM6/15/12
to umpl...@googlegroups.com
please review the patch I created to resolve issue 305

thanks,

- Ali

Ali Fatolahi

unread,
Jun 15, 2012, 12:02:48 PM6/15/12
to umpl...@googlegroups.com
here's the link:
http://code.google.com/p/umple/issues/detail?id=305&can=1&sort=-id&colspec=ID%20Type%20Component%20Diffic%20Status%20Priority%20Owner%20Summary
> --
> You received this message because you are subscribed to the Google
> Groups "Umple-Dev" group.
> To view this discussion on the web, visit
> https://groups.google.com/d/msg/umple-dev/-/lRu9o_J-JIwJ.
> To post to this group, send an email to umpl...@googlegroups.com.
> To unsubscribe from this group, send email to
> umple-dev+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/umple-dev?hl=en-GB.

Timothy Lethbridge

unread,
Jun 15, 2012, 12:12:06 PM6/15/12
to umpl...@googlegroups.com
Looks good to me. I am not that much of an SQL expert so I am only
evaluating it from the Umple perspective.

Feel free to commit.

- TIm
Timothy C. Lethbridge, PhD, P.Eng., I.S.P., CSDP
Professor of Software Engineering and Computer Science
/ Professeur Titulaire de g�nie logiciel et d'informatique
Facult� de genie / Faculty of Engineering
University of Ottawa / Universit� d'Ottawa
Tel: 613-562-5800x6685 Fax: 613-562-5664 Mobile: 613-252-1850
http://www.eecs.uottawa.ca/~tcl

Ali Fatolahi

unread,
Jun 15, 2012, 12:17:33 PM6/15/12
to umpl...@googlegroups.com
Just before I do so ... I commit the complete build - including all
generated files?

- Ali

Timothy Lethbridge

unread,
Jun 15, 2012, 1:19:32 PM6/15/12
to umpl...@googlegroups.com
Yes,

All generated files that are generated from this (if there are new ones,
do svn add first). There should not be too many files generated for this
change I would have thought.

Don't submit files you have changed/generated for other things you are
working on.

- Tim

Ali Fatolahi

unread,
Jun 15, 2012, 1:21:38 PM6/15/12
to umpl...@googlegroups.com
I just committed changes. hopefully I've done it right ...

- Ali
Reply all
Reply to author
Forward
0 new messages