Removing tg.decorators.postpone_commits

12 views
Skip to first unread message

Alessandro Molina

unread,
Nov 19, 2012, 4:32:46 PM11/19/12
to tg-trunk
I would like to remove the postpone_commits decorator in the upcoming major release, so I'm writing here to get any feedback :D

The main reason is that it's not documented and it's the only decorator left depending on the decorators package.
I suppose not many people are using it, and people who are, probably understand what's happening and should be able to reimplement it by themselves in a bunch of lines of code.

I'm working at achieving 100% code coverage, so I'm checking all the modules for what might look like unused code, and postpone_commits seems a good candidate for removal.



percious

unread,
Nov 26, 2012, 3:57:22 PM11/26/12
to turbogea...@googlegroups.com
+1 from me.

cheers.
-chris

Carlos Daniel Ruvalcaba Valenzuela

unread,
Nov 26, 2012, 4:03:34 PM11/26/12
to turbogea...@googlegroups.com
Seems fair, it's a piece of code which is not documented, with little
or no use (users), stuff like this can become cruft later.

+1 I'm all for it too.

Carlos Daniel Ruvalcaba Valenzuela
> --
> You received this message because you are subscribed to the Google Groups
> "TurboGears Trunk" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/turbogears-trunk/-/80jBTbfB2jUJ.
>
> To post to this group, send email to turbogea...@googlegroups.com.
> To unsubscribe from this group, send email to
> turbogears-tru...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/turbogears-trunk?hl=en.

Michael Pedersen

unread,
Jan 2, 2013, 1:21:17 AM1/2/13
to tg-trunk
I say to pull it. If need be, we can add it back, and people can always get the code from our history, too. That's what version control is for, right?
--
Michael J. Pedersen
My Online Resume: http://www.icelus.org/ -- Google+ http://plus.ly/pedersen
Google Talk: m.ped...@icelus.org -- Twitter: pedersentg
Reply all
Reply to author
Forward
0 new messages