Questions regarding workflow of multiple pull requests

8 views
Skip to first unread message

Guru Devanla

unread,
May 31, 2012, 7:07:42 PM5/31/12
to sy...@googlegroups.com, elli...@gmail.com, Sean Vig, Ondřej Čertík
Hello All,

I have a general question regarding workflow of pull requests. Say,  I have pull request PR_1 under review.  I went ahead and created a local branch off PR_1 and continued working on next set of features. Let me call this branch PR1_1.

Now I want to submit PR1_1  for  design review and not to actually merge. How should I go about doing this?  Should I tag these pull requests as needing 'reviews' and not ready for any serious merge? 

Thanks
Guru

PS: For those who still may not be aware, I am a GSOC 2012 student  working on the quantum module. I just thought this question could be relevant to other students as well.

Aaron Meurer

unread,
May 31, 2012, 7:19:21 PM5/31/12
to sy...@googlegroups.com, elli...@gmail.com, Sean Vig, Ondřej Čertík
Yes, it's fine to just submit a branch for comment. Just note clearly
at the top that the branch is not ready to be merged yet. You'll also
probably want to note the other pull request that it is based on, so
that the reviewers know that most of the commits come from that branch
and are ready to be merged.

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/sympy/-/WGZyflfsuUYJ.
> To post to this group, send email to sy...@googlegroups.com.
> To unsubscribe from this group, send email to
> sympy+un...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/sympy?hl=en.
Reply all
Reply to author
Forward
0 new messages