sympy-bot and changes in github API

[Marchael]

As someone from you already know, github changed own API. They not only changed url locations,but also content of response.

Yesterday, I tried to make sympy-bot work, but faced with few problems. github removed these fields from pull-list:

1. "mergeable" field

2. Email of author

3. Name of author(but login still appears)

pull's mergeable status as well as author's email and name still accessible from other requests, but in that case sympy-bot should do 2*n + 1 requests to github each time when "sympy-bot list" is running. For slow internet connection it's obviously bad.

I could help with fix of these requests, but I need to listen other opinions.

P.S. another solution is to fill issue on github tracker with ask to return these fields back to response.

[krastano...@gmail.com]

I would say implement it in whatever fashion you can (even if it is of
poor performance) (and do not forget to cash in the brownie points
that Aaron set as a bounty ;). At least it will be working. And huge
thanks for the effort.

[Aaron Meurer]

I agree. sympy-bot list is not a very common command. I think it's not
a big deal if it takes a little time.

Loss of other metadata is a shame. I guess we'll just have to do
without. If we want to test mergability, I guess we'll have to
download all the branches and try merging them. It actually won't take
very long if you use a local clone.

Aaron Meurer

On Jun 15, 2012, at 8:43 AM, "krastano...@gmail.com"

> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To post to this group, send email to sy...@googlegroups.com.
> To unsubscribe from this group, send email to sympy+un...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
>

[Aaron Meurer]

On Jun 15, 2012, at 5:52 AM, Marchael <marc...@kb.csu.ru> wrote:

As someone from you already know, github changed own API. They not only changed url locations,but also content of response.

Yesterday, I tried to make sympy-bot work, but faced with few problems. github removed these fields from pull-list:

1. "mergeable" field

2. Email of author

3. Name of author(but login still appears)

I think they expect you to do an additional query against the username to get these last two. 

Aaron Meurer

pull's mergeable status as well as author's email and name still accessible from other requests, but in that case sympy-bot should do 2*n + 1 requests to github each time when "sympy-bot list" is running. For slow internet connection it's obviously bad.

I could help with fix of these requests, but I need to listen other opinions.

P.S. another solution is to fill issue on github tracker with ask to return these fields back to response.

--

You received this message because you are subscribed to the Google Groups "sympy" group.

To view this discussion on the web visit https://groups.google.com/d/msg/sympy/-/9HFZX9YFUoEJ.

[Matthew Rocklin]

Do we come close to the 5000 per hour API limit? If not then lets not worry about it. If so then lets ask for an increase. 

[Aaron Meurer]

I think if anything we have to worry about the web app. But we really should change that to use hooks anyway. 

Aaron Meurer

[Mayorov Michael]

OK, thanks for feedback. I'll try to fix pull-list functionality in this
weekend.

--
With best regards,
Mayorov Michael

[Mayorov Michael]

I almost done working on fixing bot, will create pull request soon.

[krastano...@gmail.com]

> I almost done working on fixing bot, will create pull request soon.

Thanks for the effort. I have gone through your pull request and it
seems to be working. There are some issues that may need to be
discussed, but it is already usable.

https://github.com/sympy/sympy-bot/pull/109