--
You received this message because you are subscribed to the Google Groups "Spree" group.
To view this discussion on the web visit https://groups.google.com/d/msg/spree-user/-/XpJq8Pv9tRgJ.
To post to this group, send email to spree...@googlegroups.com.
To unsubscribe from this group, send email to spree-user+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/spree-user?hl=en.
I'm really interested in making the changes to support a Spree
namespace. I agree with Brian that it will invariably break a lot of
things but I agree with you that the benefits outweigh the problems.
The potential for being able to mount multiple apps together (ex.
Refinery + Spree) is just too compelling to ignore. Sure you can add
Spree to an existing Rails app but you run the risk of colliding with
namespaces, etc.
It would be so cool to add a Spree store to an existing Rails site
simply by doing the following:
Foo::Application.routes.draw do
mount Spree::Engine => "/store"
end
I think if we're going to contemplate doing this (and that's all we're
doing for now .. contemplating it) then we should do it before Spree
is 1.0.
@Josh: Are you volunteering to help with some of the heavy lifting?
If so, that would certainly increase my willing to consider it.
What do other people think on this topic? For reference you may want
to see the excellent Ryan Bates screen cast on Engines which discusses
the namespace stuff in some detail[1].
Sean
[1] http://railscasts.com/episodes/277-mountable-engines
> --
> You received this message because you are subscribed to the Google Groups
> "Spree" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/spree-user/-/KOOV9FBJ0KAJ.
I think this is excellent, and exactly where spree and refinery need
to be headed. I would be happy to put some time in on this.
--Christopher
--
You received this message because you are subscribed to the Google Groups "Spree" group.
To view this discussion on the web visit https://groups.google.com/d/msg/spree-user/-/SD3cvT464TwJ.
Sean
@Volunteers: Thanks for offering to help. We're definitely going to
take you up on it. I think we should plan on taking this up about two
weeks from now when we've got a stable Rails 3.1 compatible release
out the door. We've also got some pull requests and bug reports that
have been neglected while we finished up the Rails 3.1 merge.
Sean
> --
> You received this message because you are subscribed to the Google Groups
> "Spree" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/spree-user/-/SD3cvT464TwJ.
I agree that namespacing is a necessary first step and that will begin
in the very near future. We're working on getting Spree 0.70.0 out
the door in the next few days and then we'll turn our attention to
this. I plan on coming back to this thread and contacting each of the
people on this thread individually so we can coordinate a joint
effort.
Stay tuned.
Sean
> --
> You received this message because you are subscribed to the Google Groups "Spree" group.
https://github.com/spree/spree/tree/namespace
Will do a blog post on this shortly but in the meantime, please feel
free to submit pull requests and feedback.
Sean
JD is going to take a crack at porting over some of the models. I'm
recommending people just do small chunks at a time and issue pull
requests (use GH label for 'namespace'.) This way we won't be
duplicating work. For now I think we can pick random models, helpers,
etc. and start porting them over.
Regarding the tests, I'm in favor of more RSpec (and more tests in
general.) I don't think we should abandon the Cucumber stuff, a lot
of work went into that and I think its helpful to have some basic
browser coverage that exercises the javascript, etc. That said, if
you need to write a new test for something I don't think we need to do
it in cucumber.
So lets not throw cucumber away. In fact, I think maybe we
consolidate it into a new top-level features directory where we can
run all of the cukes (and see all of the steps, etc.) all in one
place.
Will try to get to a few of the models myself tonight to do my part.
I've been a little preoccupied lately but its going to be obvious what
I've been up to shortly when we make our next announcement.
Sean
Sean
> --
> You received this message because you are subscribed to the Google Groups
> "Spree" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/spree-user/-/54Jv9jU5sFoJ.
There will always be plenty of ways to help on the Spree project when
you come back. Wishing you a speedy recovery.
Sean
I am trying to setup a rails app using refinery and spree masters now.
One thing that comes to my mind is, that the current popular usage of
devise is just a first step into the glory world of real pluggable
rails engines.
I.m.O. we would need a de facto standard user management engine that
refinery, spree and other popular engines can use on demand.
It should provide a standard views and a well defined way to request
attributes, certain roles and some hooks for those engines.
Is anybody aware of a project with this goal ?
best
paul
On 9 Nov., 02:21, Ryan Bigg <m...@ryanbigg.com> wrote:
> Namespacing changes are now live on master.
>
> \o/ WOOT!
>
>
>
>
>
>
>
> On Thursday, 20 October 2011 at 12:26 AM, Sean Schofield wrote:
> > Kill it!
>
> > On Tue, Oct 18, 2011 at 9:20 AM, Brian Quinn <br...@railsdog.com (mailto:br...@railsdog.com)> wrote:
> > > I think rd_resource_controller can be dropped, like Jones Lee said it's only
> > > around for backward compat.
> > > I'd imagine the majority of people are no longer using it anyway.
> > > --
> > > Brian Quinn
> > > Sent with Sparrow
>
> > > On Tuesday 18 October 2011 at 12:33, Trung Le wrote:
>
> > > Thanks much for the great finding. Would removing rd_resource_controller
> > > help? This gem is there for the sake of backward comparability. I think it
> > > is about time to retire it.
> > > @romul, @schof, @BDQ: what's your thoughts?
> > > Trung LÊ
> > > line:https://github.com/spree/spree/blob/master/auth/app/controllers/resou...
> > > On 9 okt. 2011, at 23:29, Josh Adams <josh.ruby...@gmail.com (mailto:josh.ruby...@gmail.com)> wrote:
>
> > > So I was certainly one of the guys that volunteered for this initially. I'm
> > > still very interested. I cannot jump in and help presently as I've been in
> > > the hospital for a week now and am not sure when I'm getting out (nothing
> > > terminal, just a lot of pain and the treatment isn't very speedy). Just
> > > wanted to make sure I pinged you, Sean, so you wouldn't think I was some
> > > abandoner-guy :)
>
> > > Anyway, I'll get involved when I can. Love how quickly this is going.
>
> > > -Josh
>
> > > On Fri, Oct 7, 2011 at 11:19 PM, Ryan Bigg <m...@ryanbigg.com (mailto:m...@ryanbigg.com)> wrote:
>
> > > Turns out the controller specs weren't tricky at all. Fixed + pushed.
>
> > > On Saturday, 8 October 2011 at 3:11 PM, Ryan Bigg wrote:
>
> > > Thanks John for getting started on the model namespacing!
> > > I took some time today to get the tests passing again on the namespace
> > > branch, and now I'm back to having the two tricky controller specs failing.
> > > The next thing to do now is to namespace all the stuff in the lib
> > > directory correctly (except generators, leave that where it is) and then I
> > > reckon we're done? Wow :)
>
> > > On Saturday, 8 October 2011 at 3:36 AM, Sean Schofield wrote:
>
> > > FYI - I told John to go ahead with this effort even though its going
> > > to break some things. There's really no way to keep everything
> > > functional without fixing everything all in one shot. Since this is
> > > on its own branch I think its fine to go full speed ahead and get
> > > everything back to working condition as quickly as possible.
>
> > > Sean
>
> > > On Fri, Oct 7, 2011 at 12:34 PM, John Dyer <lbra...@gmail.com (mailto:lbra...@gmail.com)> wrote:
>
> > > Hey Ryan,
> > > I've begun working on namespacing all the top level models. Essentially
> > > just
> > > renaming the models and their respective tables and moving them into
> > > app/models/spree. Hope this helps accomplish what we want to achieve here.
> > > I
> > > will be pushing my branch at the end of the day so you can take a look at
> > > it.
> > > Cheers,
> > > John Dyer
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To view this discussion on the web visit
> > >https://groups.google.com/d/msg/spree-user/-/54Jv9jU5sFoJ.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to spree...@googlegroups.com (mailto:spree...@googlegroups.com).
> > > To unsubscribe from this group, send email to
> > > spree-user+...@googlegroups.com (mailto:spree-user+...@googlegroups.com).
> > > For more options, visit this group at
> > >http://groups.google.com/group/spree-user?hl=en.
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > > "Spree" group.
> > > To post to this group, send email to
>
> ...
>
> Erfahren Sie mehr »
Is anybody aware of a project with this goal ?
--You received this message because you are subscribed to the Google Groups "Spree" group.
To post to this group, send email to spree...@googlegroups.com.To unsubscribe from this group, send email to spree-user+...@googlegroups.com.
@Ryan: I agree that pluggable authorization, etc. would be awesome but
I would settle for a Devise + Cancan solution that works across Spree
+ Refinery. My feeling is that it will be hard enough to just get
this initial version working.
We'd likely learn a lot about what would be required of a generic
system by implementing with specific technologies first and paying
attention as we do it.
Thoughts?
Sean