is there a better DRY code writing for this scope ?

[Erwin]

I wrote this scope in my Subdomain model :

  scope :in_account, lambda { |account_id|

    if account_id == "*"

      where("account_id >= ?", 0)

    else

      where(account_id: account_id) 

    end

  }

where account_id == '*'  then all subdomain instances are selected

when account_id is given , only subdomain instances in this account are selected

is there a better writing ?

thanks for feedback

[Jim Ruther Nill]

you can use scoped instead

account_id == '*' ? scoped : where(account_id: account_id)  

 

thanks for feedback

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To post to this group, send email to rubyonra...@googlegroups.com.
To unsubscribe from this group, send email to rubyonrails-ta...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/3xoM8jq4ED8J.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
-------------------------------------------------------------
visit my blog at http://jimlabs.heroku.com

[Erwin]

Great !

Thanks Jim

[Dave Aronson]

Try:

scope :in_account, lambda { |account_id|
where(account_id: account_id) if account_id != "*"
}

If the conditional fails, this will just not interfere with the query.

If it's possible that account_id will be nil or blank (as on a page
accessed w/o passing any params), tack "&& account_id.present?" onto
the conditional.

-Dave

--
Dave Aronson, the T. Rex of Codosaurus LLC,
secret-cleared freelance software developer
taking contracts in or near NoVa or remote.
See information at http://www.Codosaur.us/.