pydot under Python3
295 views
Skip to first unread message
Jonathan Hartley
May 26, 2012, 9:24:01 PM5/26/12
to py...@googlegroups.com
Hey.
I just started editing my checkout of pydot to make it compatible with Python 3, while maintaining compatibility with Python 2, but now I come to look around here I notice that others have already done this.
Unfortunately both James Mills fork and pbouda's patches seem to now be out of date, not incorporating the latest changes to pydot.
Sorry if this has been asked often before, but is there any interest in merging changes like this into the main trunk?
Thanks for your attention,
Jonathan Hartley
newbie pydot user.
I just started editing my checkout of pydot to make it compatible with Python 3, while maintaining compatibility with Python 2, but now I come to look around here I notice that others have already done this.
Unfortunately both James Mills fork and pbouda's patches seem to now be out of date, not incorporating the latest changes to pydot.
Sorry if this has been asked often before, but is there any interest in merging changes like this into the main trunk?
Thanks for your attention,
Jonathan Hartley
newbie pydot user.
Ero Carrera
Jun 6, 2012, 7:37:20 AM6/6/12
to py...@googlegroups.com
It would be great to have those changes in sync. I personally don't use python 3 currently and I don't have time to keep both up-to-date.
--
ero
If you want to give it a shot I could try to bundle together the python 3 version as well and have it side by side on the site.
--
You received this message because you are subscribed to the Google Groups "pydot" group.
To view this discussion on the web visit https://groups.google.com/d/msg/pydot/-/D_e3K8pHumoJ.
To post to this group, send email to py...@googlegroups.com.
To unsubscribe from this group, send email to pydot+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/pydot?hl=en.
--
ero
Jonathan Hartley
Jun 6, 2012, 8:57:43 AM6/6/12
to py...@googlegroups.com
I've looked at James' Python 3 changes. They are relatively unintrusive,
and work under both Python 2 and Python 3, so I'd advocate rolling
James' changes back into the main trunk.
We could make a 'v1.0.29' release that is both Python2 and Python3
compatible.
Ero, how do you feel about that?
Jonathan
On 06/06/2012 13:38, Jonathan Hartley wrote:
> Cool, thanks for the thoughts.
>
> I entirely understand not being able to commit to spending time on it,
> and not wanting to burden future pydot development.
>
> How about if I prod James Mills and pdouba directly, see if there is
> any consensus about the best way to handle this moving forward. I'm
> happy to do the donkey work if any needs doing - hopefully James and
> pdouba have already done the hard parts.
>
> My thoughts are:
>
> a) Is it feasible to roll James and pdouba's Python 3 changes back
> into the main trunk, without introducing uncomfortable contortions
> into the code? If it turns out to be easy (just 'print' statements,
> etc.) then I'm happy to set up a 'tox' script to run all the tests
> under both Python 2 and Python 3, so that future commiters can easily
> see whether they broke anything.
>
> b) If the above is not feasible (e.g. the Python 3 changes are
> actually substantive) then can we use James existing fork to maintain
> the Python 3 source going forward? Is James happy to pull the recent
> pydot commits in? Or give someone else access to do so?
>
> c) If we use James' existing fork, then I'm especially keen to hear
> pdouba's thoughts on 'good' parts of his patches that we shouldn't
> miss out on.
>
> d) It would be nice to publish a 'pydot3' package in pypi, so that
> Python 3 users can pip install it.
>
> e) I'll commit to keeping the Python 3 release up to date whenever
> there's a new release of pydot.
>
> Jonathan
>>> py...@googlegroups.com<javascript:_e({}, 'cvml',
>>> 'py...@googlegroups.com');>
>>> .
>>> 'pydot%2Bunsu...@googlegroups.com');>.
Made of meat. +44 7737 062 225 twitter/skype: tartley
and work under both Python 2 and Python 3, so I'd advocate rolling
James' changes back into the main trunk.
We could make a 'v1.0.29' release that is both Python2 and Python3
compatible.
Ero, how do you feel about that?
Jonathan
On 06/06/2012 13:38, Jonathan Hartley wrote:
> Cool, thanks for the thoughts.
>
> I entirely understand not being able to commit to spending time on it,
> and not wanting to burden future pydot development.
>
> How about if I prod James Mills and pdouba directly, see if there is
> any consensus about the best way to handle this moving forward. I'm
> happy to do the donkey work if any needs doing - hopefully James and
> pdouba have already done the hard parts.
>
> My thoughts are:
>
> a) Is it feasible to roll James and pdouba's Python 3 changes back
> into the main trunk, without introducing uncomfortable contortions
> into the code? If it turns out to be easy (just 'print' statements,
> etc.) then I'm happy to set up a 'tox' script to run all the tests
> under both Python 2 and Python 3, so that future commiters can easily
> see whether they broke anything.
>
> b) If the above is not feasible (e.g. the Python 3 changes are
> actually substantive) then can we use James existing fork to maintain
> the Python 3 source going forward? Is James happy to pull the recent
> pydot commits in? Or give someone else access to do so?
>
> c) If we use James' existing fork, then I'm especially keen to hear
> pdouba's thoughts on 'good' parts of his patches that we shouldn't
> miss out on.
>
> d) It would be nice to publish a 'pydot3' package in pypi, so that
> Python 3 users can pip install it.
>
> e) I'll commit to keeping the Python 3 release up to date whenever
> there's a new release of pydot.
>
> Jonathan
>>> 'py...@googlegroups.com');>
>>> .
>>> To unsubscribe from this group, send email to
>>> pydot+un...@googlegroups.com<javascript:_e({}, 'cvml',
>>> 'pydot%2Bunsu...@googlegroups.com');>.
>>> For more options, visit this group at
>>> http://groups.google.com/group/pydot?hl=en.
>>>
>>
>
>
--
Jonathan Hartley tar...@tartley.com http://tartley.com
>>> http://groups.google.com/group/pydot?hl=en.
>>>
>>
>
>
--
Made of meat. +44 7737 062 225 twitter/skype: tartley
Jonathan Hartley
Jun 6, 2012, 8:38:44 AM6/6/12
to py...@googlegroups.com
> It would be great to have those changes in sync. I personally don't use
> python 3 currently and I don't have time to keep both up-to-date.
> If you want to give it a shot I could try to bundle together the python 3
> version as well and have it side by side on the site.
>
>
> On Sunday, May 27, 2012, Jonathan Hartley wrote:
>
>> Hey.
>>
>> I just started editing my checkout of pydot to make it compatible with
>> Python 3, while maintaining compatibility with Python 2, but now I come to
>> look around here I notice that others have already done this.
>>
>> Unfortunately both James Mills fork and pbouda's patches seem to now be
>> out of date, not incorporating the latest changes to pydot.
>>
>> Sorry if this has been asked often before, but is there any interest in
>> merging changes like this into the main trunk?
>>
>> Thanks for your attention,
>>
>> Jonathan Hartley
>> newbie pydot user.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "pydot" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/pydot/-/D_e3K8pHumoJ.
> python 3 currently and I don't have time to keep both up-to-date.
> If you want to give it a shot I could try to bundle together the python 3
> version as well and have it side by side on the site.
>
>
> On Sunday, May 27, 2012, Jonathan Hartley wrote:
>
>> Hey.
>>
>> I just started editing my checkout of pydot to make it compatible with
>> Python 3, while maintaining compatibility with Python 2, but now I come to
>> look around here I notice that others have already done this.
>>
>> Unfortunately both James Mills fork and pbouda's patches seem to now be
>> out of date, not incorporating the latest changes to pydot.
>>
>> Sorry if this has been asked often before, but is there any interest in
>> merging changes like this into the main trunk?
>>
>> Thanks for your attention,
>>
>> Jonathan Hartley
>> newbie pydot user.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "pydot" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/pydot/-/D_e3K8pHumoJ.
>> To post to this group, send email to py...@googlegroups.com<javascript:_e({}, 'cvml', 'py...@googlegroups.com');>
>> .
>> .
>> To unsubscribe from this group, send email to
Ero Carrera
Jun 12, 2012, 4:59:06 AM6/12/12
to py...@googlegroups.com
Sounds great! I'd love to look over the changes, maybe that way I lose
the fear of porting code to Python3.
ero
> To post to this group, send email to py...@googlegroups.com.
the fear of porting code to Python3.
ero
> To unsubscribe from this group, send email to
> pydot+un...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages