puppet module install; absolute path?

[Michael Hrivnak]

I work on the Pulp Project (http://www.pulpproject.org/), and we are trying to fully implement the forge API so we can create new repositories that can be reached via a command like:

$ sudo puppet module install --module_repository http://localhost/pulp/puppet/myforge/ someone/theirmodule

The problem I've encountered is that the install command includes hard-coded absolute paths to the API instead of relative paths. For example, see line 54 here:

https://github.com/puppetlabs/puppet/blob/4d06c647/lib/puppet/forge.rb#L54

Would this be received well as a bug report, or is there a reason for having absolute paths? We would love to see this behavior improved so that multiple forges could run on the same web server. Otherwise, we'll have to implement our own module installation routine that doesn't take advantage of the "puppet module install" tool.

Also, will the upcoming new API be accessed with relative URLs from the command line tool?

Thanks,

Michael

[Ryan Coleman]

Hi Michael, 

Thanks for the work you're doing. I got to play with Pulp v2 last night and really like the progress you guys have made. A few more comments are in-line.

On Thu, Jan 24, 2013 at 2:49 PM, Michael Hrivnak <mhri...@hrivnak.org> wrote:

I work on the Pulp Project (http://www.pulpproject.org/), and we are trying to fully implement the forge API so we can create new repositories that can be reached via a command like:

$ sudo puppet module install --module_repository http://localhost/pulp/puppet/myforge/ someone/theirmodule

The problem I've encountered is that the install command includes hard-coded absolute paths to the API instead of relative paths. For example, see line 54 here:

https://github.com/puppetlabs/puppet/blob/4d06c647/lib/puppet/forge.rb#L54

Would this be received well as a bug report, or is there a reason for having absolute paths? We would love to see this behavior improved so that multiple forges could run on the same web server. Otherwise, we'll have to implement our own module installation routine that doesn't take advantage of the "puppet module install" tool.

This particular end-point won't likely change as we'll be supporting existing versions of the PMT for a long time. However, we are working on a new API that will be publicly accessible and is likely to have a different structure than the one you see now. 

 

Also, will the upcoming new API be accessed with relative URLs from the command line tool?

I'll follow-up with you off-list about how we can help you get your work done in the interim and we'd love to discuss API design there. Hopefully we'll have more to discuss with a wider audience soon, but we're currently building a slew of publishing improvements for you and haven't gotten to finalizing an API.

 

Thanks,

Michael

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To view this discussion on the web visit https://groups.google.com/d/msg/puppet-users/-/Fb8sqGj2K5QJ.
To post to this group, send email to puppet...@googlegroups.com.
To unsubscribe from this group, send email to puppet-users...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.

--
Ryan Coleman | Modules & Forge | @ryanycoleman | ryancoleman in #puppet