OI Shopping lList

[Unnikrishnan Patel]

Sir ,  modifications or new ideas which i want o implement in OI Shopping list are given below.

1.Approx cost of total items in the list(So that he/she may carry at least that much amount).

2.Nearest location to purchase the item using GPS and google maps.

3.reminder that reminds what left to purchase after deadline given by user.

4.giving more details while sending the list to other person using message or email.

5.Storing the purchased items in database to find the monthly expenditure .

6.Setting up monthly budget, so that if user exceeds then app reminds the him/her to cut down in expenditure.

Shall  i start working on it?

Yours Sincerely

Unnikrishnan Patel

[Unnikrishnan Patel]

One more point , i want to sort items according to their categories so that it becomes  quite easy to implement my second point in the application. 

e.g (apple goes under fruits , tv goes under electronics)

[aap]

We welcome new contributors. However I don't fully understand all your proposals. For the simpler ones, it might be best to fork the OI Shopping List git repo, implement some of your suggestions in separate branches, and submit pull requests for review.

Some of the items in your list require further discussion... and you have come to the right place for that.

We do already show the total cost at the bottom of the screen, so I am not sure how to interpret your #1.

We like to keep the permissions needed for individual apps to a minumum. OI Shopping List does not have Internet access for example. I assume that some specific permission is needed for the GPS too. So it would be best to have some separate app that uses the necessary permissions for #2, and communicates with OI Shopping List via its content provider.

We do allow the user to change sort order. We use tags instead of categories, and the user can choose to sort by tags.

We have a "date" field in the database but it currently isn't being used. Before we can think about reminders we would need to get basic date functionality working. If you would like to work on that we could discuss it further. Once that is done, if reminders need additional permissions we might want them also to be managed by a separate app.

-- Aaron

[Unnikrishnan Patel]

Yes sir , i want to work on that date functionality . Please guide me through this.

Unnikrishnan Patel

[Friedger Müffke]

Could you please write down some use cases how and when the date field should be use.

Am 30.12.2012 06:32 schrieb "Unnikrishnan Patel" <unnikrish...@gmail.com>:

Yes sir , i want to work on that date functionality . Please guide me through this.

Unnikrishnan Patel

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.
To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/GnAQi8HsYvUJ.
To post to this group, send email to openi...@googlegroups.com.
To unsubscribe from this group, send email to openintents...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/openintents?hl=en.

[Unnikrishnan Patel]

 Sir,

   In whole shopping.db , i am not able to find 'date' entity in whole database except the 'DUE_DATE' in item's table  . 

   Sir , i am little bit confused in 'created '.and 'modified '  named entities.

   I need your guidance.

   Unnikrishnan Patel

[Unnikrishnan Patel]

Friedger sir , 

        we need the date field to implement the 3rd, 5th and 6th points of the  proposal.

Unnikrishnan Patel

[Friedger Müffke]

5th and 6th point are a different use case than 3.

I think that 5,6 needs a new table.

The Due Date in table items could be used, bit then the use case where you have different due dates for items in different lists is not covered. E.g. if you have item "tooth paste" in list "parents" and "tooth paste" in list "children".

Furthermore, some users make todo lists in Oi Shopping list. Do you want to cover this use case as well?

Modified and created are used for sorting only and should not be used for other semantics.

Cheers
Friedger

--

You received this message because you are subscribed to the Google Groups "OpenIntents" group.

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/jnfj4yE0XAoJ.

[Unnikrishnan Patel]

And Sir , why aren't we using 'DATE' datatype instead of 'INTEGER' for storing the dates .

Unnikrishnan Patel 

[Unnikrishnan Patel]

 Yes Sir  if you permit ,i also want to cover the todo list in my use case . 

Unnikrishnan Patel

[Friedger Müffke]

Date values are stored in milliseconds therefore integer.

Am 30.12.2012 14:41 schrieb "Unnikrishnan Patel" <unnikrish...@gmail.com>:

 Yes Sir  if you permit ,i also want to cover the todo list in my use case . 

Unnikrishnan Patel

--

You received this message because you are subscribed to the Google Groups "OpenIntents" group.

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/fOh_PVVrByEJ.

[aap]

Unnikrishnan,

As Friedger noted, the underlying database does not support specific date data types, as described here.

I was expecting that we would start by supporting the todo list case, and continue to build from there once it is working.

I was thinking of using the existing DATE_DUE field but I didn't realize it was in Items... Friedger is right that we would be better off adding a new DATE_DUE field in Contains. Since the existing field in Items is not used for anything, perhaps it should be removed.

So, we would probably want to proceed as follows:

• ShoppingDatabase.java: add the new field to Contains, including upgrade logic for existing databases
• ShoppingProvider.java: add support for the new field to the content provider, in Contains and ContainsFull
• EditItemDialog.java, dialog_edit_item.xml:add a button to the edit items dialog, which allows a date due to be set for existing items. Probably it should invoke OI Calendar Picker, following the example for how OI Notepad is invoked for the note button, including the prompt to install it if it's not already installed.
• add the new field to the list of columns in the query used for the list view, mStringItems in ShoppingActivity.java
• ShoppingItemsView.java: Add logic to display the due date in the list view. To avoid adding too much extra complexity to our item layout, I have been thinking that we should put it in the Tags, using a ClickableItemSpan to distinguish picks on the date from picks on "normal" tags. [A case could be made for putting it in the "price" position instead, at least for items without a price... but that might complicate the logic recently added to avoid overlapping the price with the item description. Might not be too bad though. We could consider adjusting the position later.]
• Add a sort order involving due dates to the "sortorder" preference in in preferences.xml and the code that uses it.

This is a rough outline. Neither the list nor the set of provided code pointers here are intended to be exhaustive: you will need to do some digging in the code yourself, and you should find that digging educational. Since you already found the DUE_DATE field I had somewhat mistakenly referred to, probably you will have no trouble continuing to familiarize yourself with the code.

That should cover the basics for use of dates for todo items within OI Shopping List itself. Once that is working, we would want to add date support to OI Convert CSV when importing and exporting HandyShopper format, being careful to support the way HandyShopper writes dates so that dates could be imported from existing HandyShopper data. Then the next step would be to consider alarm and/or calendar support, possibly implemented in a separate app.

-- Aaron

[Unnikrishnan Patel]

Thanks a lot Aaron sir and Friedger sir ..:)

    I am starting with the steps you told me .

[Unnikrishnan Patel]

Hello sir , 

   I am working on the database(shopping.db) . Why are we making a separate entity(_id) as a primary key for all the tables ? 

   i found it redundant and i can propose you a better solution.

Unnikrishnan

[Unnikrishnan Patel]

Sir , 

  i am very much confused about the following following entities in database.

1. due in items

2. units in items

you are referring due_date as the date on which the item was inserted in a particular  , right?

Thanks 

Unnikrishnan Patel

[aap]

Seems to be a requirement for content providers.

http://developer.android.com/reference/android/provider/BaseColumns.html

[Friedger Müffke]

> Sir , 
>   i am very much confused about the following following entities in database.
> 1. due in items

Due is what is referred to as due date in previous mails.

> 2. units in items
Is what is used in the edit dialog of items, can be kg, liter, boxes, inch, etc..

>
> you are referring due_date as the date on which the item was inserted in a particular  , right?
>
> Thanks 
> Unnikrishnan Patel
>

> --
> You received this message because you are subscribed to the Google Groups "OpenIntents" group.

> To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/BHwrC40r-WYJ.

[Unnikrishnan Patel]

Friedger sir , can you explain the concept of due_date again ? 

[Friedger Müffke]

As Aaron said, there is no use of it at the moment

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/XgNV7HAT5mEJ.

[aap]

Friedger,

But we were talking about adding it to Contains... I assumed in the second request he was asking to explain that intended usage.

Unnikrishnan,

In Contains, it would refer to the date by which a given item needs to be completed, in a list being used as a "to do" list; or, in a shopping list, it could mean the date by which the item should be purchased.

-- Aaron

[Unnikrishnan Patel]

Yes Aaron sir , i was talking about adding it in 'contains'. Thanks sir , now i got it...:)

[Unnikrishnan Patel]

Sir , 

 i have to add another textview in dialog_edit_item.xml to accomplish this due date functionality.

Unnikrishnan Patel

On Monday, December 31, 2012 9:15:21 PM UTC+5:30, aap wrote:

[aap]

You'll want both a TextView and a button, similar to what the Price field looks like when "track per-store prices" is enabled in preferences. The TextView could say "Date: 31-Dec-12" if a date already exists, or just "Date:" if the item doesn't have one yet. The button should behave similar to the Note button, but summoning OI Calendar Picker to allow the user to choose a date.

The Note button is too big... so it probably makes sense to stick Date in between Priority and Note.

-- Aaron

[Unnikrishnan Patel]

And sir , i think by that we can use notification to implement 3rd point(reminder) of my proposal. Guide me , Sir.

Unnikrishnan Patel

[aap]

As I said before, it probably makes sense to get the basic date functionality working before we worry about the best way to implement reminders. Let's start with setting dates, displaying them in the list view, and sorting by them.

-- Aaron

[Unnikrishnan Patel]

Sure sir , i am on it.

Unnikrishnan Patel

[Friedger Müffke]

Please make sure that existing functionality is not broken while addding new features.
In particular, hide the due date by default and add a setting to enable it.
Also it is important to document the new features better than currently done. If you have ideas please share...

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/VP5uFyAPJPgJ.

[Unnikrishnan Patel]

Friedger sir , 

  it wont affect any other existing functionality. 

  After this date functionality, i want to work on 4th point(giving more details while sending the list to other person using message or email.) of my proposal . i want to make it more expressive and impressive.

One feature i thought we could implement is to change text color of the item in the list according to their priority. eg .(red for high priority - green for low priority) 

Unnikrishnan Patel

[Unnikrishnan Patel]

Sir , i have to make some changes in shoppinglistlibrary to add the date functionality . Shall i make some necessary changes?

Unnikrishnan Patel

[aap]

In your own repository you can do whatever you have to do. When we review your changes we can discuss whether it was really necessary... but probably it is. You can go ahead with the changes, or, if you want feedback in advance you will have to be more specific about what kind of changes you intend to make.

-- Aaron

[Unnikrishnan Patel]

Sir , 

 I am facing difficulty in inserting duedate in contains table , please help me.

Unnikrishnan Patel 

[Unnikrishnan Patel]

Its done sir, dont worry about previous post...

now please help me regarding whether i should use OI Calender or inbuilt datepicker or calender ?

Unnikrishnan

[Unnikrishnan Patel]

as OI Calender picker is not released , I am using a EditText with the input type  'date' for our DUEDATE functionality  . As soon as it is released i will update the app.

Unnikrishnan Patel 

[aap]

Not sure what you mean by not released.

https://play.google.com/store/apps/details?id=org.openintents.calendarpicker

[Unnikrishnan Patel]

ok then , i saw written in openintents website that it is coming soon. So here one question arise , do the OI Calender Picker itself returns the date chosen to OI Shopping List when invoked  or do i need an instance of it to return the date ? 

Unnikrishnan Patel

[aap]

Have a look at how the result is handled by CalendarPickerDemo's onActivityResult() method.

-- Aaron

[Unnikrishnan Patel]

Sir , i have to set URI for calender in shoppingContract,java . That i what making trouble . Can you please help me on that issue.

Unnikrishnan Patel

[Unnikrishnan Patel]

i will go through it , not a problem any more . Just one last question , shall i add the image button for OI Calender picker and edittext  below priority and note? ,because there isn't much space to populate 4 components linearly.

Unnikrishnan Patel

[Friedger Müffke]

Not an easy problem. I suggest to try some different possibilities and
post some screenshots.

2013/1/3 Unnikrishnan Patel <unnikrish...@gmail.com>:

> --
> You received this message because you are subscribed to the Google Groups
> "OpenIntents" group.
> To view this discussion on the web visit

> https://groups.google.com/d/msg/openintents/-/MtVv4W36MIsJ.

[Unnikrishnan Patel]

I am posting the screenshot of the layout on which i am working.

Unnikrishnan Patel

[Friedger Müffke]

CalendarPicker should not be a label. The image should be enough.
Otherwise, looks good to me.

2013/1/3 Unnikrishnan Patel <unnikrish...@gmail.com>:

> https://groups.google.com/d/msg/openintents/-/2jOJlY42uuEJ.

[Unnikrishnan Patel]

i did it because i followed the way in which note button  has been placed with the label. 

So, what changes do i have to make?

 

Unnikrishnan Patel

[aap]

I was expecting a single column in between priority and note, with a text field on top and the calendar picker icon on the bottom.

The text field would say "Due Date" or just "Date" if no date was entered yet for this item, and if there was a date, the text field would be updated to say "(due?) Date:  DD-MMM-YYYY." Similar to the behavior of the price button, whose label sometimes says "Price: 4.37".

I slightly favor just "Date" over "Due Date" in the label because it leaves the interpretation of the date more open to the user.

-- Aaron

[Unnikrishnan Patel]

But Sir ,  i had to display DATE somewhere . That is the main reason behind this layout.

I will change the label from "Due Date" to "Date"

Unnikrishnan Patel

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/VDd2vUhzsFkJ.

[Unnikrishnan Patel]

and i will also make changes as you described in your previous message (line 2-3).

Unnikrishnan Patel

To unsubscribe from this group, send email to openintents+unsubscribe@googlegroups.com.

[Unnikrishnan Patel]

Sir ,below i am posting my code for calender picker button , as soon as i click on the button , the application crashes.

Please help me in this code.

mCal.setOnClickListener(new View.OnClickListener() {

        

@Override

public void onClick(View v) {

PackageManager pm =mContext.getPackageManager();

Intent intent = pm.getLaunchIntentForPackage("org.openintents.calendarpicker");

try {

mContext.startActivity(intent);

} catch (ActivityNotFoundException e) {

Dialog g = new DownloadAppDialog(mContext,R.string.calnotavailable,

R.string.calender,

R.string.calenderpackage, R.string.calenderwebsite);

g.show();

}

}

});

[aap]

What does the logcat say?

Might want to compare with the launching code in CalendarPickerDemo, at least with how the Intent is formed. I don't think a "LaunchIntent" is what you want... and I don't know what the PackageManager would return if the calendar picker is not installed yet.

-- Aaron

To unsubscribe from this group, send email to openintents...@googlegroups.com.

[Unnikrishnan Patel]

PackageManager.NameNotFoundException

This exception is thrown when a given package, application, or component name can not be found.

My current code just invokes the calender picker app , or if not found it behaves exactly the same as the note button works .

Unnikrishnan Patel

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/B3sQ_AhU1i4J.

[Friedger Müffke]

Please review how to solve errors like this. Have a look at some tutorials, debug your code and search the web.

If you can't find any pointers to a solution we are more than happy to help. Please provide a detailed description of the problem and what you have already tried.

Is the calendar picker app installed?

Cheers
Friedger

[Unnikrishnan Patel]

Ye , i installed the calender app.

the main problem which i am facing is that after the installation of calender picker app , still this code catches exception and always open the dialog box giving download options. Please help me through this.

mCal.setOnClickListener(new View.OnClickListener() {

        

@Override

public void onClick(View v) {

PackageManager pm =mContext.getPackageManager();

Intent intent = pm.getLaunchIntentForPackage("org.openintents.calendarpicker");

try {

mContext.startActivity(intent);

} catch (Exception e) {

Dialog g = new DownloadAppDialog(mContext,R.string.calnotavailable,

R.string.calender,

R.string.calenderpackage, R.string.calenderwebsite);

g.show();

}

}

});

Unnikrishnan Patel

[Friedger Müffke]

Have you checked this

http://code.google.com/p/openintents/wiki/CalendarPickerAPI

?

Why don't you launch a PICK intent?

Friedger

2013/1/4 Unnikrishnan Patel <unnikrish...@gmail.com>

org.openintents.calendarpicker

[Unnikrishnan Patel]

Hello sir,

My code  is working fine with inbuilt android calender(com.android.calendar) . There is some problem in OI calender picker .

Unnikrishnan Patel

[Friedger Müffke]

Please have a look at the stack trace. Have you downloaded the source code?

2013/1/4 Unnikrishnan Patel <unnikrish...@gmail.com>:

> --
> You received this message because you are subscribed to the Google Groups
> "OpenIntents" group.
> To view this discussion on the web visit

> https://groups.google.com/d/msg/openintents/-/ZtY1WDEPQnEJ.

[Unnikrishnan Patel]

Yes , i did.

[Unnikrishnan Patel]

I think i got the answer that the OI Calenderpicker only support sdk version 4 .

Unnikrishnan Patel
On Wednesday, December 26, 2012 10:59:22 PM UTC+5:30, Unnikrishnan Patel wrote:

Sir ,  modifications or new ideas which i want o implement in OI Shopping list are given below.

1.Approx cost of total items in the list(So that he/she may carry at least that much amount).

2.Nearest location to purchase the item using GPS and google maps.

3.reminder that reminds what left to purchase after deadline given by user.

4.giving more details while sending the list to other person using message or email.

5.Storing the purchased items in database to find the monthly expenditure .

6.Setting up monthly budget, so that if user exceeds then app reminds the him/her to cut down in expenditure.

Shall  i start working on it?

Yours Sincerely

Unnikrishnan Patel

[Unnikrishnan Patel]

according to the source code.

[Unnikrishnan Patel]

Sir , what is the solution for that?

[Friedger Müffke]

Could you please provide more details about the error?

What is the full error message? In what line is the error thrown, I.e.full stack trace please? What is the value of the intent?

Debugging error is sometimes not easy. We can't do the debugging for you but we can help you to get more practice...

Friedger

Friedger

Am 05.01.2013 10:39 schrieb "Unnikrishnan Patel" <unnikrish...@gmail.com>:

[Unnikrishnan Patel]

Hello Sir,

I tried in more then 10 android phones and my native emulator also. The code inside the try block always throws NameNotFoundException with the OI CalenderPicker app , it works fine with the inbuilt calender of android OS(or any other app i want to invoke with that button). I tried to explain you the same thing few previous messages.

mCal.setOnClickListener(new View.OnClickListener() {                                                                                      

        

@Override

public void onClick(View v) {

PackageManager pm =mContext.getPackageManager();

Intent intent = pm.getLaunchIntentForPackage("org.openintents.calendarpicker");

try {

mContext.startActivity(intent);        //THIS LINE ALWAYS THROWS NameNotFoundException  FOR OUR OI CALENDER PICKER APP.

} catch (Exception e) {

Dialog g = new DownloadAppDialog(mContext,R.string.calnotavailable,

R.string.calender,

R.string.calenderpackage, R.string.calenderwebsite);

g.show();

}

}

});

I think  OI Calender is made for sdk version 4(the bug ) only(its menifest file points out that).. Please see to it and let me know if the information i provided is still insufficient or not . 

Cheers

Unnikrishnan Patel

[Unnikrishnan Patel]

until the issue is resolved , I am using the calender comes by default with android for picking date .

any suggestion?

Unnikrishnan Patel

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/LrRu324qZAMJ.

[Friedger Müffke]

Problem is solved. Now the PICK intent :-)

2013/1/5 Unnikrishnan Patel <unnikrish...@gmail.com>:

[Unnikrishnan Patel]

sure sir , i'll do it asap...:)

thanks again..:)

[Unnikrishnan Patel]

Hello , i am posting the version of OI shopping list with the date functionality using EditText . 

>> openintents+unsubscribe@googlegroups.com.

>> For more options, visit this group at
>> http://groups.google.com/group/openintents?hl=en.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "OpenIntents" group.
> To post to this group, send email to openi...@googlegroups.com.
> To unsubscribe from this group, send email to

> openintents+unsubscribe@googlegroups.com.

> For more options, visit this group at
> http://groups.google.com/group/openintents?hl=en.

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.
To post to this group, send email to openi...@googlegroups.com.

To unsubscribe from this group, send email to openintents+unsubscribe@googlegroups.com.

[aap]

Posting a link to a branch on github is much easier for reviewers to deal with than a zip file with code. 

I assume the zip file you posted is more or less analagous to the commit here.

If so, I see some attempt at using an inner class of the EditItemDialog which is also an Activity so that you can get the onActivityResult callback. Does that actually work?

Your brief note here might lead one to believe that everything is supposed to be working already in the zip file you posted. At least in the github version I don't see anything about sorting or displaying dates in the shopping list view yet.

If you had said "this is an attempt at adding the date button to the EditItemDialog, what do you think?" that would have set more realistic context for reviewers.

You might also pay closer attention to which files are included in your commit -- the classpath changes and eclipse preference files probably don't belong in your eventual pull request. It's also wise to use a commit comment that says something specific about your changes -- "changes done so far" is not going to be meaningful to people reviewing project history in this view. The commit message should be something that might help someone who is looking for a specific change decide whether to drill into that commit or keep scrolling.

With that in mind, you might consider "git reset b04cadd39800772b734" -- which will reset your branch to the previous state, but leave your working tree intact-- followed by more carefully choosing the content of the commit and its title. I know you are using the github Windows app and it may or may not have a way to do that in the UI, but it does include shell commands as well. 

-- Aaron

>> openintents...@googlegroups.com.

>> For more options, visit this group at
>> http://groups.google.com/group/openintents?hl=en.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "OpenIntents" group.
> To post to this group, send email to openi...@googlegroups.com.
> To unsubscribe from this group, send email to

> openintents...@googlegroups.com.

> For more options, visit this group at
> http://groups.google.com/group/openintents?hl=en.

--
You received this message because you are subscribed to the Google Groups "OpenIntents" group.
To post to this group, send email to openi...@googlegroups.com.

To unsubscribe from this group, send email to openintents...@googlegroups.com.

[Unnikrishnan Patel]

Sir , solved those previous issues...:)

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/5804d957ecb058fe84c8c6ff9aa0d1495c7a02bc  

I am still facing some issues on that date functionality , the edititemdialog.java  extends AlertDialog and because of that i am facing some issues in calling onActivityResult method to receive date from calender.Please help me through this.

Unnikrishnan Patel

[Friedger Müffke]

You can use the context of the dialog to start the pick intent.

The activity has to handle the result and send it to the dialog.

I would also like to encourage you to upgrade to DialogFramgment....

Cheers
Friedger


2013/1/8 Unnikrishnan Patel <unnikrish...@gmail.com>:

> https://groups.google.com/d/msg/openintents/-/aVazA85Ytt4J.

[Unnikrishnan Patel]

I thought about using the dialogfragment , i just wanted your approval.

Unnikrishnan Patel

[Unnikrishnan Patel]

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/577c21bc3598d8af4b73d2a9604ae06d2af991ee

[Unnikrishnan Patel]

Solved every other issues , only the left one is to convert to dialog fragment , and i will complete it soon.

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/577c21bc3598d8af4b73d2a9604ae06d2af991ee

Unnikrishnan Patel

[Unnikrishnan Patel]

Hello sir , Date functionality added , but one small issue is there , help me.

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/cf4b11f66eb5f493735dc66f36f7587fd71b8c2f

Unnikrishnan Patel

[Unnikrishnan Patel]

Done with date functionality.

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/b37c9bd7c2f93ca4ae42a3387e5589f778cf4546

next task?

Unnikrishnan Patel

[Unnikrishnan Patel]

 revised code with solved style issues.

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/f35af8f40d50803201060fb9514f6e80dbee477e

Unnikrishnan Patel

[Friedger Müffke]

Have you seen the Android Design in Action Video on YouTube about shopping lists? Maybe we can improve the app by updating to new design patterns.

Cheers
Friedger

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/_fRL6tCNCh0J.

[aap]

Hi Unikrishnan,

In this post I outlined the tasks for date support.  Have you done everything there? I don't see all the mentioned files in your commit. From what I saw in your code you have the edit item dialog changes, but not the list view changes or sorting support.

I don't have time to test it now, but it does look like a good start... however I'm not sure we can say date support is "done."

-- Aaron

[Unnikrishnan Patel]

Sir , i tried that and it is making app too messy . I talked to Friedger sir about  this . And we reached at the same conclusion that it might create a bad display of Listview . Its easy to implement.

And i need some help for sorting support.

[aap]

Unnikrishnan,

As you have undoubtedly notice by now, my schedule does not permit me to spend much time in Google Talk. For the purposes of this discussion, that is probably a good thing. Although IM conversations seem faster, proper use of this forum is much more efficient-- it allows more people to follow and participate in the discussion.

I have not seen the code you showed Friedger so I can't comment on whether the result would be messy. However if you would follow the suggestion from my earlier message, the date would appear as if it were just another tag; I don't see why that would look any messier than the existing display with tags.

I hope you have found the sorting code. If you have specific questions, please ask them; "I need help for sorting support" is not really providing enough context to enable me to help you.

-- Aaron

[Unnikrishnan Patel]

Hello , 

   Last two task(sorting and displaying date in listview) given by Aaron sir are taking more time then expected . So can you please give me some other task. Apologies for not completing them .

Work done till now.

1.optimized database and code  for updating database  of OI Shopping List

2.Added date functionality in OI Shopping list using OI Calendar Picker.

3.Solved a bug in shopping database (date in item's table).

4.Sending list through message or email(working on it).

If you could assign me to solve some other issue , it would be great because sorting and displaying date in listview is taking much time and still i am not able to complete them.

Unnikrishnan Patel

[aap]

Unnikrishnan,

You began this thread by listing some ambitious project ideas and asking if you could begin implementation right away. Basic date support seems to be a prerequisite for some of those ideas. Of course you are under no obligation to us to complete the implementation of all the work items needed for basic date support. If you choose not to finish it, someone else might implement it some day, perhaps even me if I find some time at some point and nobody else has stepped up by then. But that won't happen right away. Until someone implements basic date support, it will be difficult to discuss continuing your original proposal.

Therefore I am confused by your current request. Please help me understand your goals in requesting a new task: What kind of task are you looking for? What do you hope to accomplish, if not laying the foundation for your original proposal?

-- Aaron

[Unnikrishnan Patel]

Sir ,

     i want to complete my proposal as soon as possible and make the OI shopping list more then better . But the thing is i am best at core programming , optimization ,algorithms ,  all data structures ,machine language and assembly language(ARM programming ). This is the first time i am working on android mobile development that's why i am little bit slow  . Some codes really needs help and time to understand .

    I want to work on my proposal only . But if you could provide me some documentation for the app , it will make everything easy for me . I use IM because you guys can solve my doubts instantly . I am adding documentation wherever it is needed .

Unnikrishnan Patel

[Unnikrishnan Patel]

Hello sir , 

I am done with displaying date in listview . so if you tell me the position for displaying it , i'll be done with the date functionality. :)

Cheers 

Unnikrishnan Patel 

[Unnikrishnan Patel]

And one more thing , the "price" textview in the listview is not used . So if we don't need that textview anymore , i can place date in that position.

Your suggestions needed.

Unnikrishnan Patel

[aap]

Unnikrishnan,

Have you tried creating items and assigning prices to them? The price textview is definitely used. What leads you to suggest otherwise?

My opinion about where to display date has not changed since this message: we should put it in the Tags, using a ClickableItemSpan to distinguish picks on the date from picks on "normal" tags. Be sure to test with items which have both tags and dates.

-- Aaron

[Unnikrishnan Patel]

hello sir,

date in listview has been done , now working on sorting issue .

https://github.com/Unnikrishnan-Patel/shoppinglist/commit/7109ca7ca78cb52661f1c3274bb60e9a5bcd7ae2

[aap]

Hi Unnikrishnan,

Looks like you opted to add a new view instead of putting the date in the Tags view as I had suggested. It could be made to work this way, but without extra work I expect you will have a problem with item descriptions of certain length overlapping the date display. 

Putting the date in Tags is not the only way to solve that-- if you prefer having a separate TextView for date, you might try adjusting the code I recently added to avoid the name overlapping the price so that it accounts for the date as well, by adding a second transparent ImageSpan sized to match the date field. My earlier suggestion is probably easier, which is why I suggested it, but this approach might have a nicer-looking result, especially for items with no tags.

Just noticed that you are storing the date in the database as a string. I think that will make it difficult to get the sorting right. Integer date, in the standard sense of seconds since some baseline, is more standard, more sortable, and leaves us open to being able to have not just dates but times if somebody wants to add those in the future. You might pay attention to the code where we convert the prices to and from cents for some ideas about where and when to convert dates between integers and strings.

-- Aaron

[Unnikrishnan Patel]

Sir , 

 i coded the things in such a way that they wont be overlapping  and i tested the app with all kind of long inputs and trust me they are not overlapping. ..:)

i can post the screenshots if you want . I have done this in tag view only.

Cheers

Unnikrishnan Patel

[Friedger Müffke]

Don't trust developers :-)

As you can see in the history of this mailing list we have discussed lots of scenarios with overlapping.
Could you send an apk for quick testing.

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/NF9wDaOgNx8J.

[aap]

Screenshots might help. Also please explain what part of the code ensures that they won't overlap.

If you "have done this in tag view only" then why do you have mDateView and why is there a new view added in shopping_item_row.xml?

Please try this: create an item with a date, then add a few characters at a time to the name of the item until the point where its new length would cause it overlap the date without itself expanding to a new line. Does the date move out of the way or not?

-- Aaron

[Unnikrishnan Patel]

Aaron sir , it is working completely fine with all kind of input you told me to apply ..:)

i am posting my apk file here for you to check..:)

trust me , i tested it for the whole day before posting it in the forum.

Cheers 

Unnikrishnan

[Unnikrishnan Patel]

i am also posting a screenshot here to clear all the confusions...:)

[Unnikrishnan Patel]

another screenshot with name just reaching the end of the canvas.

[Unnikrishnan Patel]

Revise apk here , dont use that previous one (it was my backup). This one is the final one.

[aap]

The presence of tags is preventing the overlap. Please test again with items that have no tags.

-- Aaron

[Unnikrishnan Patel]

i did this with only date and name also  and it is working fine  ..:) . Shall i post the screenshot of that also?

cheers

Unnikrishnan Patel

To view this discussion on the web visit https://groups.google.com/d/msg/openintents/-/s6vM-QPwVKIJ.

[Friedger Müffke]

I tested 5 minutes. Sorry that you wasted one day. Probably, it is a cultural thing, but I would never ask someone to trust my code. Not even my clients.

Or did I do something wrong with testing?

Friedger

[Unnikrishnan Patel]

Frieger Sir , i am posting the apk file again , Trust me this time you wont see any problem..:)

Sorry for previous problem

[Unnikrishnan Patel]

Screenshot of the revised app.

[aap]

Friedger,

Looks like you have tags overlapping with price... I never fixed that case. But I don't see any dates here, am I missing something?

-- Aaron