Quoting in asm files

[Jean-Pierre Flori]

While I'm at it, we also patch asm files of MPIR in Sage to add some quoting.
Indeed it seems that some version of m4 behave badly and underquoting can lead to wrong (empty) expansion.

Could this be integrated upstream?
That should not hurt, perhaps let MPIR build on some broken system and would save us the hassle to maintain this patch in Sage.

Best,
JP

[Bill Hart]

Sure, I'll add that to the list. It sounds like a relatively harmless patch.

Bill.

> --
> You received this message because you are subscribed to the Google Groups
> "mpir-devel" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/mpir-devel/-/YHuwOOk7wcMJ.
> To post to this group, send email to mpir-...@googlegroups.com.
> To unsubscribe from this group, send email to
> mpir-devel+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/mpir-devel?hl=en.

[Jean-Pierre Flori]

On Thursday, November 29, 2012 1:16:04 PM UTC+1, Bill Hart wrote:

Sure, I'll add that to the list. It sounds like a relatively harmless patch.

Bill.

 
Great!
Here is the command we use to modify the asm files:
find mpn -name '*.asm' -exec sed -i 's/define(\(OPERATION[^,]*\),/define(\`\1'"'"',/' {} \;