Hanafi asr time not working!!!!

[alkhalwati]

Salam,
jazakallah khayr for the extension.
There is no option for asr time according to hanafi fiqh. i have read
some of your other responses saying that it should be on the app
however there is no option for it and i have just been through all
the
possible options and calculation methods but they all have asr at the
same time. it should be roughly an hour forward in the hanafi madhab
and none of the calculations accomodate this. please could you have a
look into it?
jazakallah khayr

[Mukarram]

*Bump*
This extension has saved me more times than I can count, may Allah
reward you for it.

Unfortunately, although the code to calculate the Hanafi time for Asr
is there, I could not, for the life of me, find any way to choose this
method of calculation in the extension.

[Mohamed Mansour]

I am not familiar with that calculation, I thought I exposed all the calculations from that API. When I get time, I will look into it, the source code is open for those who want to help me out!

https://github.com/mohamedmansour/prayer-times-extension 

Kind regards,
Mohamed Mansour

--
You received this message because you are subscribed to the Google Groups "mohamedmansour-extensions" group.
To post to this group, send email to mohamedmanso...@googlegroups.com.
To unsubscribe from this group, send email to mohamedmansour-ext...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mohamedmansour-extensions?hl=en.

[Mukarram]

I've actually managed to mess with it enough to get it to say the correct Asr time for me. Although I don't know anything about CSS, Java, or HTML, I was able to understand enough to know what parameter needed to be changed: based solely on praytimes.org and the code provided there, in the calculation for Asr time, a single pre-set parameter is changed to make the correction. This parameter is the 'asrJuristics' for which the value is either "Hanafi" or "Standard"; the latter is the default. This system already exists in the code, all that needs to be done is to provide a way to select one over the other in the options page and have that permeate through the time calculation/presentation. Since I have no idea how to implement it, I literally just went through all the script and HTML files on my computer in the Chrome folder associated with the extension (which I found at C:\Users\[username]\AppData\Local\Google\Chrome\User Data\Default\Extensions\ndmbeogingkjkmmkoomnigifmpajmbkc\3.0.2_0) and searched for "asr" and "Standard" and changed it manually to "Hanafi" i.e. I changed the default to "Hanafi" because it was easy to find where that was set.

I figured you could probably do something similar to the example provided on praytimes.com: prayTimes.adjust( {fajr: 16, dhuhr: '5 min', asr: 'Hanafi', isha: 15} );  [source: http://praytimes.org/manual#Tuning_Times]

I just didn't know where or how to implement it for it to take effect in the options page.

[Mohamed Mansour]

Ah! So asr is hanafi! Hmm, sneaky :) So basically we need another option stating whether to use hanafi (perhaps a checkbox) and that checkbox, will be used when we pass the data to prayertimes.

That should be quite easy. Thanks :)

Kind regards,
Mohamed Mansour

--

You received this message because you are subscribed to the Google Groups "mohamedmansour-extensions" group.

To view this discussion on the web visit https://groups.google.com/d/msg/mohamedmansour-extensions/-/6Ysxf77xdjQJ.

[Mukarram Amine]

I'm glad I could help! If you recall, shortly before or right about the time Google+ came out and you became super busy with that (I assume) I contacted you with this same issue, and I'm glad that now, I could do more than just request an update!

Best regards, 

Mukarram

[Mohamed Mansour]

If you know JavaScript a bit, or would like me to mentor you, I could help anyone out if they would like to learn :) This change is pretty straight forward, I am pretty busy this week since I am moving so we will see how time goes :)

Kind regards,
Mohamed Mansour

[Mukarram Amine]

Unfortunately, I have absolutely no knowledge of Javascript. My programming experience is limited to an HTML class I took in high school about 7 years ago, and MATLAB, which, if you are not familiar with, employs logic similar to other languages, but in implementation is very different.

I would in fact love to learn, but my final exams are next week, so I cannot devote any time to it just now. I thank you for the offer, and will surely take you up on it after finals.

Mukarram

[Sonja Elen Kisa]

This is the hack I use:

1. Open this file C:\Users\Sonja\AppData\Local\Google\Chrome\User Data\Default\Extensions\ndmbeogingkjkmmkoomnigifmpajmbkc\3.0.2_0\js\pray_time.js

2. Change line 115 to

maghrib: '0 min', midnight: 'Standard', asr: 'Hanafi'

[Anas Hashmi]

Thank you so much. 

For all other people, type this path in run window: 

%USERPROFILE%\AppData\Local\Google\Chrome\User Data\Default\Extensions\ndmbeogingkjkmmkoomnigifmpajmbkc\3.0.2_0\js\

open the pray_time.js file in notepad, and go to line 164 and change from standard to hanafi.