Changes/Enhancements for the next analysis plugin release

61 views
Skip to first unread message

Mark Collin

unread,
Jul 27, 2012, 10:08:13 AM7/27/12
to maven-jmeter...@googlegroups.com

Arne,

 

I’ve checked in a couple of changes today based upon feedback in the users thread. 

 

First of all, has anything I’ve checked in today gone against your vision for the analysis plugin?

 

Secondly have you got any plans for future versions of the plugin? 

 

Right now I’m thinking it would be worth adding in some additional default templates to give people something very close to the output created by the old jmeter plugin just to highlight the flexibility of the freemarker templates if nothing else.

 

I think it’s going to be worth doing a release fairly quickly if we don’t have any real plans for additional code right now.

 

Arne Franken

unread,
Aug 1, 2012, 4:23:34 AM8/1/12
to maven-jmeter...@googlegroups.com
Hey mate,

the changes look good, even though I am still not very happy with the fact that multiple tests can be run/analyzed during one plugin execution, but that's another matter...

I fixed three things: 
- the filename wasn't used
- the extension of the filename is cut off before it's used (so the summary file name is now "test.html" instead of "test.jtl.html")
- fixed the integration test

The Lazerycode CI says everything is green.

I think the plugin is ready for a release now.

Cheers,
Arne

Mark Collin

unread,
Aug 1, 2012, 5:15:19 AM8/1/12
to maven-jmeter...@googlegroups.com

I was having a look at the results on our CI server this morning and I think we may need to make another small change.  My runs are also creating :

 

Thread-durations.csv

Thread-durations.png

Thread-sizes.csv

 

I’m assuming that these are also statically named so while we will now have a dynamic summary.txt/html the summary.html will always pick up only one image and link to only one csv file.

 

I’ll try and get that looked into and done this morning.  You should have rights to perform a release through TeamCity whenever you want at the moment (If you don’t I need to fix that, I’m pretty sure you have full admin access to all the JMeter stuff).

 

I think we have done the pragmatic thing by providing the ability to enable the analysis of multiple tests but defaulting it to only do one.  I’ll update the README to state that you should not process multiple files because of performance implications, out of the box the functionality will remain unchanged so it won’t affect the default usage of the plugin.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/RghGmlHwePYJ.
To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/maven-jmeter-plugin-devs?hl=en-GB.

Mark Collin

unread,
Aug 1, 2012, 6:56:01 AM8/1/12
to maven-jmeter...@googlegroups.com

I’ve updated the code to add use the summary filename during csv and png file generation and updated the tests (including the IT test).

 

I’ve also updated the readme to encourage people to not use <processAllFilesFound>true</ processAllFilesFound>

 

All seems good on CI so it’s all ready to go if you’re happy with the current state of affairs.

Arne Franken

unread,
Aug 1, 2012, 3:10:12 PM8/1/12
to maven-jmeter...@googlegroups.com
Hi,

I'll have to look at your changes, but I guess we'll have to roll all that back. 
The documentation is probably not sufficient to illustrate the behaviour of the plugin.

The "detail-files" (csv and png) are created and named as follows (if the properties are set to true, which they are by default):

If there is no configuration for the property "requestGroups", a set of files is created where the name of the threadgroup of a request is used.
I guess that in the analysis you were seeing the files, the only threadgroup created by JMeter was named "Thread". If you would configure JMeter to use more than one threadgroup, those would have to have distinct names, as would the detail files.

If there is a configuration for the property "requestGroups" (a map of "requestGroup name" -> "URL pattern"), a set of files is created where the name of the requestGroup name is used.

Also, based on the same pattern, detailed statistics are generated for each threadgroup or requestgroup.

All of this is also rendered/linked into the HTML report.

Cheers,
Arne

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

Mark Collin

unread,
Aug 1, 2012, 3:17:21 PM8/1/12
to maven-jmeter...@googlegroups.com

I can see that and I haven’t changed any of the existing naming structures, I have just added another component into the filename in addition to the existing code.

 

We should still get files based upon thread names, but also based upon the .jtl filename. 

 

So if the file we parsed was called “myFile.jtl” in the old code we would have had:

 

Thread-sizes.csv

Thread-durations.csv

Thread-durations.png

 

We now get:

 

Thread-sizes-myFile.csv

Thread-durations-myFile.csv

Thread-durations-myFile.png

 

The links in the HTML summary are also rendered correctly.

 

It’s working fine with my tests but any additional checks you can do would be good to prove that it doesn’t just work with my setup.

 

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 01 August 2012 20:10
To: maven-jmeter...@googlegroups.com
Subject: Re: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

Hi,

 

I'll have to look at your changes, but I guess we'll have to roll all that back. 

The documentation is probably not sufficient to illustrate the behaviour of the plugin.

 

The "detail-files" (csv and png) are created and named as follows (if the properties are set to true, which they are by default):

 

If there is no configuration for the property "requestGroups", a set of files is created where the name of the threadgroup of a request is used.
I guess that in the analysis you were seeing the files, the only threadgroup created by JMeter was named "Thread". If you would configure JMeter to use more than one threadgroup, those would have to have distinct names, as would the detail files.

 

If there is a configuration for the property "requestGroups" (a map of "requestGroup name" -> "URL pattern"), a set of files is created where the name of the requestGroup name is used.

 

Also, based on the same pattern, detailed statistics are generated for each threadgroup or requestgroup.

 

All of this is also rendered/linked into the HTML report.

 

Cheers,

Arne

 


On Wednesday, August 1, 2012 12:56:01 PM UTC+2, Ardesco wrote:

I’ve updated the code to add use the summary filename during csv and png file generation and updated the tests (including the IT test).

 

I’ve also updated the readme to encourage people to not use <processAllFilesFound>true</ processAllFilesFound>

 

All seems good on CI so it’s all ready to go if you’re happy with the current state of affairs.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Mark Collin
Sent: 01 August 2012 10:15
To: maven-jmeter...@googlegroups.com
Subject: RE: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

I was having a look at the results on our CI server this morning and I think we may need to make another small change.  My runs are also creating :

 

Thread-durations.csv

Thread-durations.png

Thread-sizes.csv

 

I’m assuming that these are also statically named so while we will now have a dynamic summary.txt/html the summary.html will always pick up only one image and link to only one csv file.

 

I’ll try and get that looked into and done this morning.  You should have rights to perform a release through TeamCity whenever you want at the moment (If you don’t I need to fix that, I’m pretty sure you have full admin access to all the JMeter stuff).

 

I think we have done the pragmatic thing by providing the ability to enable the analysis of multiple tests but defaulting it to only do one.  I’ll update the README to state that you should not process multiple files because of performance implications, out of the box the functionality will remain unchanged so it won’t affect the default usage of the plugin.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 01 August 2012 09:24
To: maven-jmeter...@googlegroups.com
Subject: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

Hey mate,

 

the changes look good, even though I am still not very happy with the fact that multiple tests can be run/analyzed during one plugin execution, but that's another matter...

 

I fixed three things: 

- the filename wasn't used

- the extension of the filename is cut off before it's used (so the summary file name is now "test.html" instead of "test.jtl.html")

- fixed the integration test

 

The Lazerycode CI says everything is green.

 

I think the plugin is ready for a release now.

 

Cheers,

Arne



Am Freitag, 27. Juli 2012 16:08:13 UTC+2 schrieb Ardesco:

Arne,

 

I’ve checked in a couple of changes today based upon feedback in the users thread. 

 

First of all, has anything I’ve checked in today gone against your vision for the analysis plugin?

 

Secondly have you got any plans for future versions of the plugin? 

 

Right now I’m thinking it would be worth adding in some additional default templates to give people something very close to the output created by the old jmeter plugin just to highlight the flexibility of the freemarker templates if nothing else.

 

I think it’s going to be worth doing a release fairly quickly if we don’t have any real plans for additional code right now.

 

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/RghGmlHwePYJ.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.
To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

Arne Franken

unread,
Aug 1, 2012, 3:32:48 PM8/1/12
to maven-jmeter...@googlegroups.com
ah, that's good :-)

I'll test tomorrow.

Cheers,
Arne

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

Mark Collin

unread,
Aug 2, 2012, 6:30:05 AM8/2/12
to maven-jmeter...@googlegroups.com

Did a few more checks this morning after the post on user forums last night saying it didn’t work.

 

From the file generation point of view, It all looks good from here, all files are being generated correctly and the links in the html pages work correctly.

 

From the logging point of view, it would seem that SLF4J is overriding all other logging the first time the code goes into JMeterResultParser and not handing control back to anything.  So I see the following:

 

·         Plugin starts to analyse results

·         I see the first file get picked up

·         I then the Summary of the first file analysed (produced by SLF4J)

·         I then see no additional logging, nothing is printed out to screen until control of the cursor is returned.

 

I’m a bit stumped at the moment, the easy fix would seem to be just pull SLF4J out and use default maven logging since it’s only used in one class.  I’m guessing you probably know more about SLF4J than me though so I’m just leaving it as it is for now.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 01 August 2012 20:33
To: maven-jmeter...@googlegroups.com
Subject: Re: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

ah, that's good :-)

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Mark Collin
Sent: 01 August 2012 10:15
To: maven-jmeter...@googlegroups.com
Subject: RE: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

I was having a look at the results on our CI server this morning and I think we may need to make another small change.  My runs are also creating :

 

Thread-durations.csv

Thread-durations.png

Thread-sizes.csv

 

I’m assuming that these are also statically named so while we will now have a dynamic summary.txt/html the summary.html will always pick up only one image and link to only one csv file.

 

I’ll try and get that looked into and done this morning.  You should have rights to perform a release through TeamCity whenever you want at the moment (If you don’t I need to fix that, I’m pretty sure you have full admin access to all the JMeter stuff).

 

I think we have done the pragmatic thing by providing the ability to enable the analysis of multiple tests but defaulting it to only do one.  I’ll update the README to state that you should not process multiple files because of performance implications, out of the box the functionality will remain unchanged so it won’t affect the default usage of the plugin.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 01 August 2012 09:24
To: maven-jmeter...@googlegroups.com
Subject: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

Hey mate,

 

the changes look good, even though I am still not very happy with the fact that multiple tests can be run/analyzed during one plugin execution, but that's another matter...

 

I fixed three things: 

- the filename wasn't used

- the extension of the filename is cut off before it's used (so the summary file name is now "test.html" instead of "test.jtl.html")

- fixed the integration test

 

The Lazerycode CI says everything is green.

 

I think the plugin is ready for a release now.

 

Cheers,

Arne



Am Freitag, 27. Juli 2012 16:08:13 UTC+2 schrieb Ardesco:

Arne,

 

I’ve checked in a couple of changes today based upon feedback in the users thread. 

 

First of all, has anything I’ve checked in today gone against your vision for the analysis plugin?

 

Secondly have you got any plans for future versions of the plugin? 

 

Right now I’m thinking it would be worth adding in some additional default templates to give people something very close to the output created by the old jmeter plugin just to highlight the flexibility of the freemarker templates if nothing else.

 

I think it’s going to be worth doing a release fairly quickly if we don’t have any real plans for additional code right now.

 

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/RghGmlHwePYJ.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/as7Z1i72MrsJ.
To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

Arne Franken

unread,
Aug 2, 2012, 10:41:11 AM8/2/12
to maven-jmeter...@googlegroups.com
took longer to get around to it, but I just tested the plugin again and it works as you said, everything is fine from my end.

Cheers,
Arne

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

Arne Franken

unread,
Aug 2, 2012, 10:46:29 AM8/2/12
to maven-jmeter...@googlegroups.com
I just created an issue on github for that:

I'll take a look at that in the next few days, I'd say release 1.0.1 without it.


Am Mittwoch, 1. August 2012 21:17:21 UTC+2 schrieb Ardesco:

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.

To post to this group, send an email to maven-jmeter-plugin-devs@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugin-devs+unsub...@googlegroups.com.

Mark Collin

unread,
Aug 2, 2012, 11:09:36 AM8/2/12
to maven-jmeter...@googlegroups.com

Done,

 

Should be synced to live within the next couple of hours.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 02 August 2012 15:46
To: maven-jmeter...@googlegroups.com
Subject: Re: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

I just created an issue on github for that:

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Mark Collin
Sent: 01 August 2012 10:15
To: maven-jmeter...@googlegroups.com
Subject: RE: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

I was having a look at the results on our CI server this morning and I think we may need to make another small change.  My runs are also creating :

 

Thread-durations.csv

Thread-durations.png

Thread-sizes.csv

 

I’m assuming that these are also statically named so while we will now have a dynamic summary.txt/html the summary.html will always pick up only one image and link to only one csv file.

 

I’ll try and get that looked into and done this morning.  You should have rights to perform a release through TeamCity whenever you want at the moment (If you don’t I need to fix that, I’m pretty sure you have full admin access to all the JMeter stuff).

 

I think we have done the pragmatic thing by providing the ability to enable the analysis of multiple tests but defaulting it to only do one.  I’ll update the README to state that you should not process multiple files because of performance implications, out of the box the functionality will remain unchanged so it won’t affect the default usage of the plugin.

 

From: maven-jmeter...@googlegroups.com [mailto:maven-jmeter...@googlegroups.com] On Behalf Of Arne Franken
Sent: 01 August 2012 09:24
To: maven-jmeter...@googlegroups.com
Subject: [jmeter-maven-plugin-devs] Re: Changes/Enhancements for the next analysis plugin release

 

Hey mate,

 

the changes look good, even though I am still not very happy with the fact that multiple tests can be run/analyzed during one plugin execution, but that's another matter...

 

I fixed three things: 

- the filename wasn't used

- the extension of the filename is cut off before it's used (so the summary file name is now "test.html" instead of "test.jtl.html")

- fixed the integration test

 

The Lazerycode CI says everything is green.

 

I think the plugin is ready for a release now.

 

Cheers,

Arne



Am Freitag, 27. Juli 2012 16:08:13 UTC+2 schrieb Ardesco:

Arne,

 

I’ve checked in a couple of changes today based upon feedback in the users thread. 

 

First of all, has anything I’ve checked in today gone against your vision for the analysis plugin?

 

Secondly have you got any plans for future versions of the plugin? 

 

Right now I’m thinking it would be worth adding in some additional default templates to give people something very close to the output created by the old jmeter plugin just to highlight the flexibility of the freemarker templates if nothing else.

 

I think it’s going to be worth doing a release fairly quickly if we don’t have any real plans for additional code right now.

 

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/RghGmlHwePYJ.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/yBgUYArNX1UJ.

To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Maven JMeter Plugin Devs" group.

To view this discussion on the web, visit https://groups.google.com/d/msg/maven-jmeter-plugin-devs/-/JSB2BwtBSRMJ.
To post to this group, send an email to maven-jmeter...@googlegroups.com.
To unsubscribe from this group, send email to maven-jmeter-plugi...@googlegroups.com.

Reply all
Reply to author
Forward
0 new messages