JUpdate not working in Master Branch of Github

130 views
Skip to first unread message

Javier Gómez

unread,
Jul 26, 2012, 11:22:33 PM7/26/12
to joomla-...@googlegroups.com
Hi,

I know that you are adding many things to the Joomla Master branch at the moment, so I totally understand that JUpdate doesn't work right now. But just in case you haven't noticed: if you use:

$update = new JUpdate;
$package_url = $update->get('downloadurl', false)->_data;

The resulting $package_url doesn't have de download package url. This works in joomla 2.5.6 but not in the current master branch.

I have been debuging a lot, and I guess that the problem comes from the new added lines added to JUpdate in the method:

/libraries/joomla/updater/update.php
line 297 public function loadFromXML($url)

not sure, but maybe the problem comes from:  $http = JHttpFactory::getHttp();


Michael Babker

unread,
Jul 26, 2012, 11:25:32 PM7/26/12
to joomla-...@googlegroups.com
I know we've fixed a few issues that crept into the update package on the Platform repo, but I'm not 100% certain if they made it back into the CMS yet.  Could you check there to see if this one may have been fixed already?

--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/BKqgY5WnL4YJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.

javier gómez

unread,
Jul 26, 2012, 11:34:25 PM7/26/12
to joomla-...@googlegroups.com
I'm not using the Platform but the CMS master branch. So that means that is not solved ^_^
--
Javi

JM Simonet

unread,
Jul 27, 2012, 3:18:18 AM7/27/12
to joomla-...@googlegroups.com
I confirm the issue when using the update lang packs and updateservers.

Using master:
Install French pack 2.5.4.2
Extensions update righfully proposes the 2.5.6.1 pack to install
trying to install gives an error:
Invalid extension update
Using Rouven's php53 branch which is updated to last platform (afaik)
same issue

JM
Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not disclose or use the information contained in this e-mail if you are not the
intended recipient. If you have received this e-mail in error, please notify us immediately and delete the e-mail and all copies.
-----------------------------------------------------------
Jean-Marie Simonet  /  infograf768
Joomla Production Working group
Joomla! Translation Coordination Team 

JM Simonet

unread,
Jul 28, 2012, 4:05:36 AM7/28/12
to joomla-...@googlegroups.com
I have openend a tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28878

JM

elin

unread,
Jul 28, 2012, 12:32:40 PM7/28/12
to joomla-...@googlegroups.com
https://github.com/joomla/joomla-platform/commit/1cc0e3f5fb491b791339d95b311174971d8d3196#libraries/joomla/updater/update.php


Would you try undoing that change?

Elin
To post to this group, send an email to joomla-dev-cms@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To post to this group, send an email to joomla-dev-cms@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.



--
Javi
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To post to this group, send an email to joomla-dev-cms@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.


--
Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not disclose or use the information contained in this e-mail if you are not the
intended recipient. If you have received this e-mail in error, please notify us immediately and delete the e-mail and all copies.
-----------------------------------------------------------
Jean-Marie Simonet  /  infograf768
Joomla Production Working group
Joomla! Translation Coordination Team 
--
You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
To post to this group, send an email to joomla-dev-cms@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cms+unsubscribe@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.

Michael Babker

unread,
Jul 28, 2012, 12:34:43 PM7/28/12
to joomla-...@googlegroups.com
That change is needed.  Otherwise, you get a blank body/data element.

To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/gz-vpq4BinoJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.

Michael Babker

unread,
Jul 28, 2012, 12:38:43 PM7/28/12
to joomla-...@googlegroups.com
CMS master isn't in sync with the Platform at the moment.  This change is in the Platform but not the CMS.  Could you try with that change on the CMS master (or Rouven's php53 branch, I think it has that change) and see what happens?  I know there was one other instance of $response->data that had to change to body as well.

From: elin <elin....@gmail.com>
Reply-To: <joomla-...@googlegroups.com>
Date: Saturday, July 28, 2012 11:32 AM
To: <joomla-...@googlegroups.com>
To view this discussion on the web, visit https://groups.google.com/d/msg/joomla-dev-cms/-/gz-vpq4BinoJ.
To post to this group, send an email to joomla-...@googlegroups.com.
To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.

elin

unread,
Jul 28, 2012, 1:20:11 PM7/28/12
to joomla-...@googlegroups.com
JM said he had tried it on the 53 branch and it was broken but absolutely worth trying in the CMS.

Elin
Reply all
Reply to author
Forward
0 new messages