duplicate aliases in config

[Jason S]

I have two independent .jar files that use JXTable.

When each of my classes uses JXTable, I call

SwingJavaBuilderConfig config = SwingJavaBuilder.getConfig();
config.addType("JXTable", JXTable.class);

and on the 2nd time I get the error

org.javabuilders.DuplicateAliasException: Duplicate alias 'JXTable' for class 'org.jdesktop.swingx.JXTable'. One already exists for 'org.jdesktop.swingx.JXTable'

How can I do this the right way to prevent calling addType() twice? I tried SwingJavaBuilderConfig.isTypeDefined(JXTable.class) but that's not right.

[Jason S]

...odd.... I'm stepping through the debugger and looking at source code https://github.com/jacek99/javabuilders/blob/master/javabuilder-parent/javabuilder-core/src/main/java/org/javabuilders/BuilderConfig.java

and I see JXTable in the typeAliases map but not in the typeDefinitions map.

My concurrency radar is up: when potentially dealing with multiple threads, should I synchronize on SwingJavaBuilder.getConfig() ?

[Jason S]

never mind, typeAliases and typeDefinitions are two different things. This works (w/ thread-safety added just to be sure):

    static public boolean addJavaBuilderClass(String alias, Class<?> cl)
    {
        SwingJavaBuilderConfig config = SwingJavaBuilder.getConfig();
        synchronized(config)
        {
            Class<?> cl0 = config.getClassType(alias);
            if (cl0 == null)
            {
                config.addType(alias, cl);
                return true;
            }
            else
            {
                return false;
            }
        }
    }

[Jacek Furmankiewicz]

We can probably do better than that...if the new alias is the same as the old one (in terms of the Class) we could probably

silently ignore it.

Since most initialization like this happens on a single thread, I wouldn't worry about the synchronized too much,

unless your app behaves differently on startup.

            }
        }
    }

--
You received this message because you are subscribed to the Google Groups "JavaBuilders" group.

To view this discussion on the web visit https://groups.google.com/d/msg/javabuilders/-/OIZdkYq2IQoJ.

To post to this group, send email to javabu...@googlegroups.com.
To unsubscribe from this group, send email to javabuilders...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/javabuilders?hl=en.