Proposed: jallib.py check changed files

[Mike K]

I coded this last night, because I thought it would be useful.  Maybe you guys can tell me if it is or not.

"jallib.py check"

It gets the list of changed/added files from "svn status" and runs them through the "jallib.py reindent" and "jallib.py validate" operations.

Mike

[Sebastien Lelong]

Hi Mike,

That sounds interesting but how cross-platform it is ? How do you "svn status", calling executable on OS ?

Cheers

Seb

Mike

--
You received this message because you are subscribed to the Google Groups "jallib" group.
To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/WoH7nvV-ct8J.
To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

That was going to be my next question...How are people using SVN?  There are a couple ways this could be done.  One is with the PYSVN module, but that obviously requires people to install it.  The way I chose was to call SVN from the command line, that's what the "svn status" is.  Don't all variations of SVN have command line access?

Mike

[Sebastien Lelong]

For Windows users, svn.exe must be installed, and it's not the common (in a windows sense) way to have access to SVN. Usually people uses TortoiseSVN, and this package does not include svn.exe. More, you may have troubles just because it's not in %PATH% environment variable, so you would have to specify full path to exec...

PySVN might be an option, just make sure to not force people to install to use jallib.py (conditional import).

Cheers,

Seb

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/PEqXPvekl1gJ.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

Okay, thanks Seb.

Mike

[Sunish Issac]

TortoiseSVN has the option to install svn.exe if the custom install option is selected with cmdline tools/ utils.

The existence of svn.exe can be verified by using the registry key HKEY_LOCAL_MACHINE\SOFTWARE\TortoiseSVN\ with keyname Directory to get the path of installed folder and then append svn.exe to get the full path.

The python script can probably first try running svn.exe and if it fails, the above mentioned method can be used.

BTW is jallibwin updated with the new changes ? I had plans to integrate it into jaledit so that all of its options are available in jaledit.

Regards,

Sunish

[Mike K]

Hi Sunish,

What is jallibwin?  And what new changes are you referring to?  What we're talking about in this thread is just a discussion.

Regards,
Mike

[Sebastien Lelong]

Hi guys,

jallibwin.exe is jallib.py packaged with dependencies. It can be used under Windows without having to install all dependencies. Recent changes were for instance "jallib validate *".

I need to rebuild it, but don't have a win box around here, I'll see what I can do :)

Cheers

Seb

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/IipoTP_yKXwJ.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

I just tried to build it, but it failed.

Mike

[Sebastien Lelong]

Hi Mike


Can you tell me more (output) ? Did you use buildjallibwin.bat script ? IIRC that's more of a recipe :)
It requires pyinstaller, specific version, but other may work as well.

Cheers
Seb

> To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/6Dy8d7gT7BIJ.

[Mike K]

Hi Seb,

I downloaded PyInstaller, but I'm not sure it is installed correctly.  I get a "No module named PyInstaller" error.  As usual with Python stuff, I don't see any clear instructions for installing it on a Windows machine.  The documentation says I need only place the unzipped directory in the Python folder and run the Configure.py script, but that scripts references the PyInstaller module...which is not installed.  Seems to be a catch-22 there.

Mike

[Mike K]

Okay, I think I have it built.  Should someone check it first?...or should I check it in to SVN?

Mike

[Sebastien Lelong]

Great ! Just commit it so you can share it.

Thanks

Seb

On 5 December 2012 20:17, Mike K <upand_...@yahoo.com> wrote:

Okay, I think I have it built.  Should someone check it first?...or should I check it in to SVN?

Mike

--
You received this message because you are subscribed to the Google Groups "jallib" group.

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/eRTNn-BrQooJ.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

Hmm.  It's just over 1MB in size, the previous version is only 636KB.  Also, it doesn't have the same icon.  Is this a function of which machine I build it on?

Mike

[Sebastien Lelong]

I can't remember having set a icon, no big deal anyway. As for the size, pyinstaller embeds many things, maybe dependencies versions make it bigger ? Same python version embedded ? It's not that much suspicious IMO.

Cheers,

Seb

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/HpdzFS1lI6AJ.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

Well, I have Python 2.7 installed.  The "buildjallibwin.bat" file references Python 2.5.  I'm also using PyInstaller 2.0, if that matters.

Mike

[Sebastien Lelong]

That may explain the difference. Have you tested it ? Just commit it or post it here as attachment (you may need to rename as I guess exe are forbidden).

Cheers,

seb

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/eCL3WpoDqX8J.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong

[Mike K]

Okay, it works fine on my machine.  If it proves not to work on others I'll roll it back to the previous version.

Regards,
Mike

[Rob Hamerling]

Hello Mike,

It seems I've missed something....
I just did a checkout of all Jallib, but I didn't find an updated
jallib.py (with the 'check' option). Did you commit it? If yes, then I
don't understand why it is not on my local Jallib copy.
I did see a new jallibwin.exe, of which I suppose it contains the check
option. But how got it updated with 'check'?
I don't use windows but ran it in my windows emulator (Odin under
eComStation). This gives a popup window with an error message:
'The application has called the non-existing api
KERNEL32.DLL->HeapSetinformation (loaded by JALLIBWIN.EXE)'
Don't know why this happens. Anyway, end of exercise....

Regards, Rob.

--
R. Hamerling, Netherlands --- http://www.robh.nl

[Mike K]

Hi Rob,

I didn't add the "check" command.  It's still in the "thought exercise" phase. :)  I have my local copy modified to see if I find it useful.

The build of "jallibwin.exe" was only for my previous changes to allow wildcards for the "validate" and "reindent" command.  Oh, wait a minute...I think I know what went wrong.  I built jallibwin.exe from the wrong jallib.py.  I'll check in an updated one.  Sorry.

Regards,
Mike

[Mike K]

Rob,

If the new version I just checked in doesn't work I can try compiling with a different version of Python.

Mike

[Rob Hamerling]

Hello Mike,

On 6-12-12 18:50, Mike K wrote:

> If the new version I just checked in doesn't work I can try compiling
> with a different version of Python.

This version gives the same error message with me. It is probably better
to have it tested by a 'native' Windows user (which I'm not).

[Mike K]

Hi Rob,

Hmm...I did test it on my Windows machine.

Mike

[Sebastien Lelong]

Maybe Sunish can test it within jaledit, let's wait this his test.

Thanks

Seb

--

You received this message because you are subscribed to the Google Groups "jallib" group.

To view this discussion on the web visit https://groups.google.com/d/msg/jallib/-/l5KiqyvvtgcJ.

To post to this group, send email to jal...@googlegroups.com.
To unsubscribe from this group, send email to jallib+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/jallib?hl=en.

--
Sébastien Lelong