automatically unsinking event when no hanlders present ?

32 views
Skip to first unread message

Ed

unread,
Apr 24, 2012, 11:06:37 AM4/24/12
to google-we...@googlegroups.com
Hi,
GWT automatically sinks the required event type when the first handlers is added of certain event type (done in Widget class).

Whay about automatically unsinking when a handler is remove and you notice that no handlers of that event type is present anymore?
Is this worth doing?

Note in my case setup it's easy to wrap the HandlerRegistration and detect if any handler is still present on a removeHandler action, but is this worth doing?
So is the cost of wrapping and detecting worth it?

- Ed

Joseph Lust

unread,
Apr 25, 2012, 7:45:37 PM4/25/12
to google-we...@googlegroups.com
The DOM handlers are automatically removed by GWT when you destroy that object (i.e. that widget is removed from the DOM). This is why you should always capture browser events in this way rather than using JSNI. If you do create your own custom handlers, then you'll need to remove those onDetach() of the widget or you'll have a leak.


Sincerely,
Joseph

Ed Bras

unread,
Apr 26, 2012, 6:59:49 AM4/26/12
to google-we...@googlegroups.com
Thanks,  but what happens when the widget isn't destroyed and the handlers of a certain type are all removed? 
Is it worth to unsink the events as no handler of that type is present, or just do nothing (like GWT is doing current)?
- Ed


--
You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/uSvSKur4VocJ.
To post to this group, send email to google-we...@googlegroups.com.
To unsubscribe from this group, send email to google-web-tool...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.

Reply all
Reply to author
Forward
0 new messages