Re: code review 9322043: net: make LookupCNAME querying CNAME type (issue 9322043)

mikioh...@gmail.com

unread,

May 20, 2013, 6:02:28 AM5/20/13

to golan...@googlegroups.com, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

ping

https://codereview.appspot.com/9322043/

Brad Fitzpatrick

unread,

May 20, 2013, 2:00:07 PM5/20/13

to Mikio Hara, golang-dev, re...@codereview-hr.appspotmail.com

No test?

Would it help if I created a CNAME under golang.org for the test to hit?

On Mon, May 20, 2013 at 3:02 AM, <mikioh...@gmail.com> wrote:

ping

https://codereview.appspot.com/9322043/

--

---You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

r...@golang.org

unread,

May 20, 2013, 2:54:13 PM5/20/13

to mikioh...@gmail.com, golan...@googlegroups.com, brad...@golang.org, golan...@googlegroups.com, re...@codereview-hr.appspotmail.com

NOT LGTM

The whole point of the cgo stuff is to avoid using the pure Go DNS code,
for systems where it does not work (such as OS X, behind a firewall).

https://codereview.appspot.com/9322043/

Mikio Hara

unread,

May 22, 2013, 10:05:32 AM5/22/13

to Mikio Hara, golang-dev, Brad Fitzpatrick, Russ Cox, re...@codereview-hr.appspotmail.com

On Tue, May 21, 2013 at 3:54 AM, <r...@golang.org> wrote:

> The whole point of the cgo stuff is to avoid using the pure Go DNS code,
> for systems where it does not work (such as OS X, behind a firewall).

Fine. So shall we change the status of issue 5038 to unfortunate?

Mikio Hara

unread,

May 29, 2013, 8:29:47 PM5/29/13

to Mikio Hara, golang-dev, Brad Fitzpatrick, Russ Cox, re...@codereview-hr.appspotmail.com

Russ?

Reply all

Reply to author

Forward