Re: code review 9322043: net: make LookupCNAME querying CNAME type (issue 9322043)

瀏覽次數:60 次
跳到第一則未讀訊息

mikioh...@gmail.com

未讀,
2013年5月20日 清晨6:02:282013/5/20
收件者:golan...@googlegroups.com、golan...@googlegroups.com、re...@codereview-hr.appspotmail.com

Brad Fitzpatrick

未讀,
2013年5月20日 下午2:00:072013/5/20
收件者:Mikio Hara、golang-dev、re...@codereview-hr.appspotmail.com
No test?

Would it help if I created a CNAME under golang.org for the test to hit?



On Mon, May 20, 2013 at 3:02 AM, <mikioh...@gmail.com> wrote:
ping

https://codereview.appspot.com/9322043/


--

---You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



r...@golang.org

未讀,
2013年5月20日 下午2:54:132013/5/20
收件者:mikioh...@gmail.com、golan...@googlegroups.com、brad...@golang.org、golan...@googlegroups.com、re...@codereview-hr.appspotmail.com
NOT LGTM

The whole point of the cgo stuff is to avoid using the pure Go DNS code,
for systems where it does not work (such as OS X, behind a firewall).


https://codereview.appspot.com/9322043/

Mikio Hara

未讀,
2013年5月22日 上午10:05:322013/5/22
收件者:Mikio Hara、golang-dev、Brad Fitzpatrick、Russ Cox、re...@codereview-hr.appspotmail.com
On Tue, May 21, 2013 at 3:54 AM, <r...@golang.org> wrote:

> The whole point of the cgo stuff is to avoid using the pure Go DNS code,
> for systems where it does not work (such as OS X, behind a firewall).

Fine. So shall we change the status of issue 5038 to unfortunate?

Mikio Hara

未讀,
2013年5月29日 晚上8:29:472013/5/29
收件者:Mikio Hara、golang-dev、Brad Fitzpatrick、Russ Cox、re...@codereview-hr.appspotmail.com
Russ?
回覆所有人
回覆作者
轉寄
0 則新訊息