[patch] Fix Echoplex and DM Delay on RP355

[Torsten Stremlau]

I'm using an RP355 V1.4 and I noticed an assertion when setting the Delay to "Echoplex" or "DM Delay".

I got the following output:
**
ERROR:gui.c:760:update_modifier_vbox: assertion failed: (group[x].label)
Abgebrochen (Speicherabzug geschrieben)


I wrote the following patch to fix the problem.


diff -r d7c391da07eb effects.c
--- a/effects.c    Sa Jan 19 22:07:01 2013 +0100
+++ b/effects.c    Sa Jan 19 22:36:32 2013 +0100
@@ -3492,6 +3492,13 @@
     {"Delay Mod Depth", DELAY_DEPTH, DELAY_POSITION, &values_0_to_99},
     {"Delay Tape Wow", DELAY_TAPE_WOW, DELAY_POSITION, &values_0_to_99},
     {"Delay Tape Flut", DELAY_TAPE_FLUTTER, DELAY_POSITION, &values_0_to_99},
+    {"Delay Echoplex Time", DELAY_ECHOPLEX_TIME, DELAY_POSITION, &values_0_to_99},
+    {"Delay Repeats 0 99", DELAY_REPEATS_0_99, DELAY_POSITION, &values_0_to_99},
+    {"Delay Volume", DELAY_VOLUME, DELAY_POSITION, &values_0_to_99},
+    {"Delay Repeat Rate", DELAY_REPEAT_RATE_DM, DELAY_POSITION, &values_0_to_99},
+    {"Delay Echo", DELAY_ECHO, DELAY_POSITION, &values_0_to_99},
+    {"Delay Intensity", DELAY_INTENSITY, DELAY_POSITION, &values_0_to_99},
+
     {"Reverb Enable", REVERB_ON_OFF, REVERB_POSITION, &values_on_off},
     {"Reverb Decay", REVERB_DECAY, REVERB_POSITION, &values_0_to_99},
     {"Reverb Liveliness", REVERB_LIVELINESS, REVERB_POSITION, &values_0_to_99},
@@ -4165,6 +4172,12 @@
     {DELAY_DEPTH, DELAY_POSITION, "Delay Mod Depth", &values_0_to_99,},
     {DELAY_TAPE_WOW, DELAY_POSITION, "Delay Tape Wow", &values_0_to_99,},
     {DELAY_TAPE_FLUTTER, DELAY_POSITION, "Delay Tape Flut", &values_0_to_99,},
+    {DELAY_ECHOPLEX_TIME, DELAY_POSITION, "Delay Echoplex Time", &values_0_to_99},
+    {DELAY_REPEATS_0_99, DELAY_POSITION, "Delay Repeats 0 99", &values_0_to_99},
+    {DELAY_VOLUME, DELAY_POSITION, "Delay Volume", &values_0_to_99},
+    {DELAY_REPEAT_RATE_DM, DELAY_POSITION, "Delay Repeat Rate", &values_0_to_99},
+    {DELAY_ECHO, DELAY_POSITION, "Delay Echo", &values_0_to_99},
+    {DELAY_INTENSITY, DELAY_POSITION, "Delay Intensity", &values_0_to_99},
 
     {REVERB_TYPE, REVERB_POSITION, "Reverb Type", &values_reverb_type, xml_reverb_labels, G_N_ELEMENTS(xml_reverb_labels)},
     {REVERB_ON_OFF, REVERB_POSITION, "Reverb Enable", &values_on_off, xml_on_off_labels, G_N_ELEMENTS(xml_on_off_labels)},

[Tim LaBerge]

If you check my github repository, I think these are fixed there. But it may be some time before I push the changes as they are entangled in a larger changeset that is work in progress.

tjl

--
You received this message because you are subscribed to the Google Groups "gdigi" group.
To view this discussion on the web visit https://groups.google.com/d/msg/gdigi/-/MORhzyDwENoJ.
To post to this group, send email to gd...@googlegroups.com.
To unsubscribe from this group, send email to gdigi+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/gdigi?hl=en.