Coding style -- we've never really discussed it

Jeremy D. Miller

unread,

Jan 6, 2012, 6:19:02 PM1/6/12

to FubuMVC Develop

Folks,

We've never really had a conversation about coding style in the fubu projects. The prevailing style is (the arbitrary C# style that I adopted years ago at ThoughtWorks):

* public members are Pascal cased

* anything non-public (private, internal, protected) is camel cased

* fields are prefaced with _'s -- except in unit tests. I like the "theSomething" convention that I picked up from an old TW colleage

* Use {} on all if/then statements unless it's all one line like "if (something) return;"

* Mostly use the "I" nomenclature for interfaces because everyone understands it

Do we care? I know it's all arbitrary and consistency is all that's important.

And just so you know, I'm feeling like this guy for even writing this post: http://www.nbc.com/saturday-night-live/video/cooking-with-the-anal-rententive-chef/2867/

What's not negotiable, and I think we all do decent job of this anyway:

* Favor composition over inheritance when you can

* Small classes & methods with cohesive responsibilities (all that SOLID mumbo jumbo, and not because "of fear of CodeBetter guys," but because it makes things work out better in the long run)

Jeremy D. Miller
The Shade Tree Developer
jeremy...@yahoo.com

Chad Myers

unread,

Jan 6, 2012, 6:22:29 PM1/6/12

to fubumv...@googlegroups.com

+1. I twitch a little at the inconsistency of _ and no_ in tests, but it's all style and taste and there's no accounting for taste, so it might as well be that or anything.

-Chad

--
You received this message because you are subscribed to the Google Groups "FubuMVC Development Group" group.
To post to this group, send email to fubumv...@googlegroups.com.
To unsubscribe from this group, send email to fubumvc-deve...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/fubumvc-devel?hl=en.

Dru Sellers

unread,

Jan 6, 2012, 6:33:02 PM1/6/12

to fubumv...@googlegroups.com

I prefer leaving 'private' keyword off of private items as that is the default for fields and methods.

-d

Ian Battersby

unread,

Jan 6, 2012, 6:45:20 PM1/6/12

to fubumv...@googlegroups.com

I prefer 100% explicitness and consistency, I'm afraid I even turn on StyleCop naming conventions (only) to enforce this - test assemblies too.

.. and yes that even means putting "internal" on a console app ;)

PS. Just my two-penniesworth, I already follow the existing convention of any OSS projects in pull requests.

PPS. I was once labelled "StyleNazi" by a colleague of notable ranting reputation :p

Adam Dymitruk

unread,

Jan 6, 2012, 8:15:38 PM1/6/12

to fubumv...@googlegroups.com

Why not adopt what a large code base that is C# has? Project mono
comes to mind...

--
Adam

http://adventuresinagile.blogspot.com/
http://twitter.com/adymitruk/
http://www.agilevancouver.ca/
http://altnetvan.grou.ps/

ahjohannessen

unread,

Jan 7, 2012, 9:19:14 AM1/7/12

to fubumv...@googlegroups.com

I like all of those and have tried to follow your style to my best.

One thing I like as well is when doing expressions like this:

blah.Each(p =>
{
// more than one line
});

I prefer having the { vertically aligned with whatever started the expression instead of having it like this:

chuck.Each(p =>

{
// code
});

A minor OCD thing :D