scijava-common dependencies

[Barry DeZonia]

Hey all,

I am trying to eliminate some code redundancy in OPS by refactoring to use scijava-common's DoubleArray. However neither OPS nor Imglib2 core have a scijava-common dependency. Should one or both?

I've made my changes on a branch called kill-prim-double-array that puts a dependency on scijava-common into OPS. I'm not sure this is desirable. Seeking feedback.

[Johannes Schindelin]

Hi Barry,

On Fri, 19 Jul 2013, Barry DeZonia wrote:

> I am trying to eliminate some code redundancy in OPS by refactoring to
> use scijava-common's DoubleArray. However neither OPS nor Imglib2 core
> have a scijava-common dependency. Should one or both?

I suggest adding it to -ops. Should imglib2-core eventually rely on
scijava-common, too, it needs to be added there as a dependency, too...
with Maven projects, it is not recommended to rely on transitive
dependencies, but list all the dependencies you link to (IOW if you use a
class from scijava-common in -ops, it needs to be an explicit dependency
-- lest the transitive dependency go away one day).

Ciao,
Dscho

[Barry DeZonia]

Thanks Johannes, that is the current solution. But I may have not asked my question very clearly. Does anyone object to OPS depending upon scijava-common?

[Johannes Schindelin]

Hi Barry,

On Sun, 21 Jul 2013, Barry DeZonia wrote:

> But I may have not asked my question very clearly. Does anyone object to
> OPS depending upon scijava-common?

I think there are good reasons for -ops to depend on SciJava-common... for
example the desperate need to @Plugin-ify the -ops.

Ciao,
Johannes

[Curtis Rueden]

Hi everyone,

I am also in favor of using scijava-common from ops, and even from imglib2 core if useful. That's what the library is for,  after all.

-Curtis

--
--
Please avoid top-posting, and please make sure to reply-to-all!

Mailing list web interface: http://groups.google.com/group/fiji-devel

---
You received this message because you are subscribed to the Google Groups "Fiji-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fiji-devel+...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Johannes Schindelin]

Hi Curtis,

On Sun, 21 Jul 2013, Curtis Rueden wrote:

> I am also in favor of using scijava-common from ops, and even from imglib2
> core if useful. That's what the library is for, after all.

I agree, but I sensed some reluctance from Steffi and Tobias when we
talked about this at the recent ImgLib2 hackathon (although I cannot
recall any compelling argument in disfavor of adding the dependency).

Ciao,
Dscho