Cucumber-jvm failing on Build

[Konstantinos Papalias]

Not sure if it's only me having this issue but while trying to build cucumber-jvm with: 

mvn clean install 

it does fail in core project on ClasspathTest. 

I'm attaching the generated errors for your convenience. 

[aslak hellesoy]

Windows?

Works fine for me on OS X and Ubuntu.

Aslak

>
> --
> You received this message because you are subscribed to the Google Groups
> "Cukes" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/cukes/-/6cFZGup6FJQJ.
> To post to this group, send email to cu...@googlegroups.com.
> To unsubscribe from this group, send email to
> cukes+un...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/cukes?hl=en.
>

[Aslak Hellesøy]

On Aug 18, 2011, at 18:23, aslak hellesoy <aslak.h...@gmail.com> wrote:

> On Thu, Aug 18, 2011 at 6:20 PM, Konstantinos Papalias
> <pkwnst...@gmail.com> wrote:
>> Not sure if it's only me having this issue but while trying to build
>> cucumber-jvm with:
>> mvn clean install
>> it does fail in core project on ClasspathTest.
>> I'm attaching the generated errors for your convenience.
>
> Windows?
>

Should be easy to fix for Windows, just need to use backslashes in a few places.

Want to try fixing it?

Aslak.

[arti singh]

I tried to build cucumber-jvm on Windows 7  and it failed on Java Core while running the classpath test. I will modify the test and see if I can get the build to pass.

--

[aslak hellesoy]

On Fri, Aug 19, 2011 at 11:54 AM, arti singh <arti.p...@gmail.com> wrote:
> I tried to build cucumber-jvm on Windows 7  and it failed on Java Core while
> running the classpath test. I will modify the test and see if I can get the
> build to pass.
>

Changing a test to make it pass is usually equivalent to sweeping dirt
under a carpet. It doesn't fix a problem, it just gives the illusion
of fixing it.

To make things work you'll have to make changes to Classpath.java so
it works on Windows. Maybe using File.PATH_SEPARATOR instead of "/" in
a few places will do the trick.

Aslak

[Konstantinos Papalias]

Hi Aslak,

Yes, I am using Windows to build the project, but I feel the project would benefit by being OS independent. 

Even if I manually fix the test-case for windows the first test will still fail with:

  looksUpInstantiableSubclassesOnClassPath(cucumber.runtime.ClasspathTest): expected:<[class cucumber.runtime.ClasspathTest$Wilma, class cucumber.runtime.ClasspathTest$Fred]> but was:<[]>

By looking at the Classpath.java file we would need to replace the hard-coded forward slashes with File.separator plus all other Unix specific path attributes. 

Thanks,

konstantinos

[arti.p...@gmail.com]

I got the same error also after I fixed the classpath in Classpath.java.

Sent from my BlackBerry device on the Rogers Wireless Network

---

From: Konstantinos Papalias <pkwnst...@gmail.com>

Sender: cu...@googlegroups.com

Date: Fri, 19 Aug 2011 05:28:50 -0700 (PDT)

To: <cu...@googlegroups.com>

ReplyTo: cu...@googlegroups.com

Cc: aslak hellesoy<aslak.h...@gmail.com>

Subject: Re: [Cucumber:8771] Cucumber-jvm failing on Build

--

You received this message because you are subscribed to the Google Groups "Cukes" group.

To view this discussion on the web visit https://groups.google.com/d/msg/cukes/-/OMLU7yhmCfIJ.

[aslak hellesoy]

On Fri, Aug 19, 2011 at 1:28 PM, Konstantinos Papalias
<pkwnst...@gmail.com> wrote:
> Hi Aslak,
> Yes, I am using Windows to build the project, but I feel the project would
> benefit by being OS independent.

Of course, that goes without saying.

> Even if I manually fix the test-case for windows the first test will still
> fail with:
>   looksUpInstantiableSubclassesOnClassPath(cucumber.runtime.ClasspathTest):
> expected:<[class cucumber.runtime.ClasspathTest$Wilma, class
> cucumber.runtime.ClasspathTest$Fred]> but was:<[]>
> By looking at the Classpath.java file we would need to replace the
> hard-coded forward slashes with File.separator plus all other Unix specific
> path attributes.

That sounds right. Please send a pull request when you have passing
tests, and I can verify that tests still pass on OS X/Linux.

Aslak

> Thanks,
> konstantinos