when.js 1.5.2 - Promises/A test suite integration

28 views
Skip to first unread message

Brian Cavalier

unread,
Oct 22, 2012, 3:34:05 PM10/22/12
to cuj...@googlegroups.com
We just released when.js 1.5.2.  There's no functional change, but this release integrates Domenic Denicola's Promises/A Test Suite.  Now, running npm test (npm install first) will run both when.js's own unit tests and the Promises/A Test Suite.  It's great to have a test suite like this that is being actively developed and contributed to by various promise implementors (we've already made a couple contributions).  It helps both library authors, and application devs.

If you're already using 1.5.0 or 1.5.1, this is a drop-in upgrade since there were no other changes.

Karolis Narkevičius

unread,
Oct 22, 2012, 3:43:28 PM10/22/12
to cuj...@googlegroups.com

Good work!
I'm curious about the 'always a sync callback behavior', is that not part of Domenic's test suite?

On Oct 22, 2012 8:34 PM, "Brian Cavalier" <br...@hovercraftstudios.com> wrote:
We just released when.js 1.5.2.  There's no functional change, but this release integrates Domenic Denicola's Promises/A Test Suite.  Now, running npm test (npm install first) will run both when.js's own unit tests and the Promises/A Test Suite.  It's great to have a test suite like this that is being actively developed and contributed to by various promise implementors (we've already made a couple contributions).  It helps both library authors, and application devs.

If you're already using 1.5.0 or 1.5.1, this is a drop-in upgrade since there were no other changes.

--
You received this message because you are subscribed to the Google Groups "cujojs" group.
To post to this group, send email to cuj...@googlegroups.com.
To unsubscribe from this group, send email to cujojs+un...@googlegroups.com.
Visit this group at http://groups.google.com/group/cujojs?hl=en.
To view this discussion on the web visit https://groups.google.com/d/msg/cujojs/-/LT-n-HH6DlgJ.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Brian Cavalier

unread,
Oct 22, 2012, 8:10:39 PM10/22/12
to cuj...@googlegroups.com
Yep, it is, but it's an extension, since Promises/A doesn't specify that as required behavior.  So, `npm test` runs the strict promises-a portion of his test suite, but not the extensions.  If you want to run the promises-a tests plus the extensions, you can do: npm run-script test-all

when.js passes everything except the always async tests :)
Reply all
Reply to author
Forward
0 new messages