Disabling treating warnings as errors on Windows?

[Juan Lang]

Hi all,

I'm trying to build with VS2010, and I keep getting tripped by build warnings being treated as errors in third_party code. E.g.:

4>------ Build started: Project: libyuv, Configuration: Debug Win32 ------

(snip)

4>ClCompile:

4>  row_win.cc

4>source\row_win.cc(3701): error C2220: warning treated as error - no 'object' file generated

4>source\row_win.cc(3701): warning C4102: 'alignloop1b' : unreferenced label

To forestall one obvious question, I did sync to lkgr.

I started by working around them individually, but it's going to get tedious quickly. How can I disable them universally?

Is there another workaround? Thanks,

--Juan

[Scott Graham]

Generally, we should probably fix/upstream them. For silly ones (like C4102), you can add a gyp variable like this in the project's build file or at a more common level if it seems warranted.

    'msvs_disabled_warnings': [ 4102 ],

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Juan Lang]

Sounds good. Naive followup: does lkgr not ensure building on VS2010?

Thanks,
--Juan

2012/11/21 Scott Graham <sco...@chromium.org>:

[Ryan Sleevi]

LKGR is totally building on VS2010. Visual Studio 2008 was deprecated
in October - see
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/SEbh9WVx2EQ/discussion

[Scott Graham]

Ah, I misunderstood your question, sorry.

There should be no warnings* on Windows at head, so something must be not-quite-right in your tree? I assumed you were updating libyuv.

* libvpx and mesa currently evade the hammer-of-shut-yer-trap, but they'll be fixed real soon now.

[Juan Lang]

Thanks for the feedback. I'll try getting the tree again, though I did
just sync to lkgr today. I'll report back if it continues to be a
problem for me.

Thanks.